From sacadmin Mon Jul 13 17:54:35 2009 Received: from noho.sfbay.sun.com (noho.SFBay.Sun.COM [10.6.92.101]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n6E0sZnR018554; Mon, 13 Jul 2009 17:54:35 -0700 (PDT) Received: from noho.sfbay.sun.com (localhost [127.0.0.1]) by noho.sfbay.sun.com (8.13.7+Sun/8.13.7) with ESMTP id n6E0sY6a021280; Mon, 13 Jul 2009 17:54:34 -0700 (PDT) Received: (from dmk@localhost) by noho.sfbay.sun.com (8.13.7+Sun/8.13.7/Submit) id n6E0sYIT021276; Mon, 13 Jul 2009 17:54:34 -0700 (PDT) Date: Mon, 13 Jul 2009 17:54:34 -0700 (PDT) From: David Kahn Message-Id: <200907140054.n6E0sYIT021276@noho.sfbay.sun.com> To: FWARC-record@sac.sfbay.sun.com Subject: sun4v io-api update (add CRS handling) [FWARC/2009/393 FastTrack] Status: RO Content-Length: 573 Template Version: @(#)sac_nextcase 1.68 02/23/09 SMI This information is Copyright 2009 Sun Microsystems 1. Introduction 1.1. Project/Component Working Name: sun4v io-api update (add CRS handling) 1.2. Name of Document Author/Supplier: Author: Meeta Saggi 1.3 Date of This Document: 13 July, 2009 4. Technical Description See the case directory for more detail 6. Resources and Schedule 6.4. Steering Committee requested information 6.4.1. Consolidation C-team Name: sysfw 6.5. ARC review type: FastTrack 6.6. ARC Exposure: open From sacadmin Mon Jul 13 18:06:55 2009 Received: from noho.sfbay.sun.com (noho.SFBay.Sun.COM [10.6.92.101]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n6E16tO4019137 for ; Mon, 13 Jul 2009 18:06:55 -0700 (PDT) Received: from noho.sfbay.sun.com (localhost [127.0.0.1]) by noho.sfbay.sun.com (8.13.7+Sun/8.13.7) with ESMTP id n6E16tnk021461; Mon, 13 Jul 2009 18:06:55 -0700 (PDT) Received: (from dmk@localhost) by noho.sfbay.sun.com (8.13.7+Sun/8.13.7/Submit) id n6E16t0U021460; Mon, 13 Jul 2009 18:06:55 -0700 (PDT) Date: Mon, 13 Jul 2009 18:06:55 -0700 (PDT) From: David Kahn Message-Id: <200907140106.n6E16t0U021460@noho.sfbay.sun.com> To: fwarc@sac.sfbay.sun.com Subject: sun4v io-api update (add CRS handling) [FWARC/2009/393 FastTrack] Cc: Meeta.Saggi@sun.com Status: RO Content-Length: 303 I'm sponsoring this fast track for Meeta. The fast track will timeout on 20 July 2009. This case adds PCIe CRS handling to pci_config_get and pci_config_put. The changes are backwards compatible with the current API definition. Materials, including diffs.txt are in the materials directory. -David From sacadmin Tue Jul 14 10:17:12 2009 Received: from uask4it.sfbay.sun.com (uask4it.SFBay.Sun.COM [10.7.80.228]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n6EHHCkG029949 for ; Tue, 14 Jul 2009 10:17:12 -0700 (PDT) Received: from [192.168.19.57] (vpn-129-150-1-17.SFBay.Sun.COM [129.150.1.17]) by uask4it.sfbay.sun.com (8.13.7+Sun/8.13.7) with ESMTP id n6EHHBfB016309; Tue, 14 Jul 2009 10:17:11 -0700 (PDT) Cc: fwarc@sac.sfbay.sun.com, Meeta.Saggi@Sun.COM Message-Id: <549B6C80-80D0-45F0-A7F6-D00656E71C1E@sun.com> From: Richard Barnette To: David Kahn In-Reply-To: <200907140106.n6E16t0U021460@noho.sfbay.sun.com> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v935.3) Subject: Re: sun4v io-api update (add CRS handling) [FWARC/2009/393 FastTrack] Date: Tue, 14 Jul 2009 10:16:36 -0700 References: <200907140106.n6E16t0U021460@noho.sfbay.sun.com> X-Mailer: Apple Mail (2.935.3) Status: RO Content-Length: 1750 On Jul 13, 2009, at 6:06 PM, David Kahn wrote: > I'm sponsoring this fast track for Meeta. The fast track will timeout > on 20 July 2009. > > This case adds PCIe CRS handling to pci_config_get and pci_config_put. > A few questions and comments: * The PCIe spec rules for CRS are sufficiently straightforward that the hypervisor could silently retry operations that fail with CRS. However, I assume that the intent is that the guest decides whether to retry; the spec should make that clear. * There's actually many more ways for a config space PIO to fail than the available return conditions. This spec is a good opportunity to assign numeric codes to the most obvious (more below). * The spec seems to be treating the error conditions as flags to be or'ed together. The PCIe defined error conditions are all mutually exclusive. The error codes should probably be specified as an enumeration of possible results, rather than a flag set. Here's my minimal list of possible config access status return values: * Success * UR - Unsupported Request * CRS - Configuration Request Retry Status * CA - Completer Abort * Platform specific hardware error > The changes are backwards compatible with the current API definition. > > Materials, including diffs.txt are in the materials directory. > > -David -- Richard Barnette | Gather ye rosebuds while ye may, Sun Microsystems | Old Time is still a-flying: Enterprise Systems Software | And this same flower that smiles to-day SCA11 2384 / USCA11-205 | To-morrow will be dying. (408) 276-7541 / x17541 | -- Robert Herrick . | "To the Virgins, to Make Much of Time" From sacadmin Tue Jul 14 14:28:01 2009 Received: from dtmail.sfbay.sun.com (pkg.SFBay.Sun.COM [129.146.90.56]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n6ELS11T013227 for ; Tue, 14 Jul 2009 14:28:01 -0700 (PDT) Received: from [192.168.0.39] (noho.SFBay.Sun.COM [10.6.92.101]) by dtmail.sfbay.sun.com (8.14.3+Sun/8.14.3) with ESMTP id n6ELS0qG011522; Tue, 14 Jul 2009 14:28:00 -0700 (PDT) Message-ID: <4A5CF86A.2060001@sun.com> Date: Tue, 14 Jul 2009 14:28:10 -0700 From: David Kahn User-Agent: Thunderbird 2.0.0.22 (Windows/20090605) MIME-Version: 1.0 To: Richard Barnette CC: David Kahn , fwarc@sac.sfbay.sun.com, Meeta.Saggi@sun.com Subject: Re: sun4v io-api update (add CRS handling) [FWARC/2009/393 FastTrack] References: <200907140106.n6E16t0U021460@noho.sfbay.sun.com> <549B6C80-80D0-45F0-A7F6-D00656E71C1E@sun.com> In-Reply-To: <549B6C80-80D0-45F0-A7F6-D00656E71C1E@sun.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Status: RO Content-Length: 1424 Richard Barnette wrote: > On Jul 13, 2009, at 6:06 PM, David Kahn wrote: > >> I'm sponsoring this fast track for Meeta. The fast track will timeout >> on 20 July 2009. >> >> This case adds PCIe CRS handling to pci_config_get and pci_config_put. >> > A few questions and comments: > * The PCIe spec rules for CRS are sufficiently straightforward > that the hypervisor could silently retry operations that fail > with CRS. We can't/don't wait/spin in the hv. > However, I assume that the intent is that the guest > decides whether to retry; the spec should make that clear. If it returns a specific value for CRS, how much more clear can it be? Existing code that checks for zero/non-zero will treat it as an error. New code (eg, guest hot-plug or FLR code) can check for CRS and do the right thing. > * There's actually many more ways for a config space PIO to fail > than the available return conditions. This spec is a good > opportunity to assign numeric codes to the most obvious (more > below). This project just addresses CRS. CRS is only possible in very limited cases, but one case came up recently. (it's only possible after a reset or FLR.) > * The spec seems to be treating the error conditions as flags to > be or'ed together. It says they are values. If an error occurs during the read, ret1 (error_flag) shall be set to one of the following values: -David From sacadmin Wed Jul 29 07:34:06 2009 Received: from noho.sfbay.sun.com (noho.SFBay.Sun.COM [10.6.92.101]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n6TEY6nU022675 for ; Wed, 29 Jul 2009 07:34:06 -0700 (PDT) Received: from noho.sfbay.sun.com (localhost [127.0.0.1]) by noho.sfbay.sun.com (8.13.7+Sun/8.13.7) with ESMTP id n6TEY6l2006157; Wed, 29 Jul 2009 07:34:06 -0700 (PDT) Received: (from dmk@localhost) by noho.sfbay.sun.com (8.13.7+Sun/8.13.7/Submit) id n6TEY6K3006156; Wed, 29 Jul 2009 07:34:06 -0700 (PDT) Date: Wed, 29 Jul 2009 07:34:06 -0700 (PDT) From: David Kahn Message-Id: <200907291434.n6TEY6K3006156@noho.sfbay.sun.com> To: fwarc@sac.sfbay.sun.com Subject: Re: sun4v io-api update (add CRS handling) [FWARC/2009/393 FastTrack] Cc: Meeta.Saggi@sun.com Status: RO Content-Length: 64 This case is approved for integration into any release. -David