From sommerfeld@Sun.COM Wed Apr 18 14:03:24 2007 Received: from newsunmail1brm.central.sun.com (newsunmail1brm.Central.Sun.COM [129.147.62.245]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id l3IL3NV4024304 for ; Wed, 18 Apr 2007 14:03:23 -0700 (PDT) Received: from nwk-avmta-1.SFBay.Sun.COM (nwk-avmta-1.SFBay.Sun.COM [129.146.11.74]) by newsunmail1brm.central.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id l3IL2aIp020516; Wed, 18 Apr 2007 15:02:38 -0600 (MDT) Received: from pmxchannel-daemon.nwk-avmta-1.sfbay.Sun.COM by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0JGP00B19P4DI800@nwk-avmta-1.sfbay.Sun.COM>; Wed, 18 Apr 2007 14:02:37 -0700 (PDT) Received: from eastmail2bur.East.Sun.COM ([129.148.13.40]) by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0JGP005BQP4ASL30@nwk-avmta-1.sfbay.Sun.COM>; Wed, 18 Apr 2007 14:02:35 -0700 (PDT) Received: from thunk.east.sun.com (thunk.East.Sun.COM [129.148.174.66]) by eastmail2bur.East.Sun.COM (8.13.6+Sun/8.13.6/ENSMAIL,v2.2) with ESMTP id l3IL2XrT002841; Wed, 18 Apr 2007 17:02:33 -0400 (EDT) Received: from [IPv6:::1] (localhost [IPv6:::1]) by thunk.east.sun.com (8.13.8+Sun/8.13.8) with ESMTP id l3IL2U7e009909; Wed, 18 Apr 2007 17:02:30 -0400 (EDT) Date: Wed, 18 Apr 2007 17:02:29 -0400 From: Bill Sommerfeld Subject: 2007/220 Update Nemo Statistics To: PSARC-EXT Cc: "Garrett D'Amore" , Nicolas Droux Message-id: <1176930149.8060.36.camel@thunk> MIME-version: 1.0 X-Mailer: Evolution 2.8.1.1 Content-type: text/plain Content-transfer-encoding: 7BIT X-PMX-Version: 5.2.0.264296 Status: RO Content-Length: 3193 I'm filing the following case for Garrett D'Amore. The case proposes to extend Nemo / GLDv3 to implement several Public kstats commonly implemented by GLDv2 and standalone DLPI drivers but not yet implemented by GLDv3, in order to more easily permit existing GLDv2 drivers to be compatibly converted to GLDv3. Release Binding is Patch; stability levels match existing practice, both within GLDv3 and within existing drivers as appropriate. I believe it's eligible for self-review and automatic approval and have marked it "closed approved automatic". - Bill Problem ------- Solaris Nevada has introduced a new API for NIC driver writers, known as GLDv3 (code named "Nemo"). This framework offers a lot of advantages to drivers, even over GLDv2. See PSARC cases 2004/471, 2005/365, 2006/248, and 2006/249 for more detail. There are compelling reasons to convert various DLPI and GLDv2 drivers to Nemo. However, one hitch is that the Nemo mac_ether plugin does not provide support for a few statistics that pretty much all pre-Nemo ethernet drivers supported. Those statistics are: cap_rem_fault - Device supports MII remote fault adv_rem_fault - Advertised MII remote fault lp_rem_fault - Link partner MII remote fault runt_errors - packets received that are too small (<64 bytes) Additionally, some "generic" statistics are provided by GLDv2, and commonly supported by drivers: uflo - FIFO underflow error on transmit oflo - FIFO overflow error on receive Note that the first three statistics were covered by PSARC 2003/581, and given a Stable interface binding. None of the other statistics have ever been given any ARC-assigned interface binding, that we are aware of. Proposed Solution ----------------- We propose to add the above statistics to the GLDv3 "mac_ether" plugin. This would be done by adding values ETHER_STAT_CAP_REMFAULT, ETHER_STAT_ADV_REMFAULT, ETHER_STAT_LP_REMFAULT, ETHER_STAT_TOOSHORT to the ether_stat enum, with the corresponding kstat names from above. Additionally, we would add the values MAC_STAT_OVERFLOW, MAC_STAT_UNDERFLOW, to the mac_driver_stat enum, as we believe these statistics are not specific to ethernet. Note that while we believe that the "uflo" and "oflo" statistics should have been given better names when they were created by GLDv2, we do not think that the risk created by changing them at this time is worth any benefit gained by giving a more descriptive name. Interface Binding ----------------- We are requesting the following interface bindings: ETHER_STAT_CAP_REMFAULT Consolidation Private ETHER_STAT_ADV_REMFAULT Consolidation Private ETHER_STAT_LP_REMFAULT Consolidation Private ETHER_STAT_TOOSHORT Consolidation Private MAC_STAT_OVERFLOW Consolidation Private MAC_STAT_UNDERFLOW Consolidation Private "uflo" kstat Unstable "oflo" kstat Unstable "runt_errors" kstat Unstable The other three rem_fault kstats already have Stable interface binding. From sommerfeld@sun.com Wed Apr 18 14:39:54 2007 Received: from sunmail5.uk.sun.com (sunmail5.UK.Sun.COM [129.156.85.165]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id l3ILdsar026101 for ; Wed, 18 Apr 2007 14:39:54 -0700 (PDT) Received: from nwk-avmta-1.SFBay.Sun.COM (nwk-avmta-1.SFBay.Sun.COM [129.146.11.74]) by sunmail5.uk.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id l3ILd55G025885; Wed, 18 Apr 2007 22:39:07 +0100 (BST) Received: from pmxchannel-daemon.nwk-avmta-1.sfbay.Sun.COM by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0JGP00F07QT53J00@nwk-avmta-1.sfbay.Sun.COM>; Wed, 18 Apr 2007 14:39:05 -0700 (PDT) Received: from eastmail2bur.East.Sun.COM ([129.148.13.40]) by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0JGP005SQQT5SP60@nwk-avmta-1.sfbay.Sun.COM>; Wed, 18 Apr 2007 14:39:05 -0700 (PDT) Received: from thunk.east.sun.com (thunk.East.Sun.COM [129.148.174.66]) by eastmail2bur.East.Sun.COM (8.13.6+Sun/8.13.6/ENSMAIL,v2.2) with ESMTP id l3ILd4DX008428; Wed, 18 Apr 2007 17:39:04 -0400 (EDT) Received: from [IPv6:::1] (localhost [IPv6:::1]) by thunk.east.sun.com (8.13.8+Sun/8.13.8) with ESMTP id l3ILd4h7010233; Wed, 18 Apr 2007 17:39:04 -0400 (EDT) Date: Wed, 18 Apr 2007 17:39:03 -0400 From: Bill Sommerfeld Subject: Re: 2007/220 Update Nemo Statistics In-reply-to: <1176930149.8060.36.camel@thunk> To: PSARC-EXT Cc: Nicolas Droux , "Garrett D'Amore" Message-id: <1176932343.8060.40.camel@thunk> MIME-version: 1.0 X-Mailer: Evolution 2.8.1.1 Content-type: text/plain Content-transfer-encoding: 7BIT X-PMX-Version: 5.2.0.264296 References: <1176930149.8060.36.camel@thunk> Status: RO Content-Length: 230 On Wed, 2007-04-18 at 17:02 -0400, Bill Sommerfeld wrote: > I'm filing the following case for Garrett D'Amore. .. and put the wrong address in the message due to viral addressbook behavior. Corrected Cc: above. - Bill From Garrett.Damore@sun.com Wed Apr 18 15:35:39 2007 Received: from sunmail4.Singapore.Sun.COM (sunmail4.Singapore.Sun.COM [129.158.71.19]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id l3IMZcXi028175 for ; Wed, 18 Apr 2007 15:35:38 -0700 (PDT) Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6]) by sunmail4.Singapore.Sun.COM (8.13.4+Sun/8.13.3/ENSMAIL,v2.2) with ESMTP id l3IMYYkd011047; Thu, 19 Apr 2007 06:34:52 +0800 (SGT) Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0JGP00401TE1BC00@nwk-avmta-2.sfbay.sun.com>; Wed, 18 Apr 2007 15:34:49 -0700 (PDT) Received: from nwk-ea-fw-1.sun.com ([10.4.134.6]) by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0JGP00M06TE1ZTC0@nwk-avmta-2.sfbay.sun.com>; Wed, 18 Apr 2007 15:34:49 -0700 (PDT) Received: from d1-sfbay-09.sun.com ([192.18.39.119]) by nwk-ea-fw-1.sun.com (8.13.6+Sun/8.12.9) with ESMTP id l3IMYnhu012742; Wed, 18 Apr 2007 15:34:49 -0700 (PDT) Received: from conversion-daemon.d1-sfbay-09.sun.com by d1-sfbay-09.sun.com (Sun Java System Messaging Server 6.2-6.01 (built Apr 3 2006)) id <0JGP00I01SU63M00@d1-sfbay-09.sun.com> (original mail from Garrett.Damore@Sun.COM); Wed, 18 Apr 2007 15:34:49 -0700 (PDT) Received: from [129.150.12.220] by d1-sfbay-09.sun.com (Sun Java System Messaging Server 6.2-6.01 (built Apr 3 2006)) with ESMTPSA id <0JGP001RZTE0AVJ6@d1-sfbay-09.sun.com>; Wed, 18 Apr 2007 15:34:48 -0700 (PDT) Date: Wed, 18 Apr 2007 15:35:08 -0700 From: "Garrett D'Amore" Subject: Re: 2007/220 Update Nemo Statistics In-reply-to: <1176932343.8060.40.camel@thunk> Sender: Garrett.Damore@sun.com To: Bill Sommerfeld Cc: PSARC-EXT , Nicolas Droux Message-id: <46269D1C.7020203@sun.com> MIME-version: 1.0 Content-type: text/plain; format=flowed; charset=ISO-8859-1 Content-transfer-encoding: 7BIT X-PMX-Version: 5.2.0.264296 References: <1176930149.8060.36.camel@thunk> <1176932343.8060.40.camel@thunk> User-Agent: Thunderbird 2.0b2 (X11/20070227) Status: RO Content-Length: 615 Bill Sommerfeld wrote: > On Wed, 2007-04-18 at 17:02 -0400, Bill Sommerfeld wrote: > >> I'm filing the following case for Garrett D'Amore. >> > > .. and put the wrong address in the message due to viral addressbook > behavior. Corrected Cc: above. > > - Bill > > > A quick update, after reading the code, there are some very trivial changes to the names, just for consistency: MAC_STAT_TOOSHORT should be MAC_STAT_TOOSHORT_ERRORS MAC_STAT_UNDERFLOW should be MAC_STAT_UNDERFLOWS MAC_STAT_OVERFLOW should be MAC_STAT_OVERFLOWS Sorry for not getting it right the first time. :-) -- Garrett