From gd78059@sac.sfbay.sun.com Wed Aug 22 10:00:25 2007 Received: from sunmail5.uk.sun.com (sunmail5.UK.Sun.COM [129.156.85.165]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id l7MH0OIe013142 for ; Wed, 22 Aug 2007 10:00:24 -0700 (PDT) Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6]) by sunmail5.uk.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id l7MGvfvQ023612; Wed, 22 Aug 2007 17:57:52 +0100 (BST) Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0JN600M05PSF3100@nwk-avmta-2.sfbay.sun.com>; Wed, 22 Aug 2007 09:57:51 -0700 (PDT) Received: from sfbaymail2sca.sfbay.sun.com ([129.145.155.42]) by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0JN600KBVPSEXX70@nwk-avmta-2.sfbay.sun.com>; Wed, 22 Aug 2007 09:57:50 -0700 (PDT) Received: from sac.sfbay.sun.com (new-sac.SFBay.Sun.COM [129.146.175.65]) by sfbaymail2sca.sfbay.sun.com (8.13.6+Sun/8.12.10/ENSMAIL,v2.2) with ESMTP id l7MGvo9e020933; Wed, 22 Aug 2007 09:57:50 -0700 (PDT) Received: from sac.sfbay.sun.com (localhost [127.0.0.1]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id l7MH0KYW013135; Wed, 22 Aug 2007 10:00:20 -0700 (PDT) Received: (from gd78059@localhost) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8/Submit) id l7MH0KVa013130; Wed, 22 Aug 2007 10:00:20 -0700 (PDT) Date: Wed, 22 Aug 2007 10:00:20 -0700 (PDT) From: "Garrett D'Amore - sun microsystems" Subject: VLAN macros for sys/ethernet.h [PSARC/2007/479 FastTrack timeout 08/29/2007] To: PSARC-ext@sun.com Cc: Garrett.Damore@sun.com Message-id: <200708221700.l7MH0KVa013130@sac.sfbay.sun.com> Content-transfer-encoding: 7BIT X-PMX-Version: 5.2.0.264296 Status: RO Content-Length: 1303 Template Version: @(#)sac_nextcase 1.64 07/13/07 SMI This information is Copyright 2007 Sun Microsystems 1. Introduction 1.1. Project/Component Working Name: VLAN macros for sys/ethernet.h 1.2. Name of Document Author/Supplier: Author: Garrett D'Amore 1.3 Date of This Document: 22 August, 2007 4. Technical Description Problem ------- Various network drivers need to know the size of ethernet frames as adjusted to account for VLAN (802.1q) tags. Right now they all define their own macros or use bare constants (4 for the tag size, 1518 for ETHERMAX + 4). Solution -------- We propose to add two macros to sys/ethernet.h: #define ETHERVTAGL 4 /* size of a VLAN tag */ #define ETHERVLANMAX 1518 /* max tagged ethernet frame size */ Some existing macros that we tried to follow the naming style of: ETHERADDRL ETHERFCSL ETHERMAX We're not sure that the contents of sys/ethernet.h have ever been covered by an ARC case, but we believe that these two macros could be added to the DDI and given either Committed or Uncommitted binding so that 3rd party drivers could begin using them. 6. Resources and Schedule 6.4. Steering Committee requested information 6.4.1. Consolidation C-team Name: ON 6.5. ARC review type: FastTrack 6.6. ARC Exposure: open From carlsonj@phorcys.east.sun.com Wed Aug 22 10:05:34 2007 Received: from sunmail4.Singapore.Sun.COM (sunmail4.Singapore.Sun.COM [129.158.71.19]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id l7MH5Xkt014306 for ; Wed, 22 Aug 2007 10:05:33 -0700 (PDT) Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6]) by sunmail4.Singapore.Sun.COM (8.13.4+Sun/8.13.3/ENSMAIL,v2.2) with ESMTP id l7MH2VUF006021; Thu, 23 Aug 2007 01:02:59 +0800 (SGT) Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0JN600M01Q0VC900@nwk-avmta-2.sfbay.sun.com>; Wed, 22 Aug 2007 10:02:55 -0700 (PDT) Received: from phorcys.east.sun.com ([129.148.174.143]) by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0JN600KOWQ0UXZ80@nwk-avmta-2.sfbay.sun.com>; Wed, 22 Aug 2007 10:02:54 -0700 (PDT) Received: from phorcys.east.sun.com (localhost [127.0.0.1]) by phorcys.east.sun.com (8.14.1+Sun/8.14.1) with ESMTP id l7MH2i0s001784; Wed, 22 Aug 2007 13:02:44 -0400 (EDT) Received: (from carlsonj@localhost) by phorcys.east.sun.com (8.14.1+Sun/8.14.1/Submit) id l7MH2isV001781; Wed, 22 Aug 2007 13:02:44 -0400 (EDT) Date: Wed, 22 Aug 2007 13:02:44 -0400 From: James Carlson Subject: Re: VLAN macros for sys/ethernet.h [PSARC/2007/479 FastTrack timeout 08/29/2007] In-reply-to: <200708221700.l7MH0KVa013130@sac.sfbay.sun.com> To: "Garrett D'Amore - sun microsystems" Cc: PSARC-ext@Sun.COM, Garrett.Damore@Sun.COM Message-id: <18124.27700.67281.146582@gargle.gargle.HOWL> MIME-version: 1.0 X-Mailer: VM 7.01 under Emacs 21.3.1 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7BIT X-PMX-Version: 5.2.0.264296 References: <200708221700.l7MH0KVa013130@sac.sfbay.sun.com> Status: RO Content-Length: 357 Garrett D'Amore - sun microsystems writes: > We propose to add two macros to sys/ethernet.h: The swilly netinet/if_ether.h as well? -- James Carlson, Solaris Networking Sun Microsystems / 1 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677 From Garrett.Damore@sun.com Wed Aug 22 10:08:34 2007 Received: from sunmail4.Singapore.Sun.COM (sunmail4.Singapore.Sun.COM [129.158.71.19]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id l7MH8XpZ014882 for ; Wed, 22 Aug 2007 10:08:34 -0700 (PDT) Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6]) by sunmail4.Singapore.Sun.COM (8.13.4+Sun/8.13.3/ENSMAIL,v2.2) with ESMTP id l7MH5lHS007887 for <@sunmail2sca.sfbay.sun.com:PSARC-ext@sun.com>; Thu, 23 Aug 2007 01:06:01 +0800 (SGT) Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0JN600M0JQ60HM00@nwk-avmta-2.sfbay.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 22 Aug 2007 10:06:00 -0700 (PDT) Received: from sca-es-mail-2.sun.com ([192.18.43.133]) by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0JN600KCMQ60XX90@nwk-avmta-2.sfbay.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 22 Aug 2007 10:06:00 -0700 (PDT) Received: from fe-sfbay-10.sun.com ([192.18.43.129]) by sca-es-mail-2.sun.com (8.13.7+Sun/8.12.9) with ESMTP id l7MH60Io017173 for ; Wed, 22 Aug 2007 10:06:00 -0700 (PDT) Received: from conversion-daemon.fe-sfbay-10.sun.com by fe-sfbay-10.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) id <0JN600701PXLS500@fe-sfbay-10.sun.com> (original mail from Garrett.Damore@Sun.COM) for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 22 Aug 2007 10:06:00 -0700 (PDT) Received: from [192.168.251.21] ([76.174.83.55]) by fe-sfbay-10.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) with ESMTPSA id <0JN6007ZLQ60KB20@fe-sfbay-10.sun.com>; Wed, 22 Aug 2007 10:06:00 -0700 (PDT) Date: Wed, 22 Aug 2007 10:01:47 -0700 From: "Garrett D'Amore" Subject: Re: VLAN macros for sys/ethernet.h [PSARC/2007/479 FastTrack timeout 08/29/2007] In-reply-to: <18124.27700.67281.146582@gargle.gargle.HOWL> Sender: Garrett.Damore@sun.com To: James Carlson Cc: "Garrett D'Amore - sun microsystems" , PSARC-ext@sun.com Message-id: <1187802107.909.611.camel@zippy> Organization: Sun Microsystems, Inc. MIME-version: 1.0 X-Mailer: Evolution 2.10.2 Content-type: text/plain Content-transfer-encoding: 7BIT X-PMX-Version: 5.2.0.264296 References: <200708221700.l7MH0KVa013130@sac.sfbay.sun.com> <18124.27700.67281.146582@gargle.gargle.HOWL> Status: RO Content-Length: 309 On Wed, 2007-08-22 at 13:02 -0400, James Carlson wrote: > Garrett D'Amore - sun microsystems writes: > > We propose to add two macros to sys/ethernet.h: > > The swilly netinet/if_ether.h as well? Nope, just sys/ethernet.h. Its there for device drivers, which can't safely include if_ether.h. -- Garrett From carlsonj@phorcys.east.sun.com Wed Aug 22 10:39:06 2007 Received: from sunmail4.Singapore.Sun.COM (sunmail4.Singapore.Sun.COM [129.158.71.19]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id l7MHd5nu016341 for ; Wed, 22 Aug 2007 10:39:06 -0700 (PDT) Received: from nwk-avmta-1.SFBay.Sun.COM (nwk-avmta-1.SFBay.Sun.COM [129.146.11.74]) by sunmail4.Singapore.Sun.COM (8.13.4+Sun/8.13.3/ENSMAIL,v2.2) with ESMTP id l7MHaQIj021599; Thu, 23 Aug 2007 01:36:31 +0800 (SGT) Received: from pmxchannel-daemon.nwk-avmta-1.sfbay.Sun.COM by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0JN600G03RKVOY00@nwk-avmta-1.sfbay.Sun.COM>; Wed, 22 Aug 2007 10:36:31 -0700 (PDT) Received: from phorcys.east.sun.com ([129.148.174.143]) by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0JN60086XRKUZMC0@nwk-avmta-1.sfbay.Sun.COM>; Wed, 22 Aug 2007 10:36:31 -0700 (PDT) Received: from phorcys.east.sun.com (localhost [127.0.0.1]) by phorcys.east.sun.com (8.14.1+Sun/8.14.1) with ESMTP id l7MHaNfD001985; Wed, 22 Aug 2007 13:36:23 -0400 (EDT) Received: (from carlsonj@localhost) by phorcys.east.sun.com (8.14.1+Sun/8.14.1/Submit) id l7MHaNCV001982; Wed, 22 Aug 2007 13:36:23 -0400 (EDT) Date: Wed, 22 Aug 2007 13:36:23 -0400 From: James Carlson Subject: Re: VLAN macros for sys/ethernet.h [PSARC/2007/479 FastTrack timeout 08/29/2007] In-reply-to: <1187802107.909.611.camel@zippy> To: "Garrett D'Amore" Cc: "Garrett D'Amore - sun microsystems" , PSARC-ext@sun.com Message-id: <18124.29719.489204.102667@gargle.gargle.HOWL> MIME-version: 1.0 X-Mailer: VM 7.01 under Emacs 21.3.1 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7BIT X-PMX-Version: 5.2.0.264296 References: <200708221700.l7MH0KVa013130@sac.sfbay.sun.com> <18124.27700.67281.146582@gargle.gargle.HOWL> <1187802107.909.611.camel@zippy> Status: RO Content-Length: 652 Garrett D'Amore writes: > On Wed, 2007-08-22 at 13:02 -0400, James Carlson wrote: > > Garrett D'Amore - sun microsystems writes: > > > We propose to add two macros to sys/ethernet.h: > > > > The swilly netinet/if_ether.h as well? > > Nope, just sys/ethernet.h. Its there for device drivers, which can't > safely include if_ether.h. Ick. OK. Driving these two further apart means it'll be harder to get rid of one someday. -- James Carlson, Solaris Networking Sun Microsystems / 1 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677 From Garrett.Damore@sun.com Wed Aug 22 11:06:39 2007 Received: from sunmail3mpk.sfbay.sun.com (sunmail3mpk [129.146.11.52]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id l7MI6dW0017146 for ; Wed, 22 Aug 2007 11:06:39 -0700 (PDT) Received: from brm-avmta-1.central.sun.com (brm-avmta-1.Central.Sun.COM [129.147.4.11]) by sunmail3mpk.sfbay.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id l7MI41FS016003 for <@sunmail2sca.sfbay.sun.com:PSARC-ext@sun.com>; Wed, 22 Aug 2007 11:04:05 -0700 (PDT) Received: from pmxchannel-daemon.brm-avmta-1.central.sun.com by brm-avmta-1.central.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0JN600C07SUT7800@brm-avmta-1.central.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@Sun.COM); Wed, 22 Aug 2007 12:04:05 -0600 (MDT) Received: from sca-es-mail-2.sun.com ([192.18.43.133]) by brm-avmta-1.central.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0JN6009MXSUSDU20@brm-avmta-1.central.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@Sun.COM); Wed, 22 Aug 2007 12:04:04 -0600 (MDT) Received: from fe-sfbay-09.sun.com ([192.18.43.129]) by sca-es-mail-2.sun.com (8.13.7+Sun/8.12.9) with ESMTP id l7MI44r1024894 for ; Wed, 22 Aug 2007 11:04:04 -0700 (PDT) Received: from conversion-daemon.fe-sfbay-09.sun.com by fe-sfbay-09.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) id <0JN600101STRRC00@fe-sfbay-09.sun.com> (original mail from Garrett.Damore@Sun.COM) for PSARC-ext@Sun.COM (ORCPT PSARC-ext@Sun.COM); Wed, 22 Aug 2007 11:04:04 -0700 (PDT) Received: from [192.168.251.21] ([76.174.83.55]) by fe-sfbay-09.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) with ESMTPSA id <0JN600KEPSUOGBA0@fe-sfbay-09.sun.com>; Wed, 22 Aug 2007 11:04:00 -0700 (PDT) Date: Wed, 22 Aug 2007 10:59:47 -0700 From: "Garrett D'Amore" Subject: Re: VLAN macros for sys/ethernet.h [PSARC/2007/479 FastTrack timeout 08/29/2007] In-reply-to: <18124.29719.489204.102667@gargle.gargle.HOWL> Sender: Garrett.Damore@sun.com To: James Carlson Cc: "Garrett D'Amore - sun microsystems" , PSARC-ext@sun.com Message-id: <1187805587.909.616.camel@zippy> Organization: Sun Microsystems, Inc. MIME-version: 1.0 X-Mailer: Evolution 2.10.2 Content-type: text/plain Content-transfer-encoding: 7BIT X-PMX-Version: 5.2.0.264296 References: <200708221700.l7MH0KVa013130@sac.sfbay.sun.com> <18124.27700.67281.146582@gargle.gargle.HOWL> <1187802107.909.611.camel@zippy> <18124.29719.489204.102667@gargle.gargle.HOWL> Status: RO Content-Length: 620 On Wed, 2007-08-22 at 13:36 -0400, James Carlson wrote: > Garrett D'Amore writes: > > On Wed, 2007-08-22 at 13:02 -0400, James Carlson wrote: > > > Garrett D'Amore - sun microsystems writes: > > > > We propose to add two macros to sys/ethernet.h: > > > > > > The swilly netinet/if_ether.h as well? > > > > Nope, just sys/ethernet.h. Its there for device drivers, which can't > > safely include if_ether.h. > > Ick. OK. > > Driving these two further apart means it'll be harder to get rid of > one someday. > Who uses net/if_ether.h? sys/ethernet.h is the only one that is safe for drivers to use. -- Garrett From carlsonj@phorcys.east.sun.com Wed Aug 22 11:21:49 2007 Received: from sunmail3mpk.sfbay.sun.com (sunmail3mpk [129.146.11.52]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id l7MILnN5017818 for ; Wed, 22 Aug 2007 11:21:49 -0700 (PDT) Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6]) by sunmail3mpk.sfbay.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id l7MIIa2S020386; Wed, 22 Aug 2007 11:18:37 -0700 (PDT) Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0JN60020BTJ0VX00@nwk-avmta-2.sfbay.sun.com>; Wed, 22 Aug 2007 11:18:36 -0700 (PDT) Received: from phorcys.east.sun.com ([129.148.174.143]) by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0JN6000TCTIYDB20@nwk-avmta-2.sfbay.sun.com>; Wed, 22 Aug 2007 11:18:35 -0700 (PDT) Received: from phorcys.east.sun.com (localhost [127.0.0.1]) by phorcys.east.sun.com (8.14.1+Sun/8.14.1) with ESMTP id l7MIIRXK002245; Wed, 22 Aug 2007 14:18:27 -0400 (EDT) Received: (from carlsonj@localhost) by phorcys.east.sun.com (8.14.1+Sun/8.14.1/Submit) id l7MIIRb5002242; Wed, 22 Aug 2007 14:18:27 -0400 (EDT) Date: Wed, 22 Aug 2007 14:18:27 -0400 From: James Carlson Subject: Re: VLAN macros for sys/ethernet.h [PSARC/2007/479 FastTrack timeout 08/29/2007] In-reply-to: <1187805587.909.616.camel@zippy> To: "Garrett D'Amore" Cc: PSARC-ext@sun.com, "Garrett D'Amore - sun microsystems" Message-id: <18124.32243.876493.650139@gargle.gargle.HOWL> MIME-version: 1.0 X-Mailer: VM 7.01 under Emacs 21.3.1 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7BIT X-PMX-Version: 5.2.0.264296 References: <200708221700.l7MH0KVa013130@sac.sfbay.sun.com> <18124.27700.67281.146582@gargle.gargle.HOWL> <1187802107.909.611.camel@zippy> <18124.29719.489204.102667@gargle.gargle.HOWL> <1187805587.909.616.camel@zippy> Status: RO Content-Length: 823 Garrett D'Amore writes: > On Wed, 2007-08-22 at 13:36 -0400, James Carlson wrote: > > Driving these two further apart means it'll be harder to get rid of > > one someday. > > > > Who uses net/if_ether.h? > > sys/ethernet.h is the only one that is safe for drivers to use. They're used interchangeably in much of the code, and with netinet/if_ether.h appearing in some surprising kernel files (such as os/space.c). There are about 92 references to if_ether.h and 100 to ethernet.h. It looks like sys/ethernet.h is slightly more popular in the kernel, but there are adherents to both religions. -- James Carlson, Solaris Networking Sun Microsystems / 1 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677 From Darren.Reed@sun.com Wed Aug 22 14:19:40 2007 Received: from sunmail4.Singapore.Sun.COM (sunmail4.Singapore.Sun.COM [129.158.71.19]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id l7MLJd36024164 for ; Wed, 22 Aug 2007 14:19:40 -0700 (PDT) Received: from nwk-avmta-1.SFBay.Sun.COM (nwk-avmta-1.SFBay.Sun.COM [129.146.11.74]) by sunmail4.Singapore.Sun.COM (8.13.4+Sun/8.13.3/ENSMAIL,v2.2) with ESMTP id l7MLGv24027874 for <@sunmail2sca.sfbay.sun.com:PSARC-ext@sun.com>; Thu, 23 Aug 2007 05:17:07 +0800 (SGT) Received: from pmxchannel-daemon.nwk-avmta-1.sfbay.Sun.COM by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0JN700B031SH1800@nwk-avmta-1.sfbay.Sun.COM> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 22 Aug 2007 14:17:05 -0700 (PDT) Received: from sineb-mail-2.sun.com ([192.18.19.7]) by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0JN7001JY1SGZQ70@nwk-avmta-1.sfbay.Sun.COM> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 22 Aug 2007 14:17:05 -0700 (PDT) Received: from fe-apac-02.sun.com (fe-apac-02.sun.com [192.18.19.173] (may be forged)) by sineb-mail-2.sun.com (8.13.6+Sun/8.12.9) with ESMTP id l7MLH4iS014695 for ; Wed, 22 Aug 2007 21:17:04 +0000 (GMT) Received: from conversion-daemon.mail-apac.sun.com by mail-apac.sun.com (Sun Java System Messaging Server 6.2-6.01 (built Apr 3 2006)) id <0JN7000011PJWO00@mail-apac.sun.com> (original mail from Darren.Reed@Sun.COM) for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Thu, 23 Aug 2007 05:17:03 +0800 (SGT) Received: from [129.146.106.55] by mail-apac.sun.com (Sun Java System Messaging Server 6.2-6.01 (built Apr 3 2006)) with ESMTPSA id <0JN700E6Y1SE3M00@mail-apac.sun.com>; Thu, 23 Aug 2007 05:17:03 +0800 (SGT) Date: Wed, 22 Aug 2007 14:17:01 -0700 From: Darren.Reed@sun.com Subject: Re: VLAN macros for sys/ethernet.h [PSARC/2007/479 FastTrack timeout 08/29/2007] In-reply-to: <200708221700.l7MH0KVa013130@sac.sfbay.sun.com> Sender: Darren.Reed@sun.com To: "Garrett D'Amore - sun microsystems" Cc: PSARC-ext@sun.com, Garrett.Damore@sun.com Message-id: <46CCA7CD.2010009@Sun.COM> MIME-version: 1.0 Content-type: text/plain; format=flowed; charset=us-ascii Content-transfer-encoding: 7BIT X-Accept-Language: en-au, en X-PMX-Version: 5.2.0.264296 References: <200708221700.l7MH0KVa013130@sac.sfbay.sun.com> User-Agent: Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:1.7) Gecko/20060120 Status: RO Content-Length: 807 Garrett D'Amore - sun microsystems wrote: >... >Solution >-------- > >We propose to add two macros to sys/ethernet.h: > > #define ETHERVTAGL 4 /* size of a VLAN tag */ > #define ETHERVLANMAX 1518 /* max tagged ethernet frame size */ > >Some existing macros that we tried to follow the naming style of: > > ETHERADDRL > ETHERFCSL > ETHERMAX > >We're not sure that the contents of sys/ethernet.h have ever been covered by an >ARC case, but we believe that these two macros could be added to the DDI and >given either Committed or Uncommitted binding so that 3rd party drivers could >begin using them. > > Are you actually proposing that the above be committed/uncommitted? Or to ask this another way, is there any reason why these macros should not be published as being at least "uncommitted"? Darren From Garrett.Damore@sun.com Wed Aug 22 14:42:40 2007 Received: from newsunmail1brm.central.sun.com (newsunmail1brm.Central.Sun.COM [129.147.62.245]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id l7MLge64025082 for ; Wed, 22 Aug 2007 14:42:40 -0700 (PDT) Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6]) by newsunmail1brm.central.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id l7MLdhoj028902 for <@sunmail2sca.sfbay.sun.com:PSARC-ext@sun.com>; Wed, 22 Aug 2007 15:39:49 -0600 (MDT) Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0JN700C012UV5H00@nwk-avmta-2.sfbay.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 22 Aug 2007 14:40:07 -0700 (PDT) Received: from sca-es-mail-2.sun.com ([192.18.43.133]) by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0JN7000ZB2UUD2B0@nwk-avmta-2.sfbay.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 22 Aug 2007 14:40:06 -0700 (PDT) Received: from fe-sfbay-09.sun.com ([192.18.43.129]) by sca-es-mail-2.sun.com (8.13.7+Sun/8.12.9) with ESMTP id l7MLe6HR019172 for ; Wed, 22 Aug 2007 14:40:06 -0700 (PDT) Received: from conversion-daemon.fe-sfbay-09.sun.com by fe-sfbay-09.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) id <0JN700L012C3NG00@fe-sfbay-09.sun.com> (original mail from Garrett.Damore@Sun.COM) for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 22 Aug 2007 14:40:06 -0700 (PDT) Received: from [192.168.251.21] ([76.174.83.55]) by fe-sfbay-09.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) with ESMTPSA id <0JN700DS32UT6080@fe-sfbay-09.sun.com>; Wed, 22 Aug 2007 14:40:05 -0700 (PDT) Date: Wed, 22 Aug 2007 14:35:52 -0700 From: "Garrett D'Amore" Subject: Re: VLAN macros for sys/ethernet.h [PSARC/2007/479 FastTrack timeout 08/29/2007] In-reply-to: <46CCA7CD.2010009@Sun.COM> Sender: Garrett.Damore@sun.com To: Darren.Reed@sun.com Cc: "Garrett D'Amore - sun microsystems" , PSARC-ext@sun.com Message-id: <1187818552.909.664.camel@zippy> Organization: Sun Microsystems, Inc. MIME-version: 1.0 X-Mailer: Evolution 2.10.2 Content-type: text/plain Content-transfer-encoding: 7BIT X-PMX-Version: 5.2.0.264296 References: <200708221700.l7MH0KVa013130@sac.sfbay.sun.com> <46CCA7CD.2010009@Sun.COM> Status: RO Content-Length: 1043 On Wed, 2007-08-22 at 14:17 -0700, Darren.Reed@Sun.COM wrote: > Garrett D'Amore - sun microsystems wrote: > > >... > >Solution > >-------- > > > >We propose to add two macros to sys/ethernet.h: > > > > #define ETHERVTAGL 4 /* size of a VLAN tag */ > > #define ETHERVLANMAX 1518 /* max tagged ethernet frame size */ > > > >Some existing macros that we tried to follow the naming style of: > > > > ETHERADDRL > > ETHERFCSL > > ETHERMAX > > > >We're not sure that the contents of sys/ethernet.h have ever been covered by an > >ARC case, but we believe that these two macros could be added to the DDI and > >given either Committed or Uncommitted binding so that 3rd party drivers could > >begin using them. > > > > > > Are you actually proposing that the above be committed/uncommitted? > > Or to ask this another way, is there any reason why these macros > should not be published as being at least "uncommitted"? I am proposing just that. Right now, I'm not sure they are covered by any ARC cases whatsoever. -- Garrett > > Darren > From carlsonj@phorcys.east.sun.com Wed Aug 22 14:46:40 2007 Received: from sunmail2sca.sfbay.sun.com (sunmail2sca [129.145.155.234]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id l7MLkeLg025333 for ; Wed, 22 Aug 2007 14:46:40 -0700 (PDT) Received: from brm-avmta-1.central.sun.com (brm-avmta-1.Central.Sun.COM [129.147.4.11]) by sunmail2sca.sfbay.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id l7MLi6GJ005758; Wed, 22 Aug 2007 14:44:06 -0700 (PDT) Received: from pmxchannel-daemon.brm-avmta-1.central.sun.com by brm-avmta-1.central.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0JN70010131H5600@brm-avmta-1.central.sun.com>; Wed, 22 Aug 2007 15:44:05 -0600 (MDT) Received: from phorcys.east.sun.com ([129.148.174.143]) by brm-avmta-1.central.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0JN7009IS31FDSE0@brm-avmta-1.central.sun.com>; Wed, 22 Aug 2007 15:44:04 -0600 (MDT) Received: from phorcys.east.sun.com (localhost [127.0.0.1]) by phorcys.east.sun.com (8.14.1+Sun/8.14.1) with ESMTP id l7MLhs0c003334; Wed, 22 Aug 2007 17:43:54 -0400 (EDT) Received: (from carlsonj@localhost) by phorcys.east.sun.com (8.14.1+Sun/8.14.1/Submit) id l7MLhs96003331; Wed, 22 Aug 2007 17:43:54 -0400 (EDT) Date: Wed, 22 Aug 2007 17:43:54 -0400 From: James Carlson Subject: Re: VLAN macros for sys/ethernet.h [PSARC/2007/479 FastTrack timeout 08/29/2007] In-reply-to: <1187818552.909.664.camel@zippy> To: "Garrett D'Amore" Cc: Darren.Reed@Sun.COM, PSARC-ext@Sun.COM, "Garrett D'Amore - sun microsystems" Message-id: <18124.44570.493268.356396@gargle.gargle.HOWL> MIME-version: 1.0 X-Mailer: VM 7.01 under Emacs 21.3.1 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7BIT X-PMX-Version: 5.2.0.264296 References: <200708221700.l7MH0KVa013130@sac.sfbay.sun.com> <46CCA7CD.2010009@Sun.COM> <1187818552.909.664.camel@zippy> Status: RO Content-Length: 481 Garrett D'Amore writes: > I am proposing just that. Right now, I'm not sure they are covered by > any ARC cases whatsoever. You might as well make them Committed. It's not as though #defines of architectural constants can "evolve" in any meaningful way. -- James Carlson, Solaris Networking Sun Microsystems / 1 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677 From Garrett.Damore@sun.com Wed Aug 22 15:32:38 2007 Received: from sunmail5.uk.sun.com (sunmail5.UK.Sun.COM [129.156.85.165]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id l7MMWbQP026901 for ; Wed, 22 Aug 2007 15:32:38 -0700 (PDT) Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6]) by sunmail5.uk.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id l7MMU30P014325 for <@sunmail2sca.sfbay.sun.com:PSARC-ext@sun.com>; Wed, 22 Aug 2007 23:30:05 +0100 (BST) Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0JN700E05564OB00@nwk-avmta-2.sfbay.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@Sun.Com); Wed, 22 Aug 2007 15:30:04 -0700 (PDT) Received: from sca-es-mail-1.sun.com ([192.18.43.132]) by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0JN700080563D1E0@nwk-avmta-2.sfbay.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@Sun.Com); Wed, 22 Aug 2007 15:30:03 -0700 (PDT) Received: from fe-sfbay-09.sun.com ([192.18.43.129]) by sca-es-mail-1.sun.com (8.13.7+Sun/8.12.9) with ESMTP id l7MMU3IZ015097 for ; Wed, 22 Aug 2007 15:30:03 -0700 (PDT) Received: from conversion-daemon.fe-sfbay-09.sun.com by fe-sfbay-09.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) id <0JN700J015466T00@fe-sfbay-09.sun.com> (original mail from Garrett.Damore@Sun.COM) for PSARC-ext@Sun.Com (ORCPT PSARC-ext@Sun.Com); Wed, 22 Aug 2007 15:30:03 -0700 (PDT) Received: from [192.168.251.21] ([76.174.83.55]) by fe-sfbay-09.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) with ESMTPSA id <0JN700A5O561B3D0@fe-sfbay-09.sun.com>; Wed, 22 Aug 2007 15:30:01 -0700 (PDT) Date: Wed, 22 Aug 2007 15:25:46 -0700 From: "Garrett D'Amore" Subject: Re: VLAN macros for sys/ethernet.h [PSARC/2007/479 FastTrack timeout 08/29/2007] In-reply-to: <18124.44570.493268.356396@gargle.gargle.HOWL> Sender: Garrett.Damore@sun.com To: James Carlson Cc: Darren.Reed@sun.com, PSARC-ext@sun.com, "Garrett D'Amore - sun microsystems" Message-id: <1187821546.909.675.camel@zippy> Organization: Sun Microsystems, Inc. MIME-version: 1.0 X-Mailer: Evolution 2.10.2 Content-type: text/plain Content-transfer-encoding: 7BIT X-PMX-Version: 5.2.0.264296 References: <200708221700.l7MH0KVa013130@sac.sfbay.sun.com> <46CCA7CD.2010009@Sun.COM> <1187818552.909.664.camel@zippy> <18124.44570.493268.356396@gargle.gargle.HOWL> Status: RO Content-Length: 390 On Wed, 2007-08-22 at 17:43 -0400, James Carlson wrote: > Garrett D'Amore writes: > > I am proposing just that. Right now, I'm not sure they are covered by > > any ARC cases whatsoever. > > You might as well make them Committed. It's not as though #defines of > architectural constants can "evolve" in any meaningful way. > I tend to agree. Lets call them Committed. :-) - Garrett From jek3@sun.com Mon Aug 27 12:28:20 2007 Received: from sunmail4.Singapore.Sun.COM (sunmail4.Singapore.Sun.COM [129.158.71.19]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id l7RJSJMI020503 for ; Mon, 27 Aug 2007 12:28:19 -0700 (PDT) Received: from brm-avmta-1.central.sun.com (brm-avmta-1.Central.Sun.COM [129.147.4.11]) by sunmail4.Singapore.Sun.COM (8.13.4+Sun/8.13.3/ENSMAIL,v2.2) with ESMTP id l7RJPXSf004461; Tue, 28 Aug 2007 03:25:37 +0800 (SGT) Received: from pmxchannel-daemon.brm-avmta-1.central.sun.com by brm-avmta-1.central.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0JNG00L2P5YOUA00@brm-avmta-1.central.sun.com>; Mon, 27 Aug 2007 13:25:36 -0600 (MDT) Received: from jurassic-x4600.sfbay.sun.com ([129.146.17.63]) by brm-avmta-1.central.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0JNG00ES65YNL160@brm-avmta-1.central.sun.com>; Mon, 27 Aug 2007 13:25:35 -0600 (MDT) Received: from [129.150.12.124] (vpn-129-150-12-124.SFBay.Sun.COM [129.150.12.124]) by jurassic-x4600.sfbay.sun.com (8.14.1+Sun/8.14.1) with ESMTP id l7RJPXAJ779179; Mon, 27 Aug 2007 12:25:34 -0700 (PDT) Date: Mon, 27 Aug 2007 09:22:20 -1000 From: Joseph Kowalski Subject: Re: VLAN macros for sys/ethernet.h [PSARC/2007/479 FastTrack timeout 08/29/2007] In-reply-to: <18124.44570.493268.356396@gargle.gargle.HOWL> To: James Carlson Cc: "Garrett D'Amore" , Darren.Reed@sun.com, PSARC-ext@sun.com, "Garrett D'Amore - sun microsystems" Message-id: <46D3246C.2090305@sun.com> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7BIT X-PMX-Version: 5.2.0.264296 References: <200708221700.l7MH0KVa013130@sac.sfbay.sun.com> <46CCA7CD.2010009@Sun.COM> <1187818552.909.664.camel@zippy> <18124.44570.493268.356396@gargle.gargle.HOWL> User-Agent: Thunderbird 1.5.0.5 (X11/20060925) Status: RO Content-Length: 511 James Carlson wrote: > Garrett D'Amore writes: > >> I am proposing just that. Right now, I'm not sure they are covered by >> any ARC cases whatsoever. >> > > You might as well make them Committed. It's not as though #defines of > architectural constants can "evolve" in any meaningful way. > Just to be obnoxious, they could "evolve" by deletion. :-) That said, I don't care if they are Committed or Uncommitted (as with the vast majority of the DDI). They should just be one of these. - jek3 From Garrett.Damore@sun.com Wed Sep 5 11:29:57 2007 Received: from sunmail4.Singapore.Sun.COM (sunmail4.Singapore.Sun.COM [129.158.71.19]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id l85ITuUl026972 for ; Wed, 5 Sep 2007 11:29:56 -0700 (PDT) Received: from brm-avmta-1.central.sun.com (brm-avmta-1.Central.Sun.COM [129.147.4.11]) by sunmail4.Singapore.Sun.COM (8.13.4+Sun/8.13.3/ENSMAIL,v2.2) with ESMTP id l85IR6RG013822 for <@sunmail2sca.sfbay.sun.com:PSARC-ext@sun.com>; Thu, 6 Sep 2007 02:27:09 +0800 (SGT) Received: from pmxchannel-daemon.brm-avmta-1.central.sun.com by brm-avmta-1.central.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0JNW0040HR97NC00@brm-avmta-1.central.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 05 Sep 2007 12:27:07 -0600 (MDT) Received: from sca-es-mail-1.sun.com ([192.18.43.132]) by brm-avmta-1.central.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0JNW00MELR95HI70@brm-avmta-1.central.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 05 Sep 2007 12:27:05 -0600 (MDT) Received: from fe-sfbay-10.sun.com ([192.18.43.129]) by sca-es-mail-1.sun.com (8.13.7+Sun/8.12.9) with ESMTP id l85IR5A9017736 for ; Wed, 05 Sep 2007 11:27:05 -0700 (PDT) Received: from conversion-daemon.fe-sfbay-10.sun.com by fe-sfbay-10.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) id <0JNW00H01QWRLT00@fe-sfbay-10.sun.com> (original mail from Garrett.Damore@Sun.COM) for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 05 Sep 2007 11:27:05 -0700 (PDT) Received: from [192.168.251.21] ([76.174.83.55]) by fe-sfbay-10.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) with ESMTPSA id <0JNW008RNR8Y5070@fe-sfbay-10.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 05 Sep 2007 11:26:59 -0700 (PDT) Date: Wed, 05 Sep 2007 11:22:17 -0700 From: "Garrett D'Amore" Subject: PSARC 2007/479 VLAN macros for sys/ethernet Sender: Garrett.Damore@sun.com To: PSARC-ext@sun.com Message-id: <1189016537.2556.505.camel@zippy> Organization: Sun Microsystems, Inc. MIME-version: 1.0 X-Mailer: Evolution 2.10.2 Content-type: text/plain Content-transfer-encoding: 7BIT X-PMX-Version: 5.2.0.264296 Status: RO Content-Length: 44 This case has been approved. -- Garrett