From carlsonj@phorcys.east.sun.com Thu Aug 23 04:32:50 2007 Received: from sunmail3mpk.sfbay.sun.com (sunmail3mpk [129.146.11.52]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id l7NBWosg011667 for ; Thu, 23 Aug 2007 04:32:50 -0700 (PDT) Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6]) by sunmail3mpk.sfbay.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id l7NBUBOr012434; Thu, 23 Aug 2007 04:30:17 -0700 (PDT) Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0JN800B095AHAS00@nwk-avmta-2.sfbay.sun.com>; Thu, 23 Aug 2007 04:30:17 -0700 (PDT) Received: from phorcys.east.sun.com ([129.148.174.143]) by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0JN8002CT5AGTV60@nwk-avmta-2.sfbay.sun.com>; Thu, 23 Aug 2007 04:30:16 -0700 (PDT) Received: from phorcys.east.sun.com (localhost [127.0.0.1]) by phorcys.east.sun.com (8.14.1+Sun/8.14.1) with ESMTP id l7NBU96b004928; Thu, 23 Aug 2007 07:30:09 -0400 (EDT) Received: (from carlsonj@localhost) by phorcys.east.sun.com (8.14.1+Sun/8.14.1/Submit) id l7NBU9pN004925; Thu, 23 Aug 2007 07:30:09 -0400 (EDT) Date: Thu, 23 Aug 2007 07:30:09 -0400 From: James Carlson Subject: Re: zpool upgrade -V [PSARC/2007/482 FastTrack timeout 08/30/2007] In-reply-to: <200708222337.l7MNbwlw017645@zion.eng.sun.com> To: Matthew Ahrens Cc: PSARC-ext@sun.com, zfs-eng@sun.com Message-id: <18125.28609.199700.390708@gargle.gargle.HOWL> MIME-version: 1.0 X-Mailer: VM 7.01 under Emacs 21.3.1 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7BIT X-PMX-Version: 5.2.0.264296 References: <200708222337.l7MNbwlw017645@zion.eng.sun.com> Status: RO Content-Length: 568 Matthew Ahrens writes: > Or to an intermediate version (which has to be between the current > version and the latest) by using: > > zpool set version=N > > (as introduced in PSARC/2007/342, but not yet integrated) Since it hasn't integrated, and since it's now duplicate functionality, should the "set version=N" variant be removed? -- James Carlson, Solaris Networking Sun Microsystems / 1 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677 From lin.ling@Sun.COM Thu Aug 23 10:32:26 2007 Received: from sunmail4.Singapore.Sun.COM (sunmail4.Singapore.Sun.COM [129.158.71.19]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id l7NHWPlA018876 for ; Thu, 23 Aug 2007 10:32:26 -0700 (PDT) Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6]) by sunmail4.Singapore.Sun.COM (8.13.4+Sun/8.13.3/ENSMAIL,v2.2) with ESMTP id l7NHTefU007984; Fri, 24 Aug 2007 01:29:51 +0800 (SGT) Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0JN800807LXQ0F00@nwk-avmta-2.sfbay.sun.com>; Thu, 23 Aug 2007 10:29:50 -0700 (PDT) Received: from engmail3mpk.sfbay.Sun.COM ([129.146.11.26]) by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0JN8002NXLXP0LA0@nwk-avmta-2.sfbay.sun.com>; Thu, 23 Aug 2007 10:29:49 -0700 (PDT) Received: from zion.eng.sun.com (zion.SFBay.Sun.COM [129.146.17.75]) by engmail3mpk.sfbay.Sun.COM (8.13.6+Sun/8.13.6/ENSMAIL,v2.2) with ESMTP id l7NHTnur016007; Thu, 23 Aug 2007 10:29:49 -0700 (PDT) Received: from [129.145.154.80] (sr1-umpk-30.SFBay.Sun.COM [129.145.154.80]) by zion.eng.sun.com (8.14.1+Sun/8.14.1) with ESMTP id l7NHTmTK001860; Thu, 23 Aug 2007 10:29:48 -0700 (PDT) Date: Thu, 23 Aug 2007 10:29:48 -0700 From: Lin Ling Subject: Re: zpool upgrade -V [PSARC/2007/482 FastTrack timeout 08/30/2007] In-reply-to: <18125.28609.199700.390708@gargle.gargle.HOWL> To: James Carlson Cc: Matthew Ahrens , PSARC-ext@Sun.COM, zfs-eng@Sun.COM Message-id: <46CDC40C.5090209@sun.com> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7BIT X-PMX-Version: 5.2.0.264296 References: <200708222337.l7MNbwlw017645@zion.eng.sun.com> <18125.28609.199700.390708@gargle.gargle.HOWL> User-Agent: Thunderbird 1.5.0.8 (X11/20061110) Status: RO Content-Length: 728 This is to make it consistent with the existing zfs version setting: zfs set version=n zfs upgrade -V n 'zpool upgrade' does more than just setting the version, it provides mechanism for listing pool versions as well. Having 2 ways to set the version seems reasonable to me. Thanks, Lin James Carlson wrote: > Matthew Ahrens writes: > >> Or to an intermediate version (which has to be between the current >> version and the latest) by using: >> >> zpool set version=N >> >> (as introduced in PSARC/2007/342, but not yet integrated) >> > > Since it hasn't integrated, and since it's now duplicate > functionality, should the "set version=N" variant be removed? > > From carlsonj@phorcys.east.sun.com Thu Aug 23 10:39:32 2007 Received: from sunmail5.uk.sun.com (sunmail5.UK.Sun.COM [129.156.85.165]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id l7NHdVsC018992 for ; Thu, 23 Aug 2007 10:39:31 -0700 (PDT) Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6]) by sunmail5.uk.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id l7NHatMB020934; Thu, 23 Aug 2007 18:36:55 +0100 (BST) Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0JN800807M9HCB00@nwk-avmta-2.sfbay.sun.com>; Thu, 23 Aug 2007 10:36:53 -0700 (PDT) Received: from phorcys.east.sun.com ([129.148.174.143]) by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0JN8002EJM9G0QB0@nwk-avmta-2.sfbay.sun.com>; Thu, 23 Aug 2007 10:36:52 -0700 (PDT) Received: from phorcys.east.sun.com (localhost [127.0.0.1]) by phorcys.east.sun.com (8.14.1+Sun/8.14.1) with ESMTP id l7NHaiwY006670; Thu, 23 Aug 2007 13:36:44 -0400 (EDT) Received: (from carlsonj@localhost) by phorcys.east.sun.com (8.14.1+Sun/8.14.1/Submit) id l7NHai0P006667; Thu, 23 Aug 2007 13:36:44 -0400 (EDT) Date: Thu, 23 Aug 2007 13:36:44 -0400 From: James Carlson Subject: Re: zpool upgrade -V [PSARC/2007/482 FastTrack timeout 08/30/2007] In-reply-to: <46CDC40C.5090209@sun.com> To: Lin Ling Cc: zfs-eng@Sun.COM, PSARC-ext@Sun.COM, Matthew Ahrens Message-id: <18125.50604.18461.877663@gargle.gargle.HOWL> MIME-version: 1.0 X-Mailer: VM 7.01 under Emacs 21.3.1 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7BIT X-PMX-Version: 5.2.0.264296 References: <200708222337.l7MNbwlw017645@zion.eng.sun.com> <18125.28609.199700.390708@gargle.gargle.HOWL> <46CDC40C.5090209@sun.com> Status: RO Content-Length: 667 Lin Ling writes: > This is to make it consistent with the existing zfs version setting: > > zfs set version=n > zfs upgrade -V n > > 'zpool upgrade' does more than just setting the version, Sure; understood. > it provides mechanism for listing pool versions as well. > Having 2 ways to set the version seems reasonable to me. That's the question I'm asking. Why is that reasonable? It seems odd. -- James Carlson, Solaris Networking Sun Microsystems / 1 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677 From Matthew.Ahrens@sun.com Thu Aug 23 10:45:01 2007 Received: from sunmail5.uk.sun.com (sunmail5.UK.Sun.COM [129.156.85.165]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id l7NHj0DP019076 for ; Thu, 23 Aug 2007 10:45:00 -0700 (PDT) Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6]) by sunmail5.uk.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id l7NHgKrg024028; Thu, 23 Aug 2007 18:42:26 +0100 (BST) Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0JN800803MIMJN00@nwk-avmta-2.sfbay.sun.com>; Thu, 23 Aug 2007 10:42:22 -0700 (PDT) Received: from engmail3mpk.sfbay.Sun.COM ([129.146.11.26]) by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0JN800224MIM0SB0@nwk-avmta-2.sfbay.sun.com>; Thu, 23 Aug 2007 10:42:22 -0700 (PDT) Received: from zion.eng.sun.com (zion.SFBay.Sun.COM [129.146.17.75]) by engmail3mpk.sfbay.Sun.COM (8.13.6+Sun/8.13.6/ENSMAIL,v2.2) with ESMTP id l7NHgLdx019541; Thu, 23 Aug 2007 10:42:21 -0700 (PDT) Received: from dhcp-umpk17-229-88.sfbay.sun.com (dhcp-umpk17-229-88 [129.146.229.88]) by zion.eng.sun.com (8.14.1+Sun/8.14.1) with ESMTP id l7NHgLM5002310; Thu, 23 Aug 2007 10:42:21 -0700 (PDT) Date: Thu, 23 Aug 2007 10:42:00 -0700 From: Matthew Ahrens Subject: Re: zpool upgrade -V [PSARC/2007/482 FastTrack timeout 08/30/2007] In-reply-to: <18125.50604.18461.877663@gargle.gargle.HOWL> To: James Carlson Cc: Lin Ling , zfs-eng@sun.com, PSARC-ext@sun.com, Matthew Ahrens Message-id: <46CDC6E8.30302@sun.com> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7BIT X-PMX-Version: 5.2.0.264296 References: <200708222337.l7MNbwlw017645@zion.eng.sun.com> <18125.28609.199700.390708@gargle.gargle.HOWL> <46CDC40C.5090209@sun.com> <18125.50604.18461.877663@gargle.gargle.HOWL> User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728) Status: RO Content-Length: 1385 James Carlson wrote: > Lin Ling writes: >> This is to make it consistent with the existing zfs version setting: >> >> zfs set version=n >> zfs upgrade -V n >> >> 'zpool upgrade' does more than just setting the version, > > Sure; understood. > >> it provides mechanism for listing pool versions as well. >> Having 2 ways to set the version seems reasonable to me. > > That's the question I'm asking. Why is that reasonable? It seems > odd. Since we're exposing the both zfs and zpool "version" as a property, it makes sense to be able to change it with "zfs set". Since we've established the precedent of "zpool upgrade" (and it has additional capabilities, eg. "zpool upgrade -a" and "zfs upgrade -r"), it makes sense to have that as well. Granted, if we could redo the interface from scratch, it would probably be better to only change the version with "zfs/zpool set version"[*], and only get version information with "zfs/zpool upgrade" (or some more appropriately named subcommand). However, given that we can't change the existing "zpool upgrade" interface, this seems like the most self-consistent choice. --matt [*] The "set" subcommands would require some enhancements, eg since we don't have "zfs set -r" but we want "zfs upgrade -r" functionality. So this isn't quite as straightforward as it might first appear. From carlsonj@phorcys.east.sun.com Thu Aug 23 11:02:44 2007 Received: from sunmail5.uk.sun.com (sunmail5.UK.Sun.COM [129.156.85.165]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id l7NI2hBb019927 for ; Thu, 23 Aug 2007 11:02:44 -0700 (PDT) Received: from nwk-avmta-1.SFBay.Sun.COM (nwk-avmta-1.SFBay.Sun.COM [129.146.11.74]) by sunmail5.uk.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id l7NI07Qj004138; Thu, 23 Aug 2007 19:00:08 +0100 (BST) Received: from pmxchannel-daemon.nwk-avmta-1.sfbay.Sun.COM by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0JN800701NC5MD00@nwk-avmta-1.sfbay.Sun.COM>; Thu, 23 Aug 2007 11:00:05 -0700 (PDT) Received: from phorcys.east.sun.com ([129.148.174.143]) by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0JN800FJJNC1D6A0@nwk-avmta-1.sfbay.Sun.COM>; Thu, 23 Aug 2007 11:00:01 -0700 (PDT) Received: from phorcys.east.sun.com (localhost [127.0.0.1]) by phorcys.east.sun.com (8.14.1+Sun/8.14.1) with ESMTP id l7NHxruL006953; Thu, 23 Aug 2007 13:59:53 -0400 (EDT) Received: (from carlsonj@localhost) by phorcys.east.sun.com (8.14.1+Sun/8.14.1/Submit) id l7NHxq7t006950; Thu, 23 Aug 2007 13:59:52 -0400 (EDT) Date: Thu, 23 Aug 2007 13:59:52 -0400 From: James Carlson Subject: Re: zpool upgrade -V [PSARC/2007/482 FastTrack timeout 08/30/2007] In-reply-to: <46CDC6E8.30302@sun.com> To: Matthew Ahrens Cc: Lin Ling , zfs-eng@Sun.COM, PSARC-ext@Sun.COM, Matthew Ahrens Message-id: <18125.51992.887418.963141@gargle.gargle.HOWL> MIME-version: 1.0 X-Mailer: VM 7.01 under Emacs 21.3.1 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7BIT X-PMX-Version: 5.2.0.264296 References: <200708222337.l7MNbwlw017645@zion.eng.sun.com> <18125.28609.199700.390708@gargle.gargle.HOWL> <46CDC40C.5090209@sun.com> <18125.50604.18461.877663@gargle.gargle.HOWL> <46CDC6E8.30302@sun.com> Status: RO Content-Length: 1450 Matthew Ahrens writes: > Since we're exposing the both zfs and zpool "version" as a property, it > makes sense to be able to change it with "zfs set". Since we've established > the precedent of "zpool upgrade" (and it has additional capabilities, eg. > "zpool upgrade -a" and "zfs upgrade -r"), it makes sense to have that as well. OK. It must just be me, then. I find the idea of "set version" to be a bit baffling. I'd expect that (if it did anything), setting the version would be forcing the system to lie about the current version number, rather than changing the on-disk version. It's sort of like seeing a variant on sysinfo(2) that can write to SI_RELEASE. I wouldn't expect that writing a number into there would cause the system to be upgraded. > Granted, if we could redo the interface from scratch, it would probably be > better to only change the version with "zfs/zpool set version"[*], and only > get version information with "zfs/zpool upgrade" (or some more appropriately > named subcommand). However, given that we can't change the existing "zpool > upgrade" interface, this seems like the most self-consistent choice. I see. I guess it doesn't bother me enough to complain more than that. -- James Carlson, Solaris Networking Sun Microsystems / 1 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677 From sacadmin Thu Aug 23 16:17:59 2007 Received: from sfbaymail2sca.sfbay.sun.com (sfbaymail2sca [129.145.155.42]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id l7NNHxC8028180 for ; Thu, 23 Aug 2007 16:17:59 -0700 (PDT) Received: from sca-es-mail-1.sun.com (sca-es-mail-1.Sun.COM [192.18.43.132]) by sfbaymail2sca.sfbay.sun.com (8.13.6+Sun/8.12.10/ENSMAIL,v2.2) with ESMTP id l7NNFQPs015308 for ; Thu, 23 Aug 2007 16:15:26 -0700 (PDT) Received: from fe-sfbay-09.sun.com ([192.18.43.129]) by sca-es-mail-1.sun.com (8.13.7+Sun/8.12.9) with ESMTP id l7NNFKUj026655 for ; Thu, 23 Aug 2007 16:15:20 -0700 (PDT) Received: from conversion-daemon.fe-sfbay-09.sun.com by fe-sfbay-09.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) id <0JN900B011VDKQ00@fe-sfbay-09.sun.com> (original mail from John.Plocher@Sun.COM) for psarc-record@sac.sfbay.sun.com; Thu, 23 Aug 2007 16:15:20 -0700 (PDT) Received: from [192.168.168.4] ([66.166.204.98]) by fe-sfbay-09.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) with ESMTPSA id <0JN900M221WVRU30@fe-sfbay-09.sun.com> for psarc-record@sac.sfbay.sun.com; Thu, 23 Aug 2007 16:14:56 -0700 (PDT) Date: Thu, 23 Aug 2007 16:14:47 -0700 From: John Plocher Subject: zpool upgrade -V [PSARC/2007/482 FastTrack timeout 08/30/2007] Sender: John.Plocher@Sun.COM To: psarc-record@sac.sfbay.sun.com Message-id: <46CE14E7.7080105@Sun.Com> MIME-version: 1.0 Content-type: text/plain; format=flowed; charset=ISO-8859-1 Content-transfer-encoding: 7BIT User-Agent: Thunderbird 1.5.0.12 (Macintosh/20070509) Status: RO Content-Length: 3409 -------- Original Message -------- Subject: sacMaiL Error [PSARC]: zpool upgrade -V [PSARC/2007/482 FastTrack timeout 08/30/2007] Date: Wed, 22 Aug 2007 16:40:39 -0700 (PDT) From: Sac Administrator To: undisclosed-recipients: ; [This message was auto-generated by the SAC mail system] NOT SAVED: /export/sac/Archives/CaseLog/arc/PSARC/2007/482/mail This message was not saved in the project's mail log. This may be because of file permission problems: -rw-rw-r-- 1 ahrens staff 0 Aug 22 16:40 /export/sac/Archives/CaseLog/arc/PSARC/2007/482/mail Please contact SACAdmin@sac.sfbay about this problem. ---- original message follows ---- Date: Wed, 22 Aug 2007 16:37:58 -0700 (PDT) From: Matthew Ahrens Subject: zpool upgrade -V [PSARC/2007/482 FastTrack timeout 08/30/2007] To: PSARC-ext@sun.com Cc: zfs-eng@sun.com Template Version: @(#)sac_nextcase 1.64 07/13/07 SMI This information is Copyright 2007 Sun Microsystems 1. Introduction 1.1. Project/Component Working Name: zpool upgrade -V 1.2. Name of Document Author/Supplier: Author: Lin Ling 1.3 Date of This Document: 22 August, 2007 4. Technical Description A. DESCRIPTION Currently, zpool version can be upgraded to the latest version using: zpool upgrade <-a | pool ...> Or to an intermediate version (which has to be between the current version and the latest) by using: zpool set version=N (as introduced in PSARC/2007/342, but not yet integrated) This case proposes to add a flag to "zpool upgrade" to allow the version number to be specified. The '-V' flag will be used, which is consistent with the 'zfs upgrade -V' syntax (see PSARC/2007/328). B. PROPOSED CHANGES A new flag '-V' will be added to zpool(1M), 'zpool upgrade'. The upgrade subcommand has the following syntax: zpool upgrade zpool upgrade -v zpool upgrade [-V version] <-a | pool ...> When [-V version] is specified, zpool upgrade will upgrade the pool version to the number 'version' (which has to be between the current version and the latest) Note: "zpool upgrade -V " is equivalent to "zpool set version= ". C. MANPAGE CHANGES (1) zpool upgrade -v ! zpool upgrade [-a | pool] --- 87,93 ---- zpool upgrade -v ! zpool upgrade [-V version] [-a | pool ...] (2) ! zpool upgrade [-a | pool] Upgrades the given pool to the latest on-disk version. Once this is done, the pool will no longer be accessible ------- ! zpool upgrade [-V version] [-a | pool ...] Upgrades the given pool to the latest on-disk version. Once this is done, the pool will no longer be accessible (3) -a Upgrades all pools. + -V Upgrade to the specified version. If the -V + flag is not specified, upgrade to the most + recent version. Can only be used to increase + the version number, and only up to the most + recent version supported by this software. 6. Resources and Schedule 6.4. Steering Committee requested information 6.4.1. Consolidation C-team Name: ON 6.5. ARC review type: FastTrack 6.6. ARC Exposure: open ---- end of original message ----