From Sebastien.Roy@sun.com Thu Nov 8 21:27:38 2007 Received: from sunmail2sca.sfbay.sun.com (sunmail2sca [129.145.155.234]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id lA95Rc1n020715 for ; Thu, 8 Nov 2007 21:27:38 -0800 (PST) Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6]) by sunmail2sca.sfbay.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id lA95RcmA025225 for <@sunmail2sca.sfbay.sun.com:PSARC-ext@sun.com>; Thu, 8 Nov 2007 21:27:38 -0800 (PST) Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0JR8008034I2GK00@nwk-avmta-2.sfbay.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Thu, 08 Nov 2007 21:27:38 -0800 (PST) Received: from brmea-mail-2.sun.com ([192.18.98.43]) by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0JR800KYO4I1BJ90@nwk-avmta-2.sfbay.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Thu, 08 Nov 2007 21:27:37 -0800 (PST) Received: from fe-amer-09.sun.com ([192.18.109.79]) by brmea-mail-2.sun.com (8.13.6+Sun/8.12.9) with ESMTP id lA95RbPd028738 for ; Fri, 09 Nov 2007 05:27:37 +0000 (GMT) Received: from conversion-daemon.mail-amer.sun.com by mail-amer.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) id <0JR800K0149S3C00@mail-amer.sun.com> (original mail from Sebastien.Roy@Sun.COM) for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Thu, 08 Nov 2007 22:27:37 -0700 (MST) Received: from [192.168.1.3] ([72.93.210.146]) by mail-amer.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) with ESMTPSA id <0JR800HWV4I0YBB0@mail-amer.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Thu, 08 Nov 2007 22:27:37 -0700 (MST) Date: Fri, 09 Nov 2007 00:27:36 -0500 From: Sebastien Roy Subject: 2007/646 Nemo MAC client updates Sender: Sebastien.Roy@sun.com To: PSARC-ext@sun.com Cc: Cathy Zhou Message-id: <4733EFC8.3040409@sun.com> Organization: Sun Microsystems MIME-version: 1.0 Content-type: text/plain; format=flowed; charset=ISO-8859-1 Content-transfer-encoding: 7BIT X-PMX-Version: 5.2.0.264296 User-Agent: Thunderbird 2.0.0.6 (X11/20071009) Status: RO Content-Length: 2145 I'm sponsoring the following self-reviewed case for Cathy Zhou. I've marked the case as closed approved automatic. --- Release binding: patch 1 Introduction =============== This fast-track proposes to change the signature of the following two GLDv3 functions, which were introduced in PSARC/2006/249. - MAC client interface: mac_open() - DLS clients interface: dls_create() 2. Details =========== 2.2 mac_open() --------------- The current signature of mac_open() is: int mac_open(const char *macname, uint_t ddi_instance, mac_handle_t *mhp); To use this interface, MAC clients have to determine the correct "ddi_instance" by comparing the driver name part of the "macname" argument with all known pseudo driver names, something like: ddi_parse(macname, drv, &ddi_instance); if ((strcmp(drv, "aggr") == 0) || (strcmp(drv, "vnic") == 0)) ddi_instance = 0; mac_open(macname, ddi_instance, &mh); In fact, the comparision logic is already in the mac_open() function, therefore the "ddi_instance" argument is no longer needed. As a result, the function signature will be changed to: int mac_open(const char *macname, mac_handle_t *mhp); 2.1 dls_create() ---------------- The current signature of dls_create() is: int dls_create(const char *linkname, const char *macname, uint_t ddi_instance); This fast track proposes to remove the need of the "ddi_instance" argument, and change the function signature to be: int dls_create(const char *linkname, const char *macname); 3. Interface Table =================== +---------------------------------------------------------+ | | Interfaces Exported | | |-----------------+-----------------------+---------------| | Interface | Classification | Comments | |-----------------+-----------------------+---------------| | mac_open() | Consolidation Private | | | dls_create() | Consolidation Private | | +---------------------------------------------------------+ From gdamore@sun.com Fri Nov 9 09:22:32 2007 Received: from sunmail2sca.sfbay.sun.com (sunmail2sca [129.145.155.234]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id lA9HMWKC001483 for ; Fri, 9 Nov 2007 09:22:32 -0800 (PST) Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6]) by sunmail2sca.sfbay.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id lA9HMTw3018714 for <@sunmail2sca.sfbay.sun.com:PSARC-ext@sun.com>; Fri, 9 Nov 2007 09:22:31 -0800 (PST) Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0JR90020L1LJRT00@nwk-avmta-2.sfbay.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Fri, 09 Nov 2007 09:22:31 -0800 (PST) Received: from sca-es-mail-2.sun.com ([192.18.43.133]) by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0JR900HBG1LHQ6D0@nwk-avmta-2.sfbay.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Fri, 09 Nov 2007 09:22:29 -0800 (PST) Received: from fe-sfbay-10.sun.com ([192.18.43.129]) by sca-es-mail-2.sun.com (8.13.7+Sun/8.12.9) with ESMTP id lA9HMT7X012587 for ; Fri, 09 Nov 2007 09:22:29 -0800 (PST) Received: from conversion-daemon.fe-sfbay-10.sun.com by fe-sfbay-10.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) id <0JR9007011DG8Z00@fe-sfbay-10.sun.com> (original mail from gdamore@sun.com) for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Fri, 09 Nov 2007 09:22:28 -0800 (PST) Received: from [192.168.251.106] ([76.174.83.55]) by fe-sfbay-10.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) with ESMTPSA id <0JR900IL31LF5NF0@fe-sfbay-10.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Fri, 09 Nov 2007 09:22:27 -0800 (PST) Date: Fri, 09 Nov 2007 09:18:24 -0800 From: "Garrett D'Amore" Subject: Re: 2007/646 Nemo MAC client updates In-reply-to: <4733EFC8.3040409@sun.com> Sender: Garrett.Damore@sun.com To: Sebastien Roy Cc: PSARC-ext@sun.com, Cathy Zhou Message-id: <47349660.2050704@sun.com> MIME-version: 1.0 Content-type: text/plain; format=flowed; charset=ISO-8859-1 Content-transfer-encoding: 7BIT X-PMX-Version: 5.2.0.264296 References: <4733EFC8.3040409@sun.com> User-Agent: Thunderbird 2.0.0.4 (X11/20070827) Status: RO Content-Length: 2349 Just a quick note to say "thanks" for taking the time to record this change. -- Garrett Sebastien Roy wrote: > I'm sponsoring the following self-reviewed case for Cathy Zhou. I've > marked the case as closed approved automatic. > > --- > > Release binding: patch > > 1 Introduction > =============== > > This fast-track proposes to change the signature of the following two > GLDv3 functions, which were introduced in PSARC/2006/249. > > - MAC client interface: mac_open() > - DLS clients interface: dls_create() > > 2. Details > =========== > > 2.2 mac_open() > --------------- > > The current signature of mac_open() is: > > int mac_open(const char *macname, uint_t ddi_instance, > mac_handle_t *mhp); > > To use this interface, MAC clients have to determine the correct > "ddi_instance" by comparing the driver name part of the "macname" > argument with all known pseudo driver names, something like: > > ddi_parse(macname, drv, &ddi_instance); > if ((strcmp(drv, "aggr") == 0) || (strcmp(drv, "vnic") == 0)) > ddi_instance = 0; > mac_open(macname, ddi_instance, &mh); > > In fact, the comparision logic is already in the mac_open() function, > therefore the "ddi_instance" argument is no longer needed. As a > result, the function signature will be changed to: > > int mac_open(const char *macname, mac_handle_t *mhp); > > 2.1 dls_create() > ---------------- > > The current signature of dls_create() is: > > int dls_create(const char *linkname, const char *macname, > uint_t ddi_instance); > > This fast track proposes to remove the need of the "ddi_instance" > argument, and change the function signature to be: > > int dls_create(const char *linkname, const char *macname); > > 3. Interface Table > =================== > > +---------------------------------------------------------+ > | | Interfaces Exported | | > |-----------------+-----------------------+---------------| > | Interface | Classification | Comments | > |-----------------+-----------------------+---------------| > | mac_open() | Consolidation Private | | > | dls_create() | Consolidation Private | | > +---------------------------------------------------------+