From ahrens@sac.sfbay.sun.com Fri Dec 21 14:47:56 2007 Received: from newsunmail1brm.central.sun.com (newsunmail1brm.Central.Sun.COM [129.147.62.245]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id lBLMlu5r028336 for ; Fri, 21 Dec 2007 14:47:56 -0800 (PST) Received: from brm-avmta-1.central.sun.com (brm-avmta-1.Central.Sun.COM [129.147.4.11]) by newsunmail1brm.central.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id lBLMltXT023089; Fri, 21 Dec 2007 15:47:55 -0700 (MST) Received: from pmxchannel-daemon.brm-avmta-1.central.sun.com by brm-avmta-1.central.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0JTF006038NVZS00@brm-avmta-1.central.sun.com>; Fri, 21 Dec 2007 15:47:55 -0700 (MST) Received: from localhost.sfbay.sun.com ([129.146.17.46]) by brm-avmta-1.central.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0JTF00KB48NV2T70@brm-avmta-1.central.sun.com>; Fri, 21 Dec 2007 15:47:55 -0700 (MST) Received: from localhost.sfbay.sun.com (localhost [127.0.0.1] (may be forged)) by localhost.sfbay.sun.com (8.14.2+Sun/8.14.2) with ESMTP id lBLMm8PP019620; Fri, 21 Dec 2007 14:48:08 -0800 (PST) Received: (from ahrens@localhost) by localhost.sfbay.sun.com (8.14.2+Sun/8.14.2/Submit) id lBLMm8S5019616; Fri, 21 Dec 2007 14:48:08 -0800 (PST) Date: Fri, 21 Dec 2007 14:48:08 -0800 (PST) From: Matthew Ahrens Subject: zfs rollback -f operative [PSARC/2007/699 Self Review] To: PSARC-ext@sun.com Cc: zfs-eng@sun.com Message-id: <200712212248.lBLMm8S5019616@localhost.sfbay.sun.com> Content-transfer-encoding: 7BIT X-PMX-Version: 5.2.0.264296 Status: RO Content-Length: 774 Template Version: @(#)sac_nextcase 1.64 07/13/07 SMI This information is Copyright 2007 Sun Microsystems 1. Introduction 1.1. Project/Component Working Name: zfs rollback -f operative 1.2. Name of Document Author/Supplier: Author: Matthew Ahrens 1.3 Date of This Document: 21 December, 2007 4. Technical Description 1.0 Description Contrary to PSARC/2007/673 "zfs rollback -f obsolescence", the -f flag to zfs rollback has meaning in some cirsumstances. In particular, when doing a "zfs rollback -Rf", it will force the unmount of any clones which will be destroyed. 6. Resources and Schedule 6.4. Steering Committee requested information 6.4.1. Consolidation C-team Name: ON 6.5. ARC review type: Automatic 6.6. ARC Exposure: open From don.cragun@sun.com Wed Jan 2 11:52:12 2008 Received: from sunmail3mpk.sfbay.sun.com (sunmail3mpk [129.146.11.52]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id m02JqCls004767 for ; Wed, 2 Jan 2008 11:52:12 -0800 (PST) Received: from brm-avmta-1.central.sun.com (brm-avmta-1.Central.Sun.COM [129.147.4.11]) by sunmail3mpk.sfbay.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id m02JqBV1016050; Wed, 2 Jan 2008 11:52:12 -0800 (PST) Received: from pmxchannel-daemon.brm-avmta-1.central.sun.com by brm-avmta-1.central.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0JU100H1D8IZW700@brm-avmta-1.central.sun.com>; Wed, 02 Jan 2008 12:52:11 -0700 (MST) Received: from spartan.SFBay.Sun.COM ([129.146.226.64]) by brm-avmta-1.central.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0JU100F4Y8IVSM10@brm-avmta-1.central.sun.com>; Wed, 02 Jan 2008 12:52:07 -0700 (MST) Received: from spartan.SFBay.Sun.COM (spartan.SFBay.Sun.COM [129.146.226.64]) by spartan.SFBay.Sun.COM (8.13.6+Sun/8.13.6) with SMTP id m02Jq7Je026228; Wed, 02 Jan 2008 11:52:07 -0800 (PST) Date: Wed, 02 Jan 2008 11:52:07 -0800 (PST) From: Don Cragun Subject: Re: zfs rollback -f XXX [PSARC/2007/673 & PSARC/2007/699 Self Review] To: PSARC-ext@sun.com, ahrens@sac.sfbay.sun.com Cc: zfs-eng@sun.com Reply-to: Don Cragun Message-id: <200801021952.m02Jq7Je026228@spartan.SFBay.Sun.COM> MIME-version: 1.0 X-Mailer: dtmail 1.3.0 @(#)CDE Version 1.5.5 SunOS 5.9 sun4u sparc Content-type: TEXT/plain; charset=us-ascii Content-transfer-encoding: 7BIT Content-MD5: HqRjRBjB7di9ddMfb/VA8w== X-PMX-Version: 5.2.0.264296 Status: RO Content-Length: 1369 >Date: Fri, 21 Dec 2007 14:48:08 -0800 (PST) >From: Matthew Ahrens >Subject: zfs rollback -f operative [PSARC/2007/699 Self Review] ... ... ... >4. Technical Description >1.0 Description > >Contrary to PSARC/2007/673 "zfs rollback -f obsolescence", the -f flag >to zfs rollback has meaning in some cirsumstances. In particular, when >doing a "zfs rollback -Rf", it will force the unmount of any clones >which will be destroyed. > ... ... ... I'm confused. Is the intent of PSARC/2007/699 to withdraw PSARC/2007/673 and back out the changes introduced by CRs 6421210 ``zfs rollback without unmounting'' and 6635790 ``"zfs rollback -f" removal breaks backwards compatibility''? If so, why create a new case rather than updating 2007/673? If not, what is the overall change after fixes for both cases are integrated? At the very least, shouldn't the IAM files for 2007/673 and 2007/699 include see also comments pointing to each other? - Don P.S. I also note that the zfs(1M) man page has been updated to say the following about zfs rollback -f: "This obsolete option is ignored, but accepted for backwards compatibility." even though both 6421210 and 6635790 say that documentation is not affected, and there is no mention of obsolete interfaces in the interface stability table on the zfs(1M) man page. From Matthew.Ahrens@sun.com Wed Jan 2 13:23:23 2008 Received: from sunmail4.singapore.sun.com (sunmail4.Singapore.Sun.COM [129.158.71.19]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id m02LNMk3008382 for ; Wed, 2 Jan 2008 13:23:23 -0800 (PST) Received: from nwk-avmta-1.SFBay.Sun.COM (nwk-avmta-1.SFBay.Sun.COM [129.146.11.74]) by sunmail4.singapore.sun.com (8.13.4+Sun/8.13.3/ENSMAIL,v2.2) with ESMTP id m02LNFgu008958; Thu, 3 Jan 2008 05:23:20 +0800 (SGT) Received: from pmxchannel-daemon.nwk-avmta-1.sfbay.Sun.COM by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0JU100701CQU6A00@nwk-avmta-1.sfbay.Sun.COM>; Wed, 02 Jan 2008 13:23:18 -0800 (PST) Received: from zion.sfbay.sun.com ([129.146.17.75]) by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0JU100IILCQUOU90@nwk-avmta-1.sfbay.Sun.COM>; Wed, 02 Jan 2008 13:23:18 -0800 (PST) Received: from dhcp-umpk17-229-112.SFBay.Sun.COM (dhcp-umpk17-229-112.SFBay.Sun.COM [129.146.229.112]) by zion.sfbay.sun.com (8.14.2+Sun/8.14.2) with ESMTP id m02LNBIr239705; Wed, 02 Jan 2008 21:23:11 +0000 (GMT) Date: Wed, 02 Jan 2008 13:23:17 -0800 From: Matthew Ahrens Subject: Re: zfs rollback -f XXX [PSARC/2007/673 & PSARC/2007/699 Self Review] In-reply-to: <200801021952.m02Jq7Je026228@spartan.SFBay.Sun.COM> To: Don Cragun Cc: PSARC-ext@sun.com, ahrens@sac.sfbay.sun.com, zfs-eng@sun.com Message-id: <477C00C5.7030306@sun.com> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7BIT X-PMX-Version: 5.2.0.264296 References: <200801021952.m02Jq7Je026228@spartan.SFBay.Sun.COM> User-Agent: Thunderbird 2.0.0.9 (Macintosh/20071031) Status: RO Content-Length: 2190 Don Cragun wrote: >> Date: Fri, 21 Dec 2007 14:48:08 -0800 (PST) >> From: Matthew Ahrens >> Subject: zfs rollback -f operative [PSARC/2007/699 Self Review] > ... ... ... >> 4. Technical Description >> 1.0 Description >> >> Contrary to PSARC/2007/673 "zfs rollback -f obsolescence", the -f flag >> to zfs rollback has meaning in some cirsumstances. In particular, when >> doing a "zfs rollback -Rf", it will force the unmount of any clones >> which will be destroyed. >> > ... ... ... > > I'm confused. > > Is the intent of PSARC/2007/699 to withdraw PSARC/2007/673 and back out > the changes introduced by CRs 6421210 ``zfs rollback without > unmounting'' and 6635790 ``"zfs rollback -f" removal breaks backwards > compatibility''? If so, why create a new case rather than updating > 2007/673? If not, what is the overall change after fixes for both > cases are integrated? Yes, for the most part, the intent of PSARC/2007/699 is to withdraw PSARC/2007/673. Sorry I wasn't aware of that procedure for modifying an approved (even if "approved automatic") case. As a minor detail, I should note that the net change from before 673 to after 699 is that the -f flag does not cause the named filesystem to be force unmounted (since it is no longer unmounted). However, the -f flag continues to cause clones to be force-unmounted when used with the -R flag. These changes are also noted in manpage bug 6644855. > At the very least, shouldn't the IAM files for 2007/673 and 2007/699 > include see also comments pointing to each other? Sure. > P.S. I also note that the zfs(1M) man page has been updated to say the > following about zfs rollback -f: > "This obsolete option is ignored, but accepted for backwards > compatibility." > even though both 6421210 and 6635790 say that documentation is > not affected, and there is no mention of obsolete interfaces in > the interface stability table on the zfs(1M) man page. The manpage has been updated to reflect 673 but not 699. It will be updated to reflect 699 shortly. The manpage bug is 6644855. I'll update the bugs to mark them "fix affects documentation". --matt From don.cragun@sun.com Wed Jan 2 14:00:04 2008 Received: from sunmail2sca.sfbay.sun.com (sunmail2sca [129.145.155.234]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id m02M04kl010385 for ; Wed, 2 Jan 2008 14:00:04 -0800 (PST) Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6]) by sunmail2sca.sfbay.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id m02M02K1002211; Wed, 2 Jan 2008 14:00:04 -0800 (PST) Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0JU100D0TEG22O00@nwk-avmta-2.sfbay.sun.com>; Wed, 02 Jan 2008 14:00:03 -0800 (PST) Received: from spartan.SFBay.Sun.COM ([129.146.226.64]) by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0JU100AYUEG25150@nwk-avmta-2.sfbay.sun.com>; Wed, 02 Jan 2008 14:00:02 -0800 (PST) Received: from spartan.SFBay.Sun.COM (spartan.SFBay.Sun.COM [129.146.226.64]) by spartan.SFBay.Sun.COM (8.13.6+Sun/8.13.6) with SMTP id m02M01hB026297; Wed, 02 Jan 2008 14:00:01 -0800 (PST) Date: Wed, 02 Jan 2008 14:00:01 -0800 (PST) From: Don Cragun Subject: Re: zfs rollback -f XXX [PSARC/2007/673 & PSARC/2007/699 Self Review] To: Matthew.Ahrens@sun.com Cc: PSARC-ext@sun.com, zfs-eng@sun.com Reply-to: Don Cragun Message-id: <200801022200.m02M01hB026297@spartan.SFBay.Sun.COM> MIME-version: 1.0 X-Mailer: dtmail 1.3.0 @(#)CDE Version 1.5.5 SunOS 5.9 sun4u sparc Content-type: TEXT/plain; charset=us-ascii Content-transfer-encoding: 7BIT Content-MD5: /4uu4v+sZVRTL9tI0MMvAQ== X-PMX-Version: 5.2.0.264296 Status: RO Content-Length: 861 >Date: Wed, 02 Jan 2008 13:23:17 -0800 >From: Matthew Ahrens ... ... ... > >As a minor detail, I should note that the net change from before 673 to >after 699 is that the -f flag does not cause the named filesystem to be >force unmounted (since it is no longer unmounted). However, the -f flag >continues to cause clones to be force-unmounted when used with the -R flag. > >These changes are also noted in manpage bug 6644855. > >> At the very least, shouldn't the IAM files for 2007/673 and 2007/699 >> include see also comments pointing to each other? > >Sure. > ... ... ... > >The manpage has been updated to reflect 673 but not 699. It will be updated >to reflect 699 shortly. The manpage bug is 6644855. > >I'll update the bugs to mark them "fix affects documentation". > >--matt Thanks for the clarification. - Don