From ahrens@sac.sfbay.sun.com Fri May 30 15:18:13 2008
Received: from newsunmail1brm.central.sun.com (newsunmail1brm.Central.Sun.COM [129.147.62.245])
	by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id m4UMIDmO019376
	for <psarc-ext@sac.sfbay.sun.com>; Fri, 30 May 2008 15:18:13 -0700 (PDT)
Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6])
	by newsunmail1brm.central.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id m4UMICTb029998;
	Fri, 30 May 2008 16:18:13 -0600 (MDT)
Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by
 nwk-avmta-2.sfbay.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 id <0K1P0080BCMCLD00@nwk-avmta-2.sfbay.sun.com>; Fri,
 30 May 2008 15:18:12 -0700 (PDT)
Received: from localhost.sfbay.sun.com ([129.146.17.46])
 by nwk-avmta-2.sfbay.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 with ESMTP id <0K1P00833CMB4910@nwk-avmta-2.sfbay.sun.com>; Fri,
 30 May 2008 15:18:11 -0700 (PDT)
Received: from localhost.sfbay.sun.com (localhost [127.0.0.1] (may be forged))
	by localhost.sfbay.sun.com (8.14.2+Sun/8.14.2) with ESMTP id m4UMJjr8002775;
 Fri, 30 May 2008 15:19:45 -0700 (PDT)
Received: (from ahrens@localhost)	by localhost.sfbay.sun.com
 (8.14.2+Sun/8.14.2/Submit) id m4UMJj4k002771; Fri,
 30 May 2008 15:19:45 -0700 (PDT)
Date: Fri, 30 May 2008 15:19:45 -0700 (PDT)
From: Matthew Ahrens <ahrens@sac.sfbay.sun.com>
Subject: zpool autoexpand property [PSARC/2008/353 Self Review]
To: PSARC-ext@sun.com
Cc: zfs-team@sun.com
Message-id: <200805302219.m4UMJj4k002771@localhost.sfbay.sun.com>
Content-transfer-encoding: 7BIT
X-PMX-Version: 5.4.1.325704
Status: RO
Content-Length: 2074


Template Version: @(#)sac_nextcase 1.66 04/17/08 SMI
This information is Copyright 2008 Sun Microsystems
1. Introduction
    1.1. Project/Component Working Name:
	 zpool autoexpand property
    1.2. Name of Document Author/Supplier:
	 Author:  George Wilson
    1.3  Date of This Document:
	30 May, 2008
4. Technical Description

A. SUMMARY

This case add a new pool-level proprty, 'autoexpand,' to the existing
zpool property infrastructure (PSARC 2007/342). This property controls
the behavior of pools in the presence of  Dynamic LUN Expansion (PSARC
2006/373).

B. PROBLEM

With the addition of Dynamic LUN Expansion (PSARC 2006/373), Solaris now
publishes  a sysevent when an underlying device is expanded. ZFS has
been enhanced to take advantage of these events and will adjust the pool
based on the new size of the expanded LUN. However, administrators need
the ability to control this behavior on individual pools.

C. PROPOSED SOLUTION

The introduction of the 'autoexpand' will allow administrators the
ability to enable or disable automatic pool expansion when a Dynamic LUN
Expansion event is received.  The syntax for setting the pool property
utilizes the "set" subcommand defined in PSARC 2006/577:

   # zpool set autoexpand=on <pool>
   # zpool create -o autoexpand=on <pool> <device> ..

D. MANPAGE DIFFS

The following text will be added under the "Properties" section:

   autoexpand=on | off

       Controls automatic pool expansion when the underlying LUN is
       grown. If set to "on", the pool will be resized according to the
       size of the expanded device. If the device is part of a mirror or
       raidz then all devices within that mirror/raidz group must be
       expanded before the new space is made available to the pool. The
       default behavior is "off". This property can also be referred to
       by its shortened column name, "expand". 

6. Resources and Schedule
    6.4. Steering Committee requested information
   	6.4.1. Consolidation C-team Name:
		ON
    6.5. ARC review type: Automatic
    6.6. ARC Exposure: open


From George.Wilson@sun.com Fri May 30 15:20:32 2008
Received: from sunmail4.singapore.sun.com (sunmail4.Singapore.Sun.COM [129.158.71.19])
	by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id m4UMKVZH019522
	for <psarc-ext@sac.sfbay.Sun.COM>; Fri, 30 May 2008 15:20:31 -0700 (PDT)
Received: from brm-avmta-1.central.sun.com (brm-avmta-1.Central.Sun.COM [129.147.4.11])
	by sunmail4.singapore.sun.com (8.13.4+Sun/8.13.3/ENSMAIL,v2.2) with ESMTP id m4UMKQMs006772;
	Sat, 31 May 2008 06:20:30 +0800 (SGT)
Received: from pmxchannel-daemon.brm-avmta-1.central.sun.com by
 brm-avmta-1.central.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 id <0K1P00101CQ45S00@brm-avmta-1.central.sun.com>; Fri,
 30 May 2008 16:20:28 -0600 (MDT)
Received: from brmea-mail-3.sun.com ([192.18.98.34])
 by brm-avmta-1.central.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 with ESMTP id <0K1P00KSUCQ37J10@brm-avmta-1.central.sun.com>; Fri,
 30 May 2008 16:20:27 -0600 (MDT)
Received: from fe-amer-10.sun.com ([192.18.109.80])
	by brmea-mail-3.sun.com (8.13.6+Sun/8.12.9) with ESMTP id m4UMKQXr004191; Fri,
 30 May 2008 22:20:26 +0000 (GMT)
Received: from conversion-daemon.mail-amer.sun.com by mail-amer.sun.com
 (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007))
 id <0K1P00901CF8JN00@mail-amer.sun.com>
 (original mail from George.Wilson@Sun.COM); Fri,
 30 May 2008 16:20:26 -0600 (MDT)
Received: from [129.146.17.46] by mail-amer.sun.com
 (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007))
 with ESMTPSA id <0K1P00DCACPX4X80@mail-amer.sun.com>; Fri,
 30 May 2008 16:20:22 -0600 (MDT)
Date: Fri, 30 May 2008 15:21:55 -0700
From: George Wilson <George.Wilson@sun.com>
Subject: Re: zpool autoexpand property [PSARC/2008/353 Self Review]
In-reply-to: <200805302219.m4UMJj4k002771@localhost.sfbay.sun.com>
Sender: George.Wilson@sun.com
To: Matthew Ahrens <ahrens@sfbay.sun.com>
Cc: PSARC-ext@sun.com, zfs-team@sun.com
Reply-to: George.Wilson@sun.com
Message-id: <48407E03.8060109@Sun.COM>
Organization: Sun Microsystems
MIME-version: 1.0
Content-type: text/plain; format=flowed; charset=ISO-8859-1
Content-transfer-encoding: 7BIT
X-PMX-Version: 5.4.1.325704
References: <200805302219.m4UMJj4k002771@localhost.sfbay.sun.com>
User-Agent: Thunderbird 2.0.0.12 (X11/20080422)
Status: RO
Content-Length: 2246

We are requesting a patch binding.

Matthew Ahrens wrote:
> Template Version: @(#)sac_nextcase 1.66 04/17/08 SMI
> This information is Copyright 2008 Sun Microsystems
> 1. Introduction
>     1.1. Project/Component Working Name:
> 	 zpool autoexpand property
>     1.2. Name of Document Author/Supplier:
> 	 Author:  George Wilson
>     1.3  Date of This Document:
> 	30 May, 2008
> 4. Technical Description
> 
> A. SUMMARY
> 
> This case add a new pool-level proprty, 'autoexpand,' to the existing
> zpool property infrastructure (PSARC 2007/342). This property controls
> the behavior of pools in the presence of  Dynamic LUN Expansion (PSARC
> 2006/373).
> 
> B. PROBLEM
> 
> With the addition of Dynamic LUN Expansion (PSARC 2006/373), Solaris now
> publishes  a sysevent when an underlying device is expanded. ZFS has
> been enhanced to take advantage of these events and will adjust the pool
> based on the new size of the expanded LUN. However, administrators need
> the ability to control this behavior on individual pools.
> 
> C. PROPOSED SOLUTION
> 
> The introduction of the 'autoexpand' will allow administrators the
> ability to enable or disable automatic pool expansion when a Dynamic LUN
> Expansion event is received.  The syntax for setting the pool property
> utilizes the "set" subcommand defined in PSARC 2006/577:
> 
>    # zpool set autoexpand=on <pool>
>    # zpool create -o autoexpand=on <pool> <device> ..
> 
> D. MANPAGE DIFFS
> 
> The following text will be added under the "Properties" section:
> 
>    autoexpand=on | off
> 
>        Controls automatic pool expansion when the underlying LUN is
>        grown. If set to "on", the pool will be resized according to the
>        size of the expanded device. If the device is part of a mirror or
>        raidz then all devices within that mirror/raidz group must be
>        expanded before the new space is made available to the pool. The
>        default behavior is "off". This property can also be referred to
>        by its shortened column name, "expand". 
> 
> 6. Resources and Schedule
>     6.4. Steering Committee requested information
>    	6.4.1. Consolidation C-team Name:
> 		ON
>     6.5. ARC review type: Automatic
>     6.6. ARC Exposure: open
> 


From Torrey.McMahon@sun.com Fri May 30 15:36:26 2008
Received: from sunmail4.singapore.sun.com (sunmail4.Singapore.Sun.COM [129.158.71.19])
	by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id m4UMaPmi019963
	for <psarc-ext@sac.sfbay.Sun.COM>; Fri, 30 May 2008 15:36:25 -0700 (PDT)
Received: from nwk-avmta-1.SFBay.Sun.COM (nwk-avmta-1.SFBay.Sun.COM [129.146.11.74])
	by sunmail4.singapore.sun.com (8.13.4+Sun/8.13.3/ENSMAIL,v2.2) with ESMTP id m4UMaNqc012547;
	Sat, 31 May 2008 06:36:24 +0800 (SGT)
Received: from pmxchannel-daemon.nwk-avmta-1.sfbay.Sun.COM by
 nwk-avmta-1.sfbay.Sun.COM
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 id <0K1P00903DGO6U00@nwk-avmta-1.sfbay.Sun.COM>; Fri,
 30 May 2008 15:36:24 -0700 (PDT)
Received: from brmea-mail-1.sun.com ([192.18.98.31])
 by nwk-avmta-1.sfbay.Sun.COM
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 with ESMTP id <0K1P004I8DGNPA10@nwk-avmta-1.sfbay.Sun.COM>; Fri,
 30 May 2008 15:36:23 -0700 (PDT)
Received: from fe-amer-09.sun.com ([192.18.109.79])
	by brmea-mail-1.sun.com (8.13.6+Sun/8.12.9) with ESMTP id m4UMaN6J002461; Fri,
 30 May 2008 22:36:23 +0000 (GMT)
Received: from conversion-daemon.mail-amer.sun.com by mail-amer.sun.com
 (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007))
 id <0K1P00F01DGDYN00@mail-amer.sun.com>
 (original mail from Torrey.McMahon@Sun.COM); Fri,
 30 May 2008 16:36:23 -0600 (MDT)
Received: from [192.168.0.199] ([69.143.4.246])
 by mail-amer.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28
 2007)) with ESMTPSA id <0K1P00CZZDGLYG00@mail-amer.sun.com>; Fri,
 30 May 2008 16:36:22 -0600 (MDT)
Date: Fri, 30 May 2008 18:36:21 -0400
From: Torrey McMahon <Torrey.McMahon@sun.com>
Subject: Re: zpool autoexpand property [PSARC/2008/353 Self Review]
In-reply-to: <200805302219.m4UMJj4k002771@localhost.sfbay.sun.com>
Sender: Torrey.McMahon@sun.com
To: Matthew Ahrens <ahrens@sac.sfbay.sun.com>
Cc: PSARC-ext@sun.com, zfs-team@sun.com
Message-id: <48408165.7010903@sun.com>
MIME-version: 1.0
Content-type: text/plain; format=flowed; charset=ISO-8859-1
Content-transfer-encoding: 7BIT
X-PMX-Version: 5.4.1.325704
References: <200805302219.m4UMJj4k002771@localhost.sfbay.sun.com>
User-Agent: Thunderbird 2.0.0.14 (Windows/20080421)
Status: RO
Content-Length: 682

Matthew Ahrens wrote:
> [SNIP]
>
> D. MANPAGE DIFFS
>
> The following text will be added under the "Properties" section:
>
>    autoexpand=on | off
>
>        Controls automatic pool expansion when the underlying LUN is
>        grown. If set to "on", the pool will be resized according to the
>        size of the expanded device. If the device is part of a mirror or
>        raidz then all devices within that mirror/raidz group must be
>        expanded before the new space is made available to the pool. The
>        default behavior is "off". This property can also be referred to
>        by its shortened column name, "expand". 


Any particular reason the default is off?

From Matthew.Ahrens@sun.com Fri May 30 15:41:06 2008
Received: from newsunmail1brm.central.sun.com (newsunmail1brm.Central.Sun.COM [129.147.62.245])
	by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id m4UMf6Zc020186
	for <psarc-ext@sac.sfbay.sun.com>; Fri, 30 May 2008 15:41:06 -0700 (PDT)
Received: from nwk-avmta-1.SFBay.Sun.COM (nwk-avmta-1.SFBay.Sun.COM [129.146.11.74])
	by newsunmail1brm.central.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id m4UMf12N034847;
	Fri, 30 May 2008 16:41:04 -0600 (MDT)
Received: from pmxchannel-daemon.nwk-avmta-1.sfbay.Sun.COM by
 nwk-avmta-1.sfbay.Sun.COM
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 id <0K1P00913DOGQ500@nwk-avmta-1.sfbay.Sun.COM>; Fri,
 30 May 2008 15:41:04 -0700 (PDT)
Received: from zion.sfbay.sun.com ([129.146.17.75])
 by nwk-avmta-1.sfbay.Sun.COM
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 with ESMTP id <0K1P004CSDOFPJ20@nwk-avmta-1.sfbay.Sun.COM>; Fri,
 30 May 2008 15:41:03 -0700 (PDT)
Received: from dhcp-umpk17-229-212.SFBay.Sun.COM
 (dhcp-umpk17-229-212.SFBay.Sun.COM [129.146.229.212])
	by zion.sfbay.sun.com (8.14.2+Sun/8.14.2) with ESMTP id m4UMf3ZH020535; Fri,
 30 May 2008 22:41:03 +0000 (GMT)
Date: Fri, 30 May 2008 15:41:03 -0700
From: Matthew Ahrens <Matthew.Ahrens@sun.com>
Subject: Re: zpool autoexpand property [PSARC/2008/353 Self Review]
In-reply-to: <48408165.7010903@sun.com>
To: Torrey McMahon <Torrey.McMahon@sun.com>
Cc: Matthew Ahrens <ahrens@sac.sfbay.sun.com>, PSARC-ext@sun.com,
        zfs-team@sun.com
Message-id: <4840827F.3020703@sun.com>
MIME-version: 1.0
Content-type: text/plain; charset=ISO-8859-1; format=flowed
Content-transfer-encoding: 7BIT
X-PMX-Version: 5.4.1.325704
References: <200805302219.m4UMJj4k002771@localhost.sfbay.sun.com>
 <48408165.7010903@sun.com>
User-Agent: Thunderbird 2.0.0.14 (Macintosh/20080421)
Status: RO
Content-Length: 976

Torrey McMahon wrote:
> Matthew Ahrens wrote:
>> [SNIP]
>>
>> D. MANPAGE DIFFS
>>
>> The following text will be added under the "Properties" section:
>>
>>    autoexpand=on | off
>>
>>        Controls automatic pool expansion when the underlying LUN is
>>        grown. If set to "on", the pool will be resized according to the
>>        size of the expanded device. If the device is part of a mirror or
>>        raidz then all devices within that mirror/raidz group must be
>>        expanded before the new space is made available to the pool. The
>>        default behavior is "off". This property can also be referred to
>>        by its shortened column name, "expand". 
> 
> 
> Any particular reason the default is off?

1. to preserve the existing behavior

2. if they expanded the LUN and for some reason didn't want ZFS to use it 
(eg, they wanted to put a new slice on it for something else), we don't want 
to unexpectedly and irrevocably grab this space.

--matt

From glenn.skinner@sun.com Fri May 30 15:42:52 2008
Received: from sunmail5.uk.sun.com (sunmail5.UK.Sun.COM [129.156.85.165])
	by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id m4UMgqmw020389
	for <psarc-ext@sac.sfbay.sun.com>; Fri, 30 May 2008 15:42:52 -0700 (PDT)
Received: from nwk-avmta-1.SFBay.Sun.COM (nwk-avmta-1.SFBay.Sun.COM [129.146.11.74])
	by sunmail5.uk.sun.com (8.13.8+Sun/8.13.8/ENSMAIL,v2.2) with ESMTP id m4UMgole003109;
	Fri, 30 May 2008 23:42:51 +0100 (BST)
Received: from pmxchannel-daemon.nwk-avmta-1.sfbay.Sun.COM by
 nwk-avmta-1.sfbay.Sun.COM
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 id <0K1P00901DREW900@nwk-avmta-1.sfbay.Sun.COM>; Fri,
 30 May 2008 15:42:50 -0700 (PDT)
Received: from ivrel.sfbay.sun.com ([129.146.74.76])
 by nwk-avmta-1.sfbay.Sun.COM
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 with ESMTP id <0K1P004SIDREPA10@nwk-avmta-1.sfbay.Sun.COM>; Fri,
 30 May 2008 15:42:50 -0700 (PDT)
Received: from ivrel (ivrel [129.146.74.76])
	by ivrel.sfbay.sun.com (8.13.8+Sun/8.13.8) with SMTP id m4UMgoVU023003; Fri,
 30 May 2008 15:42:50 -0700 (PDT)
Date: Fri, 30 May 2008 15:42:50 -0700 (PDT)
From: Glenn Skinner <glenn.skinner@sun.com>
Subject: Re: 2008/353 [zpool autoexpand property]
To: PSARC-ext@sun.com, ahrens@sac.sfbay.sun.com
Cc: zfs-team@sun.com
Reply-to: Glenn Skinner <glenn.skinner@sun.com>
Message-id: <200805302242.m4UMgoVU023003@ivrel.sfbay.sun.com>
MIME-version: 1.0
X-Mailer: dtmail 1.3.0 @(#)CDE Version 1.6_36 SunOS 5.11 sun4u sparc
Content-type: TEXT/plain; charset=us-ascii
Content-transfer-encoding: 7BIT
Content-MD5: O28VLFcUN46lWZWZNQtfKQ==
X-PMX-Version: 5.4.1.325704
Status: RO
Content-Length: 1135

    Date: Fri, 30 May 2008 15:19:45 -0700 (PDT)
    From: Matthew Ahrens <ahrens@sac.sfbay.sun.com>
    Subject: zpool autoexpand property [PSARC/2008/353 Self Review]

    ...
    B. PROBLEM

    With the addition of Dynamic LUN Expansion (PSARC 2006/373),
    Solaris now publishes a sysevent when an underlying device is
    expanded.  ZFS has been enhanced to take advantage of these events
    and will adjust the pool based on the new size of the expanded
    LUN.  However, administrators need the ability to control this
    behavior on individual pools.

    C. PROPOSED SOLUTION

    The introduction of the 'autoexpand' will allow administrators the
    ability to enable or disable automatic pool expansion when a
    Dynamic LUN Expansion event is received.  The syntax for setting
    the pool property utilizes the "set" subcommand defined in PSARC
    2006/577:

       # zpool set autoexpand=on <pool>
       # zpool create -o autoexpand=on <pool> <device> ..

I'm nearly certain I'm failing to see the obvious, but could you
explain why an administrator would ever want this property to be set
to "off"?

		-- Glenn


From Torrey.McMahon@sun.com Fri May 30 15:59:27 2008
Received: from sunmail3mpk.sfbay.sun.com (sunmail3mpk.SFBay.Sun.COM [129.146.11.52])
	by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id m4UMxQ3H022585
	for <psarc-ext@sac.sfbay.sun.com>; Fri, 30 May 2008 15:59:26 -0700 (PDT)
Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6])
	by sunmail3mpk.sfbay.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id m4UMxPUd023249;
	Fri, 30 May 2008 15:59:26 -0700 (PDT)
Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by
 nwk-avmta-2.sfbay.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 id <0K1P00A0PEJ1KS00@nwk-avmta-2.sfbay.sun.com>; Fri,
 30 May 2008 15:59:25 -0700 (PDT)
Received: from brmea-mail-4.sun.com ([192.18.98.36])
 by nwk-avmta-2.sfbay.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 with ESMTP id <0K1P008UFEJ04940@nwk-avmta-2.sfbay.sun.com>; Fri,
 30 May 2008 15:59:24 -0700 (PDT)
Received: from fe-amer-10.sun.com ([192.18.109.80])
	by brmea-mail-4.sun.com (8.13.6+Sun/8.12.9) with ESMTP id m4UMxOUH029101; Fri,
 30 May 2008 22:59:24 +0000 (GMT)
Received: from conversion-daemon.mail-amer.sun.com by mail-amer.sun.com
 (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007))
 id <0K1P00801E3KCY00@mail-amer.sun.com>
 (original mail from Torrey.McMahon@Sun.COM); Fri,
 30 May 2008 16:59:24 -0600 (MDT)
Received: from [192.168.0.199] ([69.143.4.246])
 by mail-amer.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28
 2007)) with ESMTPSA id <0K1P001YXEILZV40@mail-amer.sun.com>; Fri,
 30 May 2008 16:59:11 -0600 (MDT)
Date: Fri, 30 May 2008 18:59:09 -0400
From: Torrey McMahon <Torrey.McMahon@sun.com>
Subject: Re: zpool autoexpand property [PSARC/2008/353 Self Review]
In-reply-to: <4840827F.3020703@sun.com>
Sender: Torrey.McMahon@sun.com
To: Matthew Ahrens <Matthew.Ahrens@sun.com>
Cc: Matthew Ahrens <ahrens@sac.sfbay.sun.com>, PSARC-ext@sun.com,
        zfs-team@sun.com
Message-id: <484086BD.2070008@sun.com>
MIME-version: 1.0
Content-type: text/plain; format=flowed; charset=ISO-8859-1
Content-transfer-encoding: 7BIT
X-PMX-Version: 5.4.1.325704
References: <200805302219.m4UMJj4k002771@localhost.sfbay.sun.com>
 <48408165.7010903@sun.com> <4840827F.3020703@sun.com>
User-Agent: Thunderbird 2.0.0.14 (Windows/20080421)
Status: RO
Content-Length: 1138

Matthew Ahrens wrote:
> Torrey McMahon wrote:
>> Matthew Ahrens wrote:
>>> [SNIP]
>>>
>>> D. MANPAGE DIFFS
>>>
>>> The following text will be added under the "Properties" section:
>>>
>>>    autoexpand=on | off
>>>
>>>        Controls automatic pool expansion when the underlying LUN is
>>>        grown. If set to "on", the pool will be resized according to the
>>>        size of the expanded device. If the device is part of a 
>>> mirror or
>>>        raidz then all devices within that mirror/raidz group must be
>>>        expanded before the new space is made available to the pool. The
>>>        default behavior is "off". This property can also be referred to
>>>        by its shortened column name, "expand". 
>>
>>
>> Any particular reason the default is off?
>
> 1. to preserve the existing behavior
>
> 2. if they expanded the LUN and for some reason didn't want ZFS to use 
> it (eg, they wanted to put a new slice on it for something else), we 
> don't want to unexpectedly and irrevocably grab this space. 

Would it be possible to set if to on for new pools that utilize the 
whole disk but default to off for others?


From ceri@submonkey.net Fri May 30 16:02:15 2008
Received: from sunmail5.uk.sun.com (sunmail5.UK.Sun.COM [129.156.85.165])
	by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id m4UN2Enx022809
	for <psarc-ext@sac.sfbay.sun.com>; Fri, 30 May 2008 16:02:15 -0700 (PDT)
Received: from nwk-avmta-1.SFBay.Sun.COM (nwk-avmta-1.SFBay.Sun.COM [129.146.11.74])
	by sunmail5.uk.sun.com (8.13.8+Sun/8.13.8/ENSMAIL,v2.2) with ESMTP id m4UN29s3009687
	for <@sunmail2sca.sfbay.sun.com:PSARC-ext@sun.com>; Sat, 31 May 2008 00:02:14 +0100 (BST)
Received: from pmxchannel-daemon.nwk-avmta-1.sfbay.Sun.COM by
 nwk-avmta-1.sfbay.Sun.COM
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 id <0K1P00C01ENN5T00@nwk-avmta-1.sfbay.Sun.COM> for PSARC-ext@sun.com
 (ORCPT PSARC-ext@sun.com); Fri, 30 May 2008 16:02:11 -0700 (PDT)
Received: from sca-ea-mail-2.sun.com ([192.18.43.25])
 by nwk-avmta-1.sfbay.Sun.COM
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 with ESMTP id <0K1P004IRENMPA20@nwk-avmta-1.sfbay.Sun.COM> for
 PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Fri,
 30 May 2008 16:02:10 -0700 (PDT)
Received: from relay11i.sun.com
 (ip121.net129179-4.block1.us.syntegra.com [129.179.4.121])
	by sca-ea-mail-2.sun.com (8.13.7+Sun/8.12.9) with ESMTP id m4UN25Lp023980	for
 <PSARC-ext@sun.com>; Fri, 30 May 2008 23:02:10 +0000 (GMT)
Received: from mmp11es.mmp.us.syntegra.com ([160.41.208.11] [160.41.208.11])
 by relay11i.sun.com with ESMTP id BT-MMP-149108 for PSARC-ext@sun.com; Fri,
 30 May 2008 23:02:02 +0000 (Z)
Received: from relay16i.sun.com (relay16i.sun.com [129.179.4.126])
 by mmp11es.mmp.us.syntegra.com with ESMTP id BT-MMP-14336264 for
 PSARC-ext@sun.com; Fri, 30 May 2008 23:02:01 +0000 (Z)
Received: from shrike.submonkey.net ([82.15.31.38] [82.15.31.38])
 by relay1i.sun.com with ESMTP id BT-MMP-1768550 for PSARC-ext@sun.com; Fri,
 30 May 2008 23:02:01 +0000 (Z)
Received: from ceri by shrike.submonkey.net with local (Exim 4.69 (FreeBSD))
	(envelope-from <ceri@submonkey.net>)	id 1K2Dbi-000PsZ-BX; Sat,
 31 May 2008 00:01:58 +0100
Date: Sat, 31 May 2008 00:01:58 +0100
From: Ceri Davies <ceri@submonkey.net>
Subject: Re: zpool autoexpand property [PSARC/2008/353 Self Review]
In-reply-to: <4840827F.3020703@sun.com>
Sender: Ceri Davies <ceri@submonkey.net>
To: Matthew Ahrens <Matthew.Ahrens@sun.com>
Cc: Torrey McMahon <Torrey.McMahon@sun.com>, zfs-team@sun.com,
        PSARC-ext@sun.com, Matthew Ahrens <ahrens@sac.sfbay.sun.com>
Message-id: <20080530230157.GA34109@submonkey.net>
MIME-version: 1.0
Content-type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary=tKW2IUtsqtDRztdT
Content-disposition: inline
X-PMX-Version: 5.4.1.325704
X-Brightmail-Tracker: AAAAAA==
X-PGP: finger ceri@FreeBSD.org
X-Antispam: No, score=0.0/5.0, scanned in 0.181sec at (localhost [127.0.0.1])
	by smf-spamd v1.3.1 - http://smfs.sf.net/
References: <200805302219.m4UMJj4k002771@localhost.sfbay.sun.com>
 <48408165.7010903@sun.com> <4840827F.3020703@sun.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Status: RO
Content-Length: 2102


--tKW2IUtsqtDRztdT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 30, 2008 at 03:41:03PM -0700, Matthew Ahrens wrote:
> Torrey McMahon wrote:
> > Matthew Ahrens wrote:
> >> [SNIP]
> >>
> >> D. MANPAGE DIFFS
> >>
> >> The following text will be added under the "Properties" section:
> >>
> >>    autoexpand=3Don | off
> >>
> >>        Controls automatic pool expansion when the underlying LUN is
> >>        grown. If set to "on", the pool will be resized according to the
> >>        size of the expanded device. If the device is part of a mirror =
or
> >>        raidz then all devices within that mirror/raidz group must be
> >>        expanded before the new space is made available to the pool. The
> >>        default behavior is "off". This property can also be referred to
> >>        by its shortened column name, "expand".=20
> >=20
> >=20
> > Any particular reason the default is off?
>=20
> 1. to preserve the existing behavior
>=20
> 2. if they expanded the LUN and for some reason didn't want ZFS to use it=
=20
> (eg, they wanted to put a new slice on it for something else), we don't w=
ant=20
> to unexpectedly and irrevocably grab this space.

I'm all for defaulting to off, especially if there is no command to undo
autoexpansion.

What happens if a LUN is expanded and then autoexpand is subsequently
set to "on"?  Does the expansion take place immediately that the property
is changed, or just not at all?  If it doesn't occur, how would an
administrator have the expansion occur?

(What I think I'm getting at is, should there be an addition to the zpool
manpage as well?)

Ceri
--=20
That must be wonderful!  I don't understand it at all.
                                                  -- Moliere

--tKW2IUtsqtDRztdT
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (FreeBSD)

iD8DBQFIQIdlocfcwTS3JF8RAlhUAKDCwzpadl45oxGLBIojOdcEhLBwIQCeLoAR
xjZ8qxeG92aOddYnWx9FLLk=
=Vz7Y
-----END PGP SIGNATURE-----

--tKW2IUtsqtDRztdT--

From Andrew.Gabriel@sun.com Sat May 31 00:29:35 2008
Received: from sunmail2sca.sfbay.sun.com (sunmail2sca.SFBay.Sun.COM [129.145.155.234])
	by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id m4V7TZaE013231
	for <psarc-ext@sac.sfbay.sun.com>; Sat, 31 May 2008 00:29:35 -0700 (PDT)
Received: from brm-avmta-1.central.sun.com (brm-avmta-1.Central.Sun.COM [129.147.4.11])
	by sunmail2sca.sfbay.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id m4V7TYAF016201;
	Sat, 31 May 2008 00:29:35 -0700 (PDT)
Received: from pmxchannel-daemon.brm-avmta-1.central.sun.com by
 brm-avmta-1.central.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 id <0K1Q00M0F25BWX00@brm-avmta-1.central.sun.com>; Sat,
 31 May 2008 01:29:35 -0600 (MDT)
Received: from gmp-eb-inf-2.sun.com ([192.18.6.24])
 by brm-avmta-1.central.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 with ESMTP id <0K1Q00I882588T60@brm-avmta-1.central.sun.com>; Sat,
 31 May 2008 01:29:33 -0600 (MDT)
Received: from fe-emea-10.sun.com (gmp-eb-lb-2-fe2.eu.sun.com [192.18.6.11])
	by gmp-eb-inf-2.sun.com (8.13.7+Sun/8.12.9) with ESMTP id m4V7TW5r003360; Sat,
 31 May 2008 07:29:32 +0000 (GMT)
Received: from conversion-daemon.fe-emea-10.sun.com by fe-emea-10.sun.com
 (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007))
 id <0K1Q00J011VW8B00@fe-emea-10.sun.com>
 (original mail from Andrew.Gabriel@Sun.COM); Sat,
 31 May 2008 08:29:32 +0100 (BST)
Received: from [192.9.200.17] ([81.187.162.106])
 by fe-emea-10.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28
 2007)) with ESMTPSA id <0K1Q00DGS22KLV30@fe-emea-10.sun.com>; Sat,
 31 May 2008 08:27:56 +0100 (BST)
Date: Sat, 31 May 2008 08:28:51 +0100
From: Andrew Gabriel <Andrew.Gabriel@sun.com>
Subject: Re: 2008/353 [zpool autoexpand property]
In-reply-to: <200805302242.m4UMgoVU023003@ivrel.sfbay.sun.com>
Sender: Andrew.Gabriel@sun.com
To: Glenn Skinner <glenn.skinner@sun.com>
Cc: PSARC-ext@sun.com, ahrens@sac.sfbay.sun.com, zfs-team@sun.com
Message-id: <4840FE33.8030503@sun.com>
MIME-version: 1.0
Content-type: text/plain; format=flowed; charset=ISO-8859-1
Content-transfer-encoding: 7BIT
X-PMX-Version: 5.4.1.325704
References: <200805302242.m4UMgoVU023003@ivrel.sfbay.sun.com>
User-Agent: Thunderbird 2.0.0.12 (X11/20080422)
Status: RO
Content-Length: 1624

Glenn Skinner wrote:
>     Date: Fri, 30 May 2008 15:19:45 -0700 (PDT)
>     From: Matthew Ahrens <ahrens@sac.sfbay.sun.com>
>     Subject: zpool autoexpand property [PSARC/2008/353 Self Review]
> 
>     ...
>     B. PROBLEM
> 
>     With the addition of Dynamic LUN Expansion (PSARC 2006/373),
>     Solaris now publishes a sysevent when an underlying device is
>     expanded.  ZFS has been enhanced to take advantage of these events
>     and will adjust the pool based on the new size of the expanded
>     LUN.  However, administrators need the ability to control this
>     behavior on individual pools.
> 
>     C. PROPOSED SOLUTION
> 
>     The introduction of the 'autoexpand' will allow administrators the
>     ability to enable or disable automatic pool expansion when a
>     Dynamic LUN Expansion event is received.  The syntax for setting
>     the pool property utilizes the "set" subcommand defined in PSARC
>     2006/577:
> 
>        # zpool set autoexpand=on <pool>
>        # zpool create -o autoexpand=on <pool> <device> ..
> 
> I'm nearly certain I'm failing to see the obvious, but could you
> explain why an administrator would ever want this property to be set
> to "off"?

If you have a mirror with non-identical disks, one will be bigger
than the other, even just by a few sectors. If you temporarily
detach the smaller one, you unexpectedly find can't attach it again
if the pool auto-expands to a larger size. This has hit a number
of people. Similarly, SVM does not expand metadevices until
explicitly told to do so, which I believe is a sensible default
and avoids this problem.

-- 
Andrew


From carlsonj@phorcys.east.sun.com Mon Jun  2 07:12:04 2008
Received: from newsunmail1brm.central.sun.com (newsunmail1brm.Central.Sun.COM [129.147.62.245])
	by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id m52EC3rM007716
	for <psarc-ext@sac.sfbay.sun.com>; Mon, 2 Jun 2008 07:12:03 -0700 (PDT)
Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6])
	by newsunmail1brm.central.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id m52EC28w010390;
	Mon, 2 Jun 2008 08:12:03 -0600 (MDT)
Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by
 nwk-avmta-2.sfbay.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 id <0K1U00E11A423500@nwk-avmta-2.sfbay.sun.com>; Mon,
 02 Jun 2008 07:12:02 -0700 (PDT)
Received: from phorcys.east.sun.com ([129.148.174.143])
 by nwk-avmta-2.sfbay.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 with ESMTP id <0K1U00BDJA415PA0@nwk-avmta-2.sfbay.sun.com>; Mon,
 02 Jun 2008 07:12:02 -0700 (PDT)
Received: from phorcys.east.sun.com (localhost [127.0.0.1])
	by phorcys.east.sun.com (8.14.3+Sun/8.14.3) with ESMTP id m52EC0ne016906; Mon,
 02 Jun 2008 10:12:00 -0400 (EDT)
Received: (from carlsonj@localhost)
	by phorcys.east.sun.com (8.14.3+Sun/8.14.3/Submit) id m52EC0jK016903; Mon,
 02 Jun 2008 10:12:00 -0400 (EDT)
Date: Mon, 02 Jun 2008 10:12:00 -0400
From: James Carlson <james.d.carlson@sun.com>
Subject: Re: zpool autoexpand property [PSARC/2008/353 Self Review]
In-reply-to: <200805302219.m4UMJj4k002771@localhost.sfbay.sun.com>
To: Matthew Ahrens <ahrens@sac.sfbay.sun.com>
Cc: PSARC-ext@sun.com, zfs-team@sun.com
Message-id: <18499.65456.702740.798642@gargle.gargle.HOWL>
MIME-version: 1.0
X-Mailer: VM 7.01 under Emacs 21.3.1
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7BIT
X-PMX-Version: 5.4.1.325704
References: <200805302219.m4UMJj4k002771@localhost.sfbay.sun.com>
Status: RO
Content-Length: 1265

Matthew Ahrens writes:
> The introduction of the 'autoexpand' will allow administrators the
> ability to enable or disable automatic pool expansion when a Dynamic LUN
> Expansion event is received.  The syntax for setting the pool property
> utilizes the "set" subcommand defined in PSARC 2006/577:
> 
>    # zpool set autoexpand=on <pool>
>    # zpool create -o autoexpand=on <pool> <device> ..
[...]
>        expanded before the new space is made available to the pool. The
>        default behavior is "off". This property can also be referred to

Having been bit by this, I certainly agree with having this feature
default to "off".  It's surprising when detaching a disk causes the
rubber band to snap outwards.

However, what explicit command can I use when I want to cause the
expansion to occur?  With SVM, I would have done my disk manipulations
(whatever they were) and then finally told SVM to sync up with the
largest available disk in the pool like this:

	# metattach d1

Shouldn't there be a command like "zpool grow <pool>"?

-- 
James Carlson, Solaris Networking              <james.d.carlson@sun.com>
Sun Microsystems / 35 Network Drive        71.232W   Vox +1 781 442 2084
MS UBUR02-212 / Burlington MA 01803-2757   42.496N   Fax +1 781 442 1677

From George.Wilson@sun.com Mon Jun  2 09:55:37 2008
Received: from sunmail5.uk.sun.com (sunmail5.UK.Sun.COM [129.156.85.165])
	by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id m52Gta27013160
	for <psarc-ext@sac.sfbay.sun.com>; Mon, 2 Jun 2008 09:55:36 -0700 (PDT)
Received: from nwk-avmta-1.SFBay.Sun.COM (nwk-avmta-1.SFBay.Sun.COM [129.146.11.74])
	by sunmail5.uk.sun.com (8.13.8+Sun/8.13.8/ENSMAIL,v2.2) with ESMTP id m52GtUsI005258;
	Mon, 2 Jun 2008 17:55:35 +0100 (BST)
Received: from pmxchannel-daemon.nwk-avmta-1.sfbay.Sun.COM by
 nwk-avmta-1.sfbay.Sun.COM
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 id <0K1U0032HHOMZE00@nwk-avmta-1.sfbay.Sun.COM>; Mon,
 02 Jun 2008 09:55:34 -0700 (PDT)
Received: from brmea-mail-3.sun.com ([192.18.98.34])
 by nwk-avmta-1.sfbay.Sun.COM
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 with ESMTP id <0K1U00EO7HOJ7WB0@nwk-avmta-1.sfbay.Sun.COM>; Mon,
 02 Jun 2008 09:55:31 -0700 (PDT)
Received: from fe-amer-09.sun.com ([192.18.109.79])
	by brmea-mail-3.sun.com (8.13.6+Sun/8.12.9) with ESMTP id m52GtUDW011020; Mon,
 02 Jun 2008 16:55:30 +0000 (GMT)
Received: from conversion-daemon.mail-amer.sun.com by mail-amer.sun.com
 (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007))
 id <0K1U00801H97D600@mail-amer.sun.com>
 (original mail from George.Wilson@Sun.COM); Mon,
 02 Jun 2008 10:55:30 -0600 (MDT)
Received: from wombat.local ([69.181.141.32])
 by mail-amer.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28
 2007)) with ESMTPSA id <0K1U00AWGHOH7730@mail-amer.sun.com>; Mon,
 02 Jun 2008 10:55:30 -0600 (MDT)
Date: Mon, 02 Jun 2008 09:55:29 -0700
From: George Wilson <George.Wilson@sun.com>
Subject: Re: zpool autoexpand property [PSARC/2008/353 Self Review]
In-reply-to: <18499.65456.702740.798642@gargle.gargle.HOWL>
Sender: George.Wilson@sun.com
To: James Carlson <james.d.carlson@sun.com>
Cc: Matthew Ahrens <ahrens@sac.sfbay.sun.com>, PSARC-ext@sun.com,
        zfs-team@sun.com
Message-id: <48442601.5080808@sun.com>
MIME-version: 1.0
Content-type: text/plain; format=flowed; charset=ISO-8859-1
Content-transfer-encoding: 7BIT
X-PMX-Version: 5.4.1.325704
References: <200805302219.m4UMJj4k002771@localhost.sfbay.sun.com>
 <18499.65456.702740.798642@gargle.gargle.HOWL>
User-Agent: Thunderbird 2.0.0.14 (Macintosh/20080421)
Status: RO
Content-Length: 1370

James Carlson wrote:
> Matthew Ahrens writes:
>   
>> The introduction of the 'autoexpand' will allow administrators the
>> ability to enable or disable automatic pool expansion when a Dynamic LUN
>> Expansion event is received.  The syntax for setting the pool property
>> utilizes the "set" subcommand defined in PSARC 2006/577:
>>
>>    # zpool set autoexpand=on <pool>
>>    # zpool create -o autoexpand=on <pool> <device> ..
>>     
> [...]
>   
>>        expanded before the new space is made available to the pool. The
>>        default behavior is "off". This property can also be referred to
>>     
>
> Having been bit by this, I certainly agree with having this feature
> default to "off".  It's surprising when detaching a disk causes the
> rubber band to snap outwards.
>
> However, what explicit command can I use when I want to cause the
> expansion to occur?  With SVM, I would have done my disk manipulations
> (whatever they were) and then finally told SVM to sync up with the
> largest available disk in the pool like this:
>
> 	# metattach d1
>
> Shouldn't there be a command like "zpool grow <pool>"?
>
>   
You can enable the 'autoexpand' property to do this but it does not give 
you the fine-grained control that mentioned above. We did talk about 
having a new 'zpool online' option to expand a given vdev. This should 
be easy to do.

- George

From carlsonj@phorcys.east.sun.com Mon Jun  2 10:05:20 2008
Received: from newsunmail1brm.central.sun.com (newsunmail1brm.Central.Sun.COM [129.147.62.245])
	by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id m52H5JZV013382
	for <psarc-ext@sac.sfbay.sun.com>; Mon, 2 Jun 2008 10:05:19 -0700 (PDT)
Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6])
	by newsunmail1brm.central.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id m52H5JU1010160;
	Mon, 2 Jun 2008 11:05:19 -0600 (MDT)
Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by
 nwk-avmta-2.sfbay.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 id <0K1U00K03I4UIS00@nwk-avmta-2.sfbay.sun.com>; Mon,
 02 Jun 2008 10:05:19 -0700 (PDT)
Received: from phorcys.east.sun.com ([129.148.174.143])
 by nwk-avmta-2.sfbay.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 with ESMTP id <0K1U00KK2I4S8Z00@nwk-avmta-2.sfbay.sun.com>; Mon,
 02 Jun 2008 10:05:17 -0700 (PDT)
Received: from phorcys.east.sun.com (localhost [127.0.0.1])
	by phorcys.east.sun.com (8.14.3+Sun/8.14.3) with ESMTP id m52H5FZp019047; Mon,
 02 Jun 2008 13:05:15 -0400 (EDT)
Received: (from carlsonj@localhost)
	by phorcys.east.sun.com (8.14.3+Sun/8.14.3/Submit) id m52H5Fcn019044; Mon,
 02 Jun 2008 13:05:15 -0400 (EDT)
Date: Mon, 02 Jun 2008 13:05:15 -0400
From: James Carlson <James.D.Carlson@sun.com>
Subject: Re: zpool autoexpand property [PSARC/2008/353 Self Review]
In-reply-to: <48442601.5080808@sun.com>
To: George Wilson <George.Wilson@sun.com>
Cc: Matthew Ahrens <ahrens@sac.sfbay.sun.com>, PSARC-ext@sun.com,
        zfs-team@sun.com
Message-id: <18500.10315.603344.990741@gargle.gargle.HOWL>
MIME-version: 1.0
X-Mailer: VM 7.01 under Emacs 21.3.1
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7BIT
X-PMX-Version: 5.4.1.325704
References: <200805302219.m4UMJj4k002771@localhost.sfbay.sun.com>
 <18499.65456.702740.798642@gargle.gargle.HOWL> <48442601.5080808@sun.com>
Status: RO
Content-Length: 970

George Wilson writes:
> James Carlson wrote:
> > Shouldn't there be a command like "zpool grow <pool>"?
> >
> >   
> You can enable the 'autoexpand' property to do this but it does not give 
> you the fine-grained control that mentioned above.

That would presumably cause _all_ of the mirrors within a pool to
expand where possible, right?

> We did talk about 
> having a new 'zpool online' option to expand a given vdev. This should 
> be easy to do.

That'd do it for me.  The alternative, I think, would be to have a new
"zpool attach <pool> <device>" (i.e., without <new-device>) variant.
That would be more similar in management to the existing SVM command,
but perhaps that sort of alignment is not a sufficient reason to do it
that way.

-- 
James Carlson, Solaris Networking              <james.d.carlson@sun.com>
Sun Microsystems / 35 Network Drive        71.232W   Vox +1 781 442 2084
MS UBUR02-212 / Burlington MA 01803-2757   42.496N   Fax +1 781 442 1677

From George.Wilson@sun.com Mon Jun  2 10:10:13 2008
Received: from sunmail5.uk.sun.com (sunmail5.UK.Sun.COM [129.156.85.165])
	by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id m52HACPN013486
	for <psarc-ext@sac.sfbay.sun.com>; Mon, 2 Jun 2008 10:10:13 -0700 (PDT)
Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6])
	by sunmail5.uk.sun.com (8.13.8+Sun/8.13.8/ENSMAIL,v2.2) with ESMTP id m52HA8bt012527;
	Mon, 2 Jun 2008 18:10:11 +0100 (BST)
Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by
 nwk-avmta-2.sfbay.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 id <0K1U00K0DICXPC00@nwk-avmta-2.sfbay.sun.com>; Mon,
 02 Jun 2008 10:10:09 -0700 (PDT)
Received: from brmea-mail-2.sun.com ([192.18.98.43])
 by nwk-avmta-2.sfbay.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 with ESMTP id <0K1U00KT4ICX8O00@nwk-avmta-2.sfbay.sun.com>; Mon,
 02 Jun 2008 10:10:09 -0700 (PDT)
Received: from fe-amer-09.sun.com ([192.18.109.79])
	by brmea-mail-2.sun.com (8.13.6+Sun/8.12.9) with ESMTP id m52HA9kc013351; Mon,
 02 Jun 2008 17:10:09 +0000 (GMT)
Received: from conversion-daemon.mail-amer.sun.com by mail-amer.sun.com
 (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007))
 id <0K1U00F01GX1EB00@mail-amer.sun.com>
 (original mail from George.Wilson@Sun.COM); Mon,
 02 Jun 2008 11:10:09 -0600 (MDT)
Received: from wombat.local ([69.181.141.32])
 by mail-amer.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28
 2007)) with ESMTPSA id <0K1U00AX0ICO7770@mail-amer.sun.com>; Mon,
 02 Jun 2008 11:10:00 -0600 (MDT)
Date: Mon, 02 Jun 2008 10:09:59 -0700
From: George Wilson <George.Wilson@sun.com>
Subject: Re: zpool autoexpand property [PSARC/2008/353 Self Review]
In-reply-to: <18500.10315.603344.990741@gargle.gargle.HOWL>
Sender: George.Wilson@sun.com
To: James Carlson <James.D.Carlson@sun.com>
Cc: Matthew Ahrens <ahrens@sac.sfbay.sun.com>, PSARC-ext@sun.com,
        zfs-team@sun.com
Message-id: <48442967.3040401@sun.com>
MIME-version: 1.0
Content-type: text/plain; format=flowed; charset=ISO-8859-1
Content-transfer-encoding: 7BIT
X-PMX-Version: 5.4.1.325704
References: <200805302219.m4UMJj4k002771@localhost.sfbay.sun.com>
 <18499.65456.702740.798642@gargle.gargle.HOWL> <48442601.5080808@sun.com>
 <18500.10315.603344.990741@gargle.gargle.HOWL>
User-Agent: Thunderbird 2.0.0.14 (Macintosh/20080421)
Status: RO
Content-Length: 924

James Carlson wrote:
> George Wilson writes:
>   
>> James Carlson wrote:
>>     
>>> Shouldn't there be a command like "zpool grow <pool>"?
>>>
>>>   
>>>       
>> You can enable the 'autoexpand' property to do this but it does not give 
>> you the fine-grained control that mentioned above.
>>     
>
> That would presumably cause _all_ of the mirrors within a pool to
> expand where possible, right?
>   
Yes, it would scan all devices to see what could be expanded.
>   
>> We did talk about 
>> having a new 'zpool online' option to expand a given vdev. This should 
>> be easy to do.
>>     
>
> That'd do it for me.  The alternative, I think, would be to have a new
> "zpool attach <pool> <device>" (i.e., without <new-device>) variant.
> That would be more similar in management to the existing SVM command,
> but perhaps that sort of alignment is not a sufficient reason to do it
> that way.
>   

Thanks,
George


