From sacadmin Mon Sep 15 13:48:06 2008
Received: from steam.sfbay.sun.com (steam.SFBay.Sun.COM [192.168.83.54])
	by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id m8FKm6RR012020;
	Mon, 15 Sep 2008 13:48:06 -0700 (PDT)
Received: from steam.sfbay.sun.com (localhost [127.0.0.1])
	by steam.sfbay.sun.com (8.14.3+Sun/8.14.3) with ESMTP id m8FKeaZ8020545;
	Mon, 15 Sep 2008 13:40:36 -0700 (PDT)
Received: (from hyw@localhost)
	by steam.sfbay.sun.com (8.14.3+Sun/8.14.3/Submit) id m8FKeacX020541;
	Mon, 15 Sep 2008 13:40:36 -0700 (PDT)
Date: Mon, 15 Sep 2008 13:40:36 -0700 (PDT)
From: Huay-Yong Wang <hyw@steam.sfbay.sun.com>
Message-Id: <200809152040.m8FKeacX020541@steam.sfbay.sun.com>
To: PSARC-record@sac.sfbay.sun.com
Cc: ryan.scott@Sun.Com, xen-discuss@opensolaris.org
Subject: Libvirt APIs for relative paths [PSARC/2008/577 FastTrack timeout 09/22/2008]
Status: RO
Content-Length: 4672



I am sponsoring this project for Ryan Scott.
The timer for this fasttrack is set to expire
9/22/08.


libvirt Relative Paths
======================

1. Background

A domU under xVM can be effectively described by an XML file describing the
machine, and a disk image containing the root disk.  Libvirt and virsh(1M)
provide (among other services) printing the XML description of the domU and
defining a new domU based on that API.  These descriptions currently
provide the full path to the root disk.

While this works well with a single domU, the problem comes when trying to
copy a domU to a different path on a machine or to a separate machine.  The
path to the root disk often must change.  Currently, this requires manually
editing the XML description.

2. Relative Paths

This RFE will introduce two libvirt APIs to allow relative paths in the XML
description, as well as a base path for the relative paths.

3. Library Interfaces

char *virDomainGetRelativeXMLDesc(virDomainPtr domain, int flags,
	const char *relPath);

Similar to virDomainGetXMLDesc(), except with a new relPath argument.  All
disk descriptions in the XML will be relative to this path.

virDomainPtr virDomainDefineRelativeXML(virConnectPtr conn, const char *xml,
	const char *relPath);

Similar to virDomainDefineRelativeXML(), but the relPath argument is new.
When creating a domain, xml may contain relative paths, which will be
defined relative to relPath.

4. virsh(1M) Command Line Changes

Both 'virsh dumpxml' and 'virsh define' will grow --relative-path arguments:

# virsh dumpxml --relative-path /export/guests >file.xml
# virsh define file.xml --relative-path /expor/guests

Example usage:

# virsh dumpxml solaris-pv-0
[snip]
    <disk type='file' device='disk'>
      <driver name='file'/>
      <source file='/export/guests/disks/solaris-pv-0.img'/>
      <target dev='0'/>
    </disk>
[snip]
# virsh dumpxml solaris-pv-0 --relative-path /export/guests/
[snip]
    <disk type='file' device='disk'>
      <driver name='file'/>
      <source file='./disks/solaris-pv-0.img'/>
      <target dev='0'/>
    </disk>
[snip]
# virsh define /export/guests/xml/solaris-pv-0.xml.rel --relative-path /export/guests
Domain solaris-pv-0 defined from /export/guests/xml/solaris-pv-0.xml.rel

# virsh dumpxml solaris-pv-0
[snip]
    <disk type='file' device='disk'>
      <driver name='file'/>
      <source file='/export/guests/disks/solaris-pv-0.img'/>
      <target dev='0'/>
    </disk>
[snip]

Diffs to virsh(1M) will be deposited in the case directory.

5. Interface Stability

-------------------------------------------------------------------------
| Interface			| Stability	| Comments		|
+-------------------------------+---------------+-----------------------+
| virDomainGetRelativeXMLDesc	| Committed	|			|
| virDomainDefineRelativeXML	| Committed	|			|
| virsh(1M) --relative-path	| Committed	|			|
|    options			|		|			|
+-------------------------------+---------------+-----------------------+

6.  Manual pages

Diffs of new virsh.1m proposed.

*** virsh.1m.orig	Tue Sep  9 13:28:10 2008
--- virsh.1m.new	Tue Sep  9 13:52:29 2008
***************
*** 175,184 ****
  	 Directly editing XML configuration is not recommended.
  
  
!      define file
  
  	 Define	(but do	not start) a domain  from  the	specified
! 	 XML file.
  
  
       destroy domain
--- 175,186 ----
  	 Directly editing XML configuration is not recommended.
  
  
!      define file [--relative-path <path>]
  
  	 Define	(but do	not start) a domain  from  the	specified
! 	 XML file.  If the disk paths in the XML contain relative
! 	 paths, the domain will be created with those paths relative
! 	 to <path>, if provided.
  
  
       destroy domain
***************
*** 236,247 ****
  	 file specified	by file	for analysis.
  
  
!      dumpxml domain
  
  	 Output	the configuration of the given domain in XML for-
  	 mat.  Captured	 in  a file, this data can be used as the
  	 argument to a subsequent create subcommand.
  
  
       list [domain...]
  
--- 238,252 ----
  	 file specified	by file	for analysis.
  
  
!      dumpxml domain [--relative-path <path>]
  
  	 Output	the configuration of the given domain in XML for-
  	 mat.  Captured	 in  a file, this data can be used as the
  	 argument to a subsequent create subcommand.
  
+ 	 By default, all paths in the XML will be absolute.  Adding
+ 	 the --relative-path option will make all disk paths relative
+ 	 to <path>.
  
       list [domain...]
  

6. Resources and Schedule
    6.4. Steering Committee requested information
   	6.4.1. Consolidation C-team Name:
		ON
    6.5. ARC review type: FastTrack
    6.6. ARC Exposure: open




From Huay-Yong.Wang@sun.com Mon Sep 15 14:02:29 2008
Received: from newsunmail1brm.central.sun.com (newsunmail1brm.Central.Sun.COM [129.147.62.245])
	by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id m8FL2TEo012612
	for <psarc-ext@sac.sfbay.sun.com>; Mon, 15 Sep 2008 14:02:29 -0700 (PDT)
Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6])
	by newsunmail1brm.central.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id m8FL2Q9E053984
	for <@sunmail2sca.sfbay.sun.com:psarc-ext@sun.com>; Mon, 15 Sep 2008 15:02:29 -0600 (MDT)
Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by
 nwk-avmta-2.sfbay.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 id <0K7900917943F700@nwk-avmta-2.sfbay.sun.com> for psarc-ext@sun.com
 (ORCPT psarc-ext@sun.com); Mon, 15 Sep 2008 14:02:27 -0700 (PDT)
Received: from sca-es-mail-1.sun.com ([192.18.43.132])
 by nwk-avmta-2.sfbay.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 with ESMTP id <0K79005RV9420U80@nwk-avmta-2.sfbay.sun.com> for
 psarc-ext@sun.com (ORCPT psarc-ext@sun.com); Mon,
 15 Sep 2008 14:02:26 -0700 (PDT)
Received: from fe-sfbay-10.sun.com ([192.18.43.129])
	by sca-es-mail-1.sun.com (8.13.7+Sun/8.12.9) with ESMTP id m8FL2QAL006033	for
 <psarc-ext@sun.com>; Mon, 15 Sep 2008 14:02:26 -0700 (PDT)
Received: from conversion-daemon.fe-sfbay-10.sun.com by fe-sfbay-10.sun.com
 (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007))
 id <0K7900G018WEPE00@fe-sfbay-10.sun.com>
 (original mail from Huay-Yong.Wang@Sun.COM)
 for psarc-ext@sun.com (ORCPT psarc-ext@sun.com); Mon,
 15 Sep 2008 14:02:26 -0700 (PDT)
Received: from [129.153.85.10] by fe-sfbay-10.sun.com
 (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007))
 with ESMTPSA id <0K790029393OCSE0@fe-sfbay-10.sun.com> for psarc-ext@sun.com
 (ORCPT psarc-ext@sun.com); Mon, 15 Sep 2008 14:02:13 -0700 (PDT)
Date: Mon, 15 Sep 2008 14:02:12 -0700
From: Huay-Yong Wang <Huay-Yong.Wang@sun.com>
Subject: Libvirt APIs for relative paths [PSARC/2008/577 FastTrack timeout
 09/22/2008]
Sender: Huay-Yong.Wang@sun.com
To: psarc-ext@sun.com
Cc: Ryan.Scott@sun.com, xen-discuss@opensolaris.org
Reply-to: Huay-Yong.Wang@sun.com
Message-id: <48CECD54.4090902@Sun.COM>
MIME-version: 1.0
Content-type: text/plain; format=flowed; charset=ISO-8859-1
Content-transfer-encoding: 7BIT
X-Accept-Language: en-us, en
X-PMX-Version: 5.4.1.325704
User-Agent: Mozilla Thunderbird 0.8 (X11/20040917)
Status: RO
Content-Length: 4691


<resending to psarc-ext>

I am sponsoring this project for Ryan Scott.
The timer for this fasttrack is set to expire
9/22/08.


libvirt Relative Paths
======================

1. Background

A domU under xVM can be effectively described by an XML file describing the
machine, and a disk image containing the root disk.  Libvirt and virsh(1M)
provide (among other services) printing the XML description of the domU and
defining a new domU based on that API.  These descriptions currently
provide the full path to the root disk.

While this works well with a single domU, the problem comes when trying to
copy a domU to a different path on a machine or to a separate machine.  The
path to the root disk often must change.  Currently, this requires manually
editing the XML description.

2. Relative Paths

This RFE will introduce two libvirt APIs to allow relative paths in the XML
description, as well as a base path for the relative paths.

3. Library Interfaces

char *virDomainGetRelativeXMLDesc(virDomainPtr domain, int flags,
	const char *relPath);

Similar to virDomainGetXMLDesc(), except with a new relPath argument.  All
disk descriptions in the XML will be relative to this path.

virDomainPtr virDomainDefineRelativeXML(virConnectPtr conn, const char *xml,
	const char *relPath);

Similar to virDomainDefineRelativeXML(), but the relPath argument is new.
When creating a domain, xml may contain relative paths, which will be
defined relative to relPath.

4. virsh(1M) Command Line Changes

Both 'virsh dumpxml' and 'virsh define' will grow --relative-path arguments:

# virsh dumpxml --relative-path /export/guests >file.xml
# virsh define file.xml --relative-path /expor/guests

Example usage:

# virsh dumpxml solaris-pv-0
[snip]
    <disk type='file' device='disk'>
      <driver name='file'/>
      <source file='/export/guests/disks/solaris-pv-0.img'/>
      <target dev='0'/>
    </disk>
[snip]
# virsh dumpxml solaris-pv-0 --relative-path /export/guests/
[snip]
    <disk type='file' device='disk'>
      <driver name='file'/>
      <source file='./disks/solaris-pv-0.img'/>
      <target dev='0'/>
    </disk>
[snip]
# virsh define /export/guests/xml/solaris-pv-0.xml.rel --relative-path /export/guests
Domain solaris-pv-0 defined from /export/guests/xml/solaris-pv-0.xml.rel


# virsh dumpxml solaris-pv-0
[snip]
    <disk type='file' device='disk'>
      <driver name='file'/>
      <source file='/export/guests/disks/solaris-pv-0.img'/>
      <target dev='0'/>
    </disk>
[snip]

Diffs to virsh(1M) will be deposited in the case directory.

5. Interface Stability

-------------------------------------------------------------------------
| Interface			| Stability	| Comments		|
+-------------------------------+---------------+-----------------------+
| virDomainGetRelativeXMLDesc	| Committed	|			|
| virDomainDefineRelativeXML	| Committed	|			|
| virsh(1M) --relative-path	| Committed	|			|
|    options			|		|			|
+-------------------------------+---------------+-----------------------+

6.  Manual pages

Diffs of new virsh.1m proposed.

*** virsh.1m.orig	Tue Sep  9 13:28:10 2008
--- virsh.1m.new	Tue Sep  9 13:52:29 2008
***************
*** 175,184 ****
  	 Directly editing XML configuration is not recommended.
  
  
!      define file
  
  	 Define	(but do	not start) a domain  from  the	specified
! 	 XML file.
  
  
       destroy domain
--- 175,186 ----
  	 Directly editing XML configuration is not recommended.
  
  
!      define file [--relative-path <path>]
  
  	 Define	(but do	not start) a domain  from  the	specified
! 	 XML file.  If the disk paths in the XML contain relative
! 	 paths, the domain will be created with those paths relative
! 	 to <path>, if provided.
  
  
       destroy domain
***************
*** 236,247 ****
  	 file specified	by file	for analysis.
  
  
!      dumpxml domain
  
  	 Output	the configuration of the given domain in XML for-
  	 mat.  Captured	 in  a file, this data can be used as the
  	 argument to a subsequent create subcommand.


       list [domain...]

--- 238,252 ----
  	 file specified	by file	for analysis.
  
  
!      dumpxml domain [--relative-path <path>]
  
  	 Output	the configuration of the given domain in XML for-
  	 mat.  Captured	 in  a file, this data can be used as the
  	 argument to a subsequent create subcommand.
  
+ 	 By default, all paths in the XML will be absolute.  Adding
+ 	 the --relative-path option will make all disk paths relative
+ 	 to <path>.
  
       list [domain...]


6. Resources and Schedule
    6.4. Steering Committee requested information
   	6.4.1. Consolidation C-team Name:
		ON
    6.5. ARC review type: FastTrack
    6.6. ARC Exposure: open





From rich.teer@rite-group.com Mon Sep 15 14:15:49 2008
Received: from newsunmail1brm.central.sun.com (newsunmail1brm.Central.Sun.COM [129.147.62.245])
	by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id m8FLFkN5013052
	for <psarc-ext@sac.sfbay.sun.com>; Mon, 15 Sep 2008 14:15:49 -0700 (PDT)
Received: from nwk-avmta-1.SFBay.Sun.COM (nwk-avmta-1.SFBay.Sun.COM [129.146.11.74])
	by newsunmail1brm.central.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id m8FLFj2H058684;
	Mon, 15 Sep 2008 15:15:46 -0600 (MDT)
Received: from pmxchannel-daemon.nwk-avmta-1.sfbay.Sun.COM by
 nwk-avmta-1.sfbay.Sun.COM
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 id <0K7900G019Q9W300@nwk-avmta-1.sfbay.Sun.COM>; Mon,
 15 Sep 2008 14:15:45 -0700 (PDT)
Received: from brmea-mail-4.sun.com ([192.18.98.36])
 by nwk-avmta-1.sfbay.Sun.COM
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 with ESMTP id <0K7900FQT9Q9KN10@nwk-avmta-1.sfbay.Sun.COM>; Mon,
 15 Sep 2008 14:15:45 -0700 (PDT)
Received: from relay15i.sun.com
 (ip125.net129179-4.block1.us.syntegra.com [129.179.4.125])
	by brmea-mail-4.sun.com (8.13.6+Sun/8.12.9) with ESMTP id m8FLEYfc002085; Mon,
 15 Sep 2008 21:15:44 +0000 (GMT)
Received: from mmp11es.mmp.us.syntegra.com ([160.41.208.11] [160.41.208.11])
 by relay15i.sun.com with ESMTP id BT-MMP-1196578; Mon,
 15 Sep 2008 21:15:44 +0000 (Z)
Received: from relay18i.sun.com (relay18i.sun.com [129.179.4.128])
 by mmp11es.mmp.us.syntegra.com with ESMTP id BT-MMP-8719106; Mon,
 15 Sep 2008 21:15:43 +0000 (Z)
Received: from idcmail-mo1so.shaw.ca ([24.71.223.10] [24.71.223.10])
 by relay1i.sun.com with ESMTP id BT-MMP-13278346; Mon,
 15 Sep 2008 21:15:43 +0000 (Z)
Received: from pd4ml1so-ssvc.prod.shaw.ca ([10.0.141.141])
 by pd3mo1so-svcs.prod.shaw.ca with ESMTP; Mon, 15 Sep 2008 15:15:42 -0600
Received: from s0106080020b2d64f.ok.shawcable.net (HELO mail.rite-group.com)
 ([24.67.92.163]) by pd4ml1so-dmz.prod.shaw.ca with ESMTP; Mon,
 15 Sep 2008 15:15:42 -0600
Received: from marrakesh (marrakesh.rite-group.com [192.168.0.2])
	by mail.rite-group.com (8.14.3+Sun/8.14.3) with ESMTP id m8FLFAPb025367; Mon,
 15 Sep 2008 14:15:39 -0700 (PDT)
Date: Mon, 15 Sep 2008 14:10:48 -0700 (PDT)
From: Rich Teer <rich.teer@rite-group.com>
Subject: Re: [xen-discuss] Libvirt APIs for relative paths [PSARC/2008/577
 FastTrack timeout 09/22/2008]
In-reply-to: <48CECD54.4090902@Sun.COM>
X-X-Sender: rich@marrakesh
To: Huay-Yong Wang <Huay-Yong.Wang@sun.com>
Cc: psarc-ext@sun.com, xen-discuss@opensolaris.org, Ryan.Scott@sun.com
Message-id: <Pine.SOL.4.64.0809151408470.10949@marrakesh>
MIME-version: 1.0
Content-type: TEXT/PLAIN; charset=US-ASCII
Content-transfer-encoding: 7BIT
X-PMX-Version: 5.4.1.325704
X-Brightmail-Tracker: AAAAAA==
X-Cloudmark-SP-Filtered: true
X-Cloudmark-SP-Result: v=1.0 c=0 a=tXt9WMlhAAAA:8 a=jU4qhlNgAAAA:8
 a=wwmIQmqLAAAA:8 a=HUIPD1GfdA_rwum3uGAA:9 a=tiEu8l-4dJmOIxXMXUw-wpq8Um8A:4
 a=gC84ToOMuIUA:10 a=H1KEH7xhmqUA:10
X-Antispam: No, score=0.0/5.0, scanned in 0.331sec at (localhost [127.0.0.1])
	by smf-spamd v1.3.1 - http://smfs.sf.net/
References: <48CECD54.4090902@Sun.COM>
Status: RO
Content-Length: 840

On Mon, 15 Sep 2008, Huay-Yong Wang wrote:

> 3. Library Interfaces
> 
> char *virDomainGetRelativeXMLDesc(virDomainPtr domain, int flags,
> 	const char *relPath);
> 
> Similar to virDomainGetXMLDesc(), except with a new relPath argument.  All
> disk descriptions in the XML will be relative to this path.
> 
> virDomainPtr virDomainDefineRelativeXML(virConnectPtr conn, const char *xml,
> 	const char *relPath);

A great idea, but can we put a stop to function names with mixed
case identifiers, please?  Let's stick with all lower case with
underscores between "words".  I'm probably too late for this type
of comment, but it doesn't hurt to try...

-- 
Rich Teer, SCSA, SCNA, SCSECA

CEO,
My Online Home Inventory

URLs: http://www.rite-group.com/rich
      http://www.linkedin.com/in/richteer
      http://www.myonlinehomeinventory.com

From Ryan.Scott@Sun.COM Mon Sep 15 14:22:49 2008
Received: from sunmail5.uk.sun.com (sunmail5.UK.Sun.COM [129.156.85.165])
	by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id m8FLMmI4013290
	for <psarc-ext@sac.sfbay.sun.com>; Mon, 15 Sep 2008 14:22:49 -0700 (PDT)
Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6])
	by sunmail5.uk.sun.com (8.13.8+Sun/8.13.8/ENSMAIL,v2.2) with ESMTP id m8FLMl2s019234
	for <@sunmail2sca.sfbay.sun.com:psarc-ext@sun.com>; Mon, 15 Sep 2008 22:22:47 +0100 (BST)
Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by
 nwk-avmta-2.sfbay.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 id <0K7900A01A1Y5R00@nwk-avmta-2.sfbay.sun.com> for psarc-ext@sun.com
 (ORCPT psarc-ext@sun.com); Mon, 15 Sep 2008 14:22:46 -0700 (PDT)
Received: from sca-es-mail-1.sun.com ([192.18.43.132])
 by nwk-avmta-2.sfbay.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 with ESMTP id <0K790056QA1Y0WB0@nwk-avmta-2.sfbay.sun.com> for
 psarc-ext@sun.com (ORCPT psarc-ext@sun.com); Mon,
 15 Sep 2008 14:22:46 -0700 (PDT)
Received: from fe-sfbay-09.sun.com ([192.18.43.129])
	by sca-es-mail-1.sun.com (8.13.7+Sun/8.12.9) with ESMTP id m8FLMkVH008861	for
 <psarc-ext@sun.com>; Mon, 15 Sep 2008 14:22:46 -0700 (PDT)
Received: from conversion-daemon.fe-sfbay-09.sun.com by fe-sfbay-09.sun.com
 (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007))
 id <0K79002019RLPP00@fe-sfbay-09.sun.com>
 (original mail from Ryan.Scott@Sun.COM)
 for psarc-ext@sun.com (ORCPT psarc-ext@sun.com); Mon,
 15 Sep 2008 14:22:46 -0700 (PDT)
Received: from [129.153.88.128] by fe-sfbay-09.sun.com
 (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007))
 with ESMTPSA id <0K7900403A1RVKG0@fe-sfbay-09.sun.com> for psarc-ext@sun.com
 (ORCPT psarc-ext@sun.com); Mon, 15 Sep 2008 14:22:39 -0700 (PDT)
Date: Mon, 15 Sep 2008 14:22:56 -0700
From: Ryan Scott <Ryan.Scott@Sun.COM>
Subject: Re: [xen-discuss] Libvirt APIs for relative paths [PSARC/2008/577
 FastTrack timeout 09/22/2008]
In-reply-to: <Pine.SOL.4.64.0809151408470.10949@marrakesh>
Sender: Ryan.Scott@Sun.COM
To: Rich Teer <rich.teer@rite-group.com>
Cc: Huay-Yong Wang <Huay-Yong.Wang@Sun.COM>, psarc-ext@Sun.COM,
        xen-discuss@opensolaris.org
Message-id: <48CED230.3060201@Sun.COM>
MIME-version: 1.0
Content-type: text/plain; format=flowed; charset=ISO-8859-1
Content-transfer-encoding: 7BIT
X-PMX-Version: 5.4.1.325704
References: <48CECD54.4090902@Sun.COM>
 <Pine.SOL.4.64.0809151408470.10949@marrakesh>
User-Agent: Thunderbird 2.0.0.17pre (X11/20080727)
Status: RO
Content-Length: 842

Rich Teer wrote:
> On Mon, 15 Sep 2008, Huay-Yong Wang wrote:
> 
>> 3. Library Interfaces
>>
>> char *virDomainGetRelativeXMLDesc(virDomainPtr domain, int flags,
>> 	const char *relPath);
>>
>> Similar to virDomainGetXMLDesc(), except with a new relPath argument.  All
>> disk descriptions in the XML will be relative to this path.
>>
>> virDomainPtr virDomainDefineRelativeXML(virConnectPtr conn, const char *xml,
>> 	const char *relPath);
> 
> A great idea, but can we put a stop to function names with mixed
> case identifiers, please?  Let's stick with all lower case with
> underscores between "words".  I'm probably too late for this type
> of comment, but it doesn't hurt to try...

We want to keep the naming convention consistent in libvirt, and we 
inherited the rest from upstream, so it can't be changed in this case.

-Ryan

> 


From Huay-Yong.Wang@sun.com Tue Sep 23 11:18:43 2008
Received: from sunmail4.singapore.sun.com (sunmail4.Singapore.Sun.COM [129.158.71.19])
	by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id m8NIIgar012414
	for <psarc-ext@sac.sfbay.Sun.COM>; Tue, 23 Sep 2008 11:18:43 -0700 (PDT)
Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6])
	by sunmail4.singapore.sun.com (8.13.4+Sun/8.13.3/ENSMAIL,v2.2) with ESMTP id m8NIIdk8027090
	for <@sunmail2sca.sfbay.sun.com:psarc-ext@sun.com>; Wed, 24 Sep 2008 02:18:41 +0800 (SGT)
Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by
 nwk-avmta-2.sfbay.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 id <0K7N00503UV5RY00@nwk-avmta-2.sfbay.sun.com> for psarc-ext@sun.com
 (ORCPT psarc-ext@sun.com); Tue, 23 Sep 2008 11:18:41 -0700 (PDT)
Received: from sca-es-mail-1.sun.com ([192.18.43.132])
 by nwk-avmta-2.sfbay.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 with ESMTP id <0K7N002P6UV4W680@nwk-avmta-2.sfbay.sun.com> for
 psarc-ext@sun.com (ORCPT psarc-ext@sun.com); Tue,
 23 Sep 2008 11:18:40 -0700 (PDT)
Received: from fe-sfbay-09.sun.com ([192.18.43.129])
	by sca-es-mail-1.sun.com (8.13.7+Sun/8.12.9) with ESMTP id m8NIIepT007764	for
 <psarc-ext@sun.com>; Tue, 23 Sep 2008 11:18:40 -0700 (PDT)
Received: from conversion-daemon.fe-sfbay-09.sun.com by fe-sfbay-09.sun.com
 (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007))
 id <0K7N00701TW6PP00@fe-sfbay-09.sun.com>
 (original mail from Huay-Yong.Wang@Sun.COM)
 for psarc-ext@sun.com (ORCPT psarc-ext@sun.com); Tue,
 23 Sep 2008 11:18:40 -0700 (PDT)
Received: from [129.153.85.10] by fe-sfbay-09.sun.com
 (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007))
 with ESMTPSA id <0K7N001EWUV3PKE0@fe-sfbay-09.sun.com> for psarc-ext@sun.com
 (ORCPT psarc-ext@sun.com); Tue, 23 Sep 2008 11:18:39 -0700 (PDT)
Date: Tue, 23 Sep 2008 11:18:38 -0700
From: Huay-Yong Wang <Huay-Yong.Wang@sun.com>
Subject: Re: Libvirt APIs for relative paths [PSARC/2008/577 FastTrack timeout
 09/22/2008]
In-reply-to: <48CECD54.4090902@Sun.COM>
Sender: Huay-Yong.Wang@sun.com
To: psarc-ext@sun.com
Cc: Ryan.Scott@sun.com, xen-discuss@opensolaris.org
Reply-to: Huay-Yong.Wang@sun.com
Message-id: <48D932FE.80600@Sun.COM>
MIME-version: 1.0
Content-type: text/plain; format=flowed; charset=ISO-8859-1
Content-transfer-encoding: 7BIT
X-Accept-Language: en-us, en
X-PMX-Version: 5.4.1.325704
References: <48CECD54.4090902@Sun.COM>
User-Agent: Mozilla Thunderbird 0.8 (X11/20040917)
Status: RO
Content-Length: 90


The timer  for this case has expired.
I am marking this fasttrack closed and approved.



From Kais.Belgaied@sun.com Tue Sep 23 19:26:18 2008
Received: from newsunmail1brm.central.sun.com (newsunmail1brm.Central.Sun.COM [129.147.62.245])
	by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id m8O2QHAW024984
	for <psarc-ext@sac.sfbay.sun.com>; Tue, 23 Sep 2008 19:26:18 -0700 (PDT)
Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6])
	by newsunmail1brm.central.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id m8O2QG5M027378;
	Tue, 23 Sep 2008 20:26:17 -0600 (MDT)
Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by
 nwk-avmta-2.sfbay.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 id <0K7O0040JHFSZ400@nwk-avmta-2.sfbay.sun.com>; Tue,
 23 Sep 2008 19:26:16 -0700 (PDT)
Received: from jurassic-x4600.sfbay.sun.com ([129.146.17.63])
 by nwk-avmta-2.sfbay.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 with ESMTP id <0K7O00BDEHFROWE0@nwk-avmta-2.sfbay.sun.com>; Tue,
 23 Sep 2008 19:26:15 -0700 (PDT)
Received: from [129.146.11.144]
 (sr1-jurassic-01.SFBay.Sun.COM [129.146.11.144])	by
 jurassic-x4600.sfbay.sun.com (8.14.3+Sun/8.14.3) with ESMTP id m8O2PZ0W848364;
 Tue, 23 Sep 2008 19:25:41 -0700 (PDT)
Date: Tue, 23 Sep 2008 19:25:35 -0700
From: Kais Belgaied <Kais.Belgaied@sun.com>
Subject: Re: [xen-discuss] Libvirt APIs for relative paths [PSARC/2008/577
 FastTrack timeout 09/22/2008]
In-reply-to: <48CED230.3060201@Sun.COM>
To: Ryan Scott <Ryan.Scott@sun.com>
Cc: Rich Teer <rich.teer@rite-group.com>, psarc-ext@sun.com,
        xen-discuss@opensolaris.org, Huay-Yong Wang <Huay-Yong.Wang@sun.com>
Reply-to: Kais.Belgaied@sun.com
Message-id: <48D9A51F.3010401@Sun.COM>
MIME-version: 1.0
Content-type: multipart/alternative;
 boundary="Boundary_(ID_S5G5Z46+cLVAox6ZKHN7ww)"
X-PMX-Version: 5.4.1.325704
References: <48CECD54.4090902@Sun.COM>
 <Pine.SOL.4.64.0809151408470.10949@marrakesh> <48CED230.3060201@Sun.COM>
User-Agent: Thunderbird 2.0.0.14 (X11/20080505)
Status: RO
Content-Length: 3280

This is a multi-part message in MIME format.

--Boundary_(ID_S5G5Z46+cLVAox6ZKHN7ww)
Content-type: text/plain; charset=ISO-8859-1; format=flowed
Content-transfer-encoding: 7BIT

On 09/15/08 14:22, Ryan Scott wrote:
> Rich Teer wrote:
>   
>> On Mon, 15 Sep 2008, Huay-Yong Wang wrote:
>>
>>     
>>> 3. Library Interfaces
>>>
>>> char *virDomainGetRelativeXMLDesc(virDomainPtr domain, int flags,
>>> 	const char *relPath);
>>>
>>> Similar to virDomainGetXMLDesc(), except with a new relPath argument.  All
>>> disk descriptions in the XML will be relative to this path.
>>>
>>> virDomainPtr virDomainDefineRelativeXML(virConnectPtr conn, const char *xml,
>>> 	const char *relPath);
>>>       
>> A great idea, but can we put a stop to function names with mixed
>> case identifiers, please?  Let's stick with all lower case with
>> underscores between "words".  I'm probably too late for this type
>> of comment, but it doesn't hurt to try...
>>     
>
> We want to keep the naming convention consistent in libvirt, and we 
> inherited the rest from upstream, so it can't be changed in this case.
>   

yep.
When in Rome do what Romans don.

BTW, this is my +1 for this case.

    Kais
> -Ryan
>
>   
>
> _______________________________________________
> xen-discuss mailing list
> xen-discuss@opensolaris.org
>
>   


--Boundary_(ID_S5G5Z46+cLVAox6ZKHN7ww)
Content-type: text/html; charset=ISO-8859-1
Content-transfer-encoding: 7BIT

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
  <meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 09/15/08 14:22, Ryan Scott wrote:
<blockquote cite="mid:48CED230.3060201@Sun.COM" type="cite">
  <pre wrap="">Rich Teer wrote:
  </pre>
  <blockquote type="cite">
    <pre wrap="">On Mon, 15 Sep 2008, Huay-Yong Wang wrote:

    </pre>
    <blockquote type="cite">
      <pre wrap="">3. Library Interfaces

char *virDomainGetRelativeXMLDesc(virDomainPtr domain, int flags,
	const char *relPath);

Similar to virDomainGetXMLDesc(), except with a new relPath argument.  All
disk descriptions in the XML will be relative to this path.

virDomainPtr virDomainDefineRelativeXML(virConnectPtr conn, const char *xml,
	const char *relPath);
      </pre>
    </blockquote>
    <pre wrap="">A great idea, but can we put a stop to function names with mixed
case identifiers, please?  Let's stick with all lower case with
underscores between "words".  I'm probably too late for this type
of comment, but it doesn't hurt to try...
    </pre>
  </blockquote>
  <pre wrap=""><!---->
We want to keep the naming convention consistent in libvirt, and we 
inherited the rest from upstream, so it can't be changed in this case.
  </pre>
</blockquote>
<br>
yep.<br>
When in Rome do what Romans don.<br>
<br>
BTW, this is my +1 for this case.<br>
<br>
&nbsp;&nbsp;&nbsp; Kais<br>
<blockquote cite="mid:48CED230.3060201@Sun.COM" type="cite">
  <pre wrap="">
-Ryan

  </pre>
  <pre wrap=""><!---->
_______________________________________________
xen-discuss mailing list
<a class="moz-txt-link-abbreviated" href="mailto:xen-discuss@opensolaris.org">xen-discuss@opensolaris.org</a>

  </pre>
</blockquote>
<br>
</body>
</html>

--Boundary_(ID_S5G5Z46+cLVAox6ZKHN7ww)--