From sacadmin Thu Sep 18 01:56:00 2008
Received: from sac.sfbay.sun.com (localhost [127.0.0.1])
	by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id m8I8u0nT005052;
	Thu, 18 Sep 2008 01:56:00 -0700 (PDT)
Received: (from xc149992@localhost)
	by sac.sfbay.sun.com (8.13.8+Sun/8.13.8/Submit) id m8I8u0dT005048;
	Thu, 18 Sep 2008 01:56:00 -0700 (PDT)
Date: Thu, 18 Sep 2008 01:56:00 -0700 (PDT)
From: Xiang-Dong Frank Che <xc149992@sac.sfbay.sun.com>
Message-Id: <200809180856.m8I8u0dT005048@sac.sfbay.sun.com>
To: PSARC-record@sac.sfbay.sun.com
Subject: PCI Device Detection on FreeBSD [PSARC/2008/591 Self Review]
Status: RO
Content-Length: 561


Template Version: @(#)sac_nextcase %I% %G% SMI
This information is Copyright 2008 Sun Microsystems
1. Introduction
    1.1. Project/Component Working Name:
	 PCI Device Detection on FreeBSD
    1.2. Name of Document Author/Supplier:
	 Author:  Ye Li
    1.3  Date of This Document:
	18 September, 2008
4. Technical Description
    See the case directory for more detail

6. Resources and Schedule
    6.4. Steering Committee requested information
   	6.4.1. Consolidation C-team Name:
		unknown
    6.5. ARC review type: Automatic
    6.6. ARC Exposure: open


From Frank.Che@sun.com Thu Sep 18 02:12:04 2008
Received: from sunmail4.singapore.sun.com (sunmail4.Singapore.Sun.COM [129.158.71.19])
	by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id m8I9C3hq005286
	for <psarc-ext@sac.sfbay.Sun.COM>; Thu, 18 Sep 2008 02:12:03 -0700 (PDT)
Received: from nwk-avmta-1.SFBay.Sun.COM (nwk-avmta-1.SFBay.Sun.COM [129.146.11.74])
	by sunmail4.singapore.sun.com (8.13.4+Sun/8.13.3/ENSMAIL,v2.2) with ESMTP id m8I9BnaJ001916
	for <@sunmail2sca.sfbay.sun.com:PSARC-ext@sun.com>; Thu, 18 Sep 2008 17:12:02 +0800 (SGT)
Received: from pmxchannel-daemon.nwk-avmta-1.sfbay.Sun.COM by
 nwk-avmta-1.sfbay.Sun.COM
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 id <0K7D00J09W814Z00@nwk-avmta-1.sfbay.Sun.COM> for PSARC-ext@sun.com
 (ORCPT PSARC-ext@sun.com); Thu, 18 Sep 2008 02:12:01 -0700 (PDT)
Received: from sineb-mail-1.sun.com ([192.18.19.6])
 by nwk-avmta-1.sfbay.Sun.COM
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 with ESMTP id <0K7D00ITQW802H00@nwk-avmta-1.sfbay.Sun.COM> for
 PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Thu,
 18 Sep 2008 02:12:01 -0700 (PDT)
Received: from fe-apac-05.sun.com
 (fe-apac-05.sun.com [192.18.19.176] (may be forged))
	by sineb-mail-1.sun.com (8.13.6+Sun/8.12.9) with ESMTP id m8I9C0k8018001	for
 <PSARC-ext@sun.com>; Thu, 18 Sep 2008 09:12:00 +0000 (GMT)
Received: from conversion-daemon.mail-apac.sun.com by mail-apac.sun.com
 (Sun Java System Messaging Server 6.2-6.01 (built Apr  3 2006))
 id <0K7D00E01W5NBZ00@mail-apac.sun.com> (original mail from Frank.Che@Sun.COM)
 for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Thu,
 18 Sep 2008 17:11:59 +0800 (SGT)
Received: from [129.158.218.60] by mail-apac.sun.com
 (Sun Java System Messaging Server 6.2-6.01 (built Apr  3 2006))
 with ESMTPSA id <0K7D00MN8W7ZLRUD@mail-apac.sun.com> for PSARC-ext@sun.com
 (ORCPT PSARC-ext@sun.com); Thu, 18 Sep 2008 17:11:59 +0800 (SGT)
Date: Thu, 18 Sep 2008 17:11:12 +0800
From: Frank Che <Frank.Che@sun.com>
Subject: PSARC 2008/591 PCI Device Detection on FreeBSD
Sender: Frank.Che@sun.com
To: PSARC-ext@sun.com
Cc: Li Ye <Ye.Li@sun.com>
Message-id: <48D21B30.1090100@sun.com>
MIME-version: 1.0
Content-type: text/plain; format=flowed; charset=ISO-8859-1
Content-transfer-encoding: 7BIT
X-PMX-Version: 5.4.1.325704
User-Agent: Thunderbird 2.0.0.4 (X11/20070622)
Status: RO
Content-Length: 1928

I'm sponsoring this case for Ye Li. This case is to make a minor update 
to the Amaranth project to support PCI device detection on FreeBSD. It
requests a minor release binding to the Sun Device Detection Tool product.

I have marked it as "closed approved automatic" since the change is 
straightforward and the interface is clear.

Frank

4. Technical Description:

    4.1 Background

      The Sun Device Detection Tool product is described in
      PSARC 2007/320 [1] and PSARC 2008/185[2]. It collects device
      information through OS API on Solaris, Linux, Windows and
      Mac OS; compares the collected data with a driver database
      to determine whether there is a Solaris driver available
      for the device; and generates a report finally.

    4.2 Proposal

      This project is to extend the OS coverage of the Sun Device
      Detection Tool product to include FreeBSD system, so that FreeBSD
      users could easily know whether PCI devices in their system have
      drivers in Solaris OS.

      On FreeBSD, PCI device information could be retrieved from
      system file /dev/pci through ioctl command PCIOCREAD.

    4.5 Interfaces

    Interfaces Imported:

    ------------------------------------------------------------------
    | OS Type | Interface     | Purpose                              |
    ------------------------------------------------------------------
    | FreeBSD | /dev/pci      | Scan file /dev/pci to read PCI       |
    |         | PCIOCREAD     | device data                          |
    ------------------------------------------------------------------

6. Resources and Schedule:

    6.4 Steering Committee requested information

        6.4.1. Consolidation C-team Name: None

    6.5 ARC review type: Self Review
    6.6 ARC exposure: open


A. Reference

   [1] PSARC 2007/320: Amaranth (VVV2 update)
   [2] PSARC 2008/185: PCI Device Detection on Mac OS X



From ceri@submonkey.net Thu Sep 18 02:52:12 2008
Received: from newsunmail1brm.central.sun.com (newsunmail1brm.Central.Sun.COM [129.147.62.245])
	by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id m8I9qB07005950
	for <psarc-ext@sac.sfbay.sun.com>; Thu, 18 Sep 2008 02:52:12 -0700 (PDT)
Received: from nwk-avmta-1.SFBay.Sun.COM (nwk-avmta-1.SFBay.Sun.COM [129.146.11.74])
	by newsunmail1brm.central.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id m8I9qA7E005700
	for <@sunmail2sca.sfbay.sun.com:PSARC-ext@sun.com>; Thu, 18 Sep 2008 03:52:11 -0600 (MDT)
Received: from pmxchannel-daemon.nwk-avmta-1.sfbay.Sun.COM by
 nwk-avmta-1.sfbay.Sun.COM
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 id <0K7D0000FY2Y5N00@nwk-avmta-1.sfbay.Sun.COM> for PSARC-ext@sun.com
 (ORCPT PSARC-ext@sun.com); Thu, 18 Sep 2008 02:52:10 -0700 (PDT)
Received: from brmea-mail-4.sun.com ([192.18.98.36])
 by nwk-avmta-1.sfbay.Sun.COM
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 with ESMTP id <0K7D00IKPY2X2S30@nwk-avmta-1.sfbay.Sun.COM> for
 PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Thu,
 18 Sep 2008 02:52:10 -0700 (PDT)
Received: from relay21.sun.com
 (relay21.sun.com [192.12.251.24] (may be forged))	by brmea-mail-4.sun.com
 (8.13.6+Sun/8.12.9) with ESMTP id m8I9pNcU015245	for <PSARC-ext@sun.com>; Thu,
 18 Sep 2008 09:52:09 +0000 (GMT)
Received: from mms23es.mms.us.syntegra.com ([150.143.232.50] [150.143.232.50])
 by relay21i.sun.com with ESMTP id BT-MMP-3840215 for PSARC-ext@sun.com; Thu,
 18 Sep 2008 09:52:09 +0000 (Z)
Received: from relay23.sun.com (relay23.sun.com [192.12.251.54])
 by mms23es.mms.us.syntegra.com with ESMTP id BT-MMP-125128490 for
 PSARC-ext@sun.com; Thu, 18 Sep 2008 09:52:09 +0000 (Z)
Received: from shrike.submonkey.net ([81.104.164.64] [81.104.164.64])
 by relay23i.sun.com with ESMTP id BT-MMP-7554685 for PSARC-ext@sun.com; Thu,
 18 Sep 2008 09:52:08 +0000 (Z)
Received: from ceri by shrike.submonkey.net with local (Exim 4.69 (FreeBSD))
	(envelope-from <ceri@submonkey.net>)	id 1KgGBC-000Gns-H9; Thu,
 18 Sep 2008 10:52:06 +0100
Date: Thu, 18 Sep 2008 10:52:06 +0100
From: Ceri Davies <ceri@submonkey.net>
Subject: Re: PSARC 2008/591 PCI Device Detection on FreeBSD
In-reply-to: <48D21B30.1090100@sun.com>
Sender: Ceri Davies <ceri@submonkey.net>
To: Frank Che <Frank.Che@sun.com>
Cc: PSARC-ext@sun.com, Li Ye <Ye.Li@sun.com>
Message-id: <20080918095206.GB47882@submonkey.net>
MIME-version: 1.0
Content-type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="TB36FDmn/VVEgNH/"
Content-disposition: inline
X-PMX-Version: 5.4.1.325704
X-Brightmail-Tracker: AAAAAA==
X-PGP: finger ceri@FreeBSD.org
X-Antispam: No, score=0.0/5.0, scanned in 0.088sec at (localhost [127.0.0.1])
	by smf-spamd v1.3.1 - http://smfs.sf.net/
References: <48D21B30.1090100@sun.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Status: RO
Content-Length: 1501


--TB36FDmn/VVEgNH/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 18, 2008 at 05:11:12PM +0800, Frank Che wrote:
> I'm sponsoring this case for Ye Li. This case is to make a minor update=
=20
> to the Amaranth project to support PCI device detection on FreeBSD. It
> requests a minor release binding to the Sun Device Detection Tool product.
>=20
> I have marked it as "closed approved automatic" since the change is=20
> straightforward and the interface is clear.


>     Interfaces Imported:
>=20
>     ------------------------------------------------------------------
>     | OS Type | Interface     | Purpose                              |
>     ------------------------------------------------------------------
>     | FreeBSD | /dev/pci      | Scan file /dev/pci to read PCI       |
>     |         | PCIOCREAD     | device data                          |
>     ------------------------------------------------------------------

FWIW, I think you'll need to use PCIOGETCONF as well.

Ceri
--=20
That must be wonderful!  I don't understand it at all.
                                                  -- Moliere

--TB36FDmn/VVEgNH/
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (FreeBSD)

iD8DBQFI0iTGocfcwTS3JF8RAieUAKDI40yS5b9myCyQd0kg2ZGOMcmtDwCggjpi
voEITN7TX2aRfxYpk6ktu4k=
=Wrxp
-----END PGP SIGNATURE-----

--TB36FDmn/VVEgNH/--

From gdamore@Sun.COM Thu Sep 18 08:13:18 2008
Received: from sunmail2sca.sfbay.sun.com (sunmail2sca.SFBay.Sun.COM [129.145.155.234])
	by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id m8IFDIx7012450
	for <psarc-ext@sac.sfbay.sun.com>; Thu, 18 Sep 2008 08:13:18 -0700 (PDT)
Received: from nwk-avmta-1.SFBay.Sun.COM (nwk-avmta-1.SFBay.Sun.COM [129.146.11.74])
	by sunmail2sca.sfbay.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id m8IFDHux023718
	for <@sunmail2sca.sfbay.sun.com:PSARC-ext@sun.com>; Thu, 18 Sep 2008 08:13:18 -0700 (PDT)
Received: from pmxchannel-daemon.nwk-avmta-1.sfbay.Sun.COM by
 nwk-avmta-1.sfbay.Sun.COM
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 id <0K7E00A1BCY5GH00@nwk-avmta-1.sfbay.Sun.COM> for PSARC-ext@sun.com
 (ORCPT PSARC-ext@sun.com); Thu, 18 Sep 2008 08:13:17 -0700 (PDT)
Received: from sca-es-mail-2.sun.com ([192.18.43.133])
 by nwk-avmta-1.sfbay.Sun.COM
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 with ESMTP id <0K7E007HMCY3B060@nwk-avmta-1.sfbay.Sun.COM> for
 PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Thu,
 18 Sep 2008 08:13:17 -0700 (PDT)
Received: from fe-sfbay-10.sun.com ([192.18.43.129])
	by sca-es-mail-2.sun.com (8.13.7+Sun/8.12.9) with ESMTP id m8IFDFa3016881	for
 <PSARC-ext@sun.com>; Thu, 18 Sep 2008 08:13:15 -0700 (PDT)
Received: from conversion-daemon.fe-sfbay-10.sun.com by fe-sfbay-10.sun.com
 (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007))
 id <0K7E00A01CKLZM00@fe-sfbay-10.sun.com> (original mail from gdamore@sun.com)
 for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Thu,
 18 Sep 2008 08:13:14 -0700 (PDT)
Received: from [10.7.251.172] by fe-sfbay-10.sun.com
 (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007))
 with ESMTPSA id <0K7E008IZCXA6C40@fe-sfbay-10.sun.com> for PSARC-ext@sun.com
 (ORCPT PSARC-ext@sun.com); Thu, 18 Sep 2008 08:12:47 -0700 (PDT)
Date: Thu, 18 Sep 2008 08:11:01 -0700
From: "Garrett D'Amore" <gdamore@Sun.COM>
Subject: Re: PSARC 2008/591 PCI Device Detection on FreeBSD
In-reply-to: <20080918095206.GB47882@submonkey.net>
Sender: Garrett.Damore@Sun.COM
To: Ceri Davies <ceri@submonkey.net>
Cc: Frank Che <Frank.Che@Sun.COM>, PSARC-ext@Sun.COM, Li Ye <Ye.Li@Sun.COM>
Message-id: <48D26F85.8030306@sun.com>
MIME-version: 1.0
Content-type: text/plain; format=flowed; charset=ISO-8859-1
Content-transfer-encoding: 7BIT
X-PMX-Version: 5.4.1.325704
References: <48D21B30.1090100@sun.com> <20080918095206.GB47882@submonkey.net>
User-Agent: Thunderbird 2.0.0.14 (X11/20080616)
Status: RO
Content-Length: 1485

Ceri Davies wrote:
> On Thu, Sep 18, 2008 at 05:11:12PM +0800, Frank Che wrote:
>   
>> I'm sponsoring this case for Ye Li. This case is to make a minor update 
>> to the Amaranth project to support PCI device detection on FreeBSD. It
>> requests a minor release binding to the Sun Device Detection Tool product.
>>
>> I have marked it as "closed approved automatic" since the change is 
>> straightforward and the interface is clear.
>>     
>
>
>   
>>     Interfaces Imported:
>>
>>     ------------------------------------------------------------------
>>     | OS Type | Interface     | Purpose                              |
>>     ------------------------------------------------------------------
>>     | FreeBSD | /dev/pci      | Scan file /dev/pci to read PCI       |
>>     |         | PCIOCREAD     | device data                          |
>>     ------------------------------------------------------------------
>>     
>
> FWIW, I think you'll need to use PCIOGETCONF as well.
>   

I realize that FreeBSD doesn't use the same interface stability levels, 
but are the PCI ioctls morally "public" (preferably documented in man 
page)?  (I.e. I want to make sure that we aren't using some kind of 
internal-use-only API that could change at the drop of the hat.  I don't 
think we are, but I'd like it to be explicit in the case materials.

Assuming no surprises there, then I'd agree that the case falls into the 
automatic-approval bucket.

    -- Garrett
> Ceri
>   


From Sebastien.Roy@sun.com Thu Sep 18 08:24:55 2008
Received: from sunmail4.singapore.sun.com (sunmail4.Singapore.Sun.COM [129.158.71.19])
	by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id m8IFOsDw012626
	for <psarc-ext@sac.sfbay.Sun.COM>; Thu, 18 Sep 2008 08:24:55 -0700 (PDT)
Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6])
	by sunmail4.singapore.sun.com (8.13.4+Sun/8.13.3/ENSMAIL,v2.2) with ESMTP id m8IFOqZS004728
	for <@sunmail2sca.sfbay.sun.com:PSARC-ext@sun.com>; Thu, 18 Sep 2008 23:24:54 +0800 (SGT)
Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by
 nwk-avmta-2.sfbay.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 id <0K7E0000FDHF5200@nwk-avmta-2.sfbay.sun.com> for PSARC-ext@sun.com
 (ORCPT PSARC-ext@sun.com); Thu, 18 Sep 2008 08:24:51 -0700 (PDT)
Received: from brmea-mail-2.sun.com ([192.18.98.43])
 by nwk-avmta-2.sfbay.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 with ESMTP id <0K7E00NDYDHE1I00@nwk-avmta-2.sfbay.sun.com> for
 PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Thu,
 18 Sep 2008 08:24:51 -0700 (PDT)
Received: from fe-amer-10.sun.com ([192.18.109.80])
	by brmea-mail-2.sun.com (8.13.6+Sun/8.12.9) with ESMTP id m8IFOoX1009661	for
 <PSARC-ext@sun.com>; Thu, 18 Sep 2008 15:24:50 +0000 (GMT)
Received: from conversion-daemon.mail-amer.sun.com by mail-amer.sun.com
 (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007))
 id <0K7E00J01D5GEU00@mail-amer.sun.com>
 (original mail from Sebastien.Roy@Sun.COM)
 for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Thu,
 18 Sep 2008 09:24:50 -0600 (MDT)
Received: from [129.148.174.103] by mail-amer.sun.com
 (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007))
 with ESMTPSA id <0K7E0000JDH9Y4B0@mail-amer.sun.com> for PSARC-ext@sun.com
 (ORCPT PSARC-ext@sun.com); Thu, 18 Sep 2008 09:24:46 -0600 (MDT)
Date: Thu, 18 Sep 2008 11:24:45 -0400
From: Sebastien Roy <Sebastien.Roy@sun.com>
Subject: Re: PSARC 2008/591 PCI Device Detection on FreeBSD
In-reply-to: <48D26F85.8030306@sun.com>
Sender: Sebastien.Roy@sun.com
To: "Garrett D'Amore" <gdamore@sun.com>
Cc: Ceri Davies <ceri@submonkey.net>, PSARC-ext@sun.com, Li Ye <Ye.Li@sun.com>,
        Frank Che <Frank.Che@sun.com>
Message-id: <1221751485.6880.7.camel@strat>
Organization: Sun Microsystems
MIME-version: 1.0
X-Mailer: Evolution 2.22.2
Content-type: text/plain
Content-transfer-encoding: 7BIT
X-PMX-Version: 5.4.1.325704
References: <48D21B30.1090100@sun.com> <20080918095206.GB47882@submonkey.net>
 <48D26F85.8030306@sun.com>
Status: RO
Content-Length: 702

On Thu, 2008-09-18 at 08:11 -0700, Garrett D'Amore wrote:
> Ceri Davies wrote:
> >
> > FWIW, I think you'll need to use PCIOGETCONF as well.
> >   
> 
> I realize that FreeBSD doesn't use the same interface stability levels, 
> but are the PCI ioctls morally "public" (preferably documented in man 
> page)?  (I.e. I want to make sure that we aren't using some kind of 
> internal-use-only API that could change at the drop of the hat.  I don't 
> think we are, but I'd like it to be explicit in the case materials.

FWIW, it is (actually, PCIOCGETCONF is) documented in the FreeBSD pci(4)
man page:

http://www.freebsd.org/cgi/man.cgi?query=pci&sektion=4&apropos=0&manpath=FreeBSD+7.0-RELEASE

-Seb



From ceri@submonkey.net Thu Sep 18 08:36:17 2008
Received: from newsunmail1brm.central.sun.com (newsunmail1brm.Central.Sun.COM [129.147.62.245])
	by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id m8IFaHrT013044
	for <psarc-ext@sac.sfbay.sun.com>; Thu, 18 Sep 2008 08:36:17 -0700 (PDT)
Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6])
	by newsunmail1brm.central.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id m8IFa8Vw064349;
	Thu, 18 Sep 2008 09:36:14 -0600 (MDT)
Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by
 nwk-avmta-2.sfbay.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 id <0K7E0000TE0DIU00@nwk-avmta-2.sfbay.sun.com>; Thu,
 18 Sep 2008 08:36:14 -0700 (PDT)
Received: from sca-ea-mail-4.sun.com ([192.18.43.22])
 by nwk-avmta-2.sfbay.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 with ESMTP id <0K7E00N87E061F10@nwk-avmta-2.sfbay.sun.com>; Thu,
 18 Sep 2008 08:36:06 -0700 (PDT)
Received: from relay42i.sun.com ([192.5.209.72])
	by sca-ea-mail-4.sun.com (8.13.6+Sun/8.12.9) with ESMTP id m8IFa5iR029048;
 Thu, 18 Sep 2008 15:36:06 +0000 (GMT)
Received: from mms48es.mms.us.syntegra.com ([160.41.221.230] [160.41.221.230])
 by relay42i.sun.com with ESMTP id BT-MMP-751174; Thu,
 18 Sep 2008 15:36:05 +0000 (Z)
Received: from relay41i.sun.com (relay41i.sun.com [192.5.209.70])
 by mms48es.mms.us.syntegra.com with ESMTP id BT-MMP-52277715; Thu,
 18 Sep 2008 15:36:05 +0000 (Z)
Received: from shrike.submonkey.net ([81.104.164.64] [81.104.164.64])
 by relay4i.sun.com with ESMTP id BT-MMP-12693848; Thu,
 18 Sep 2008 15:36:04 +0000 (Z)
Received: from ceri by shrike.submonkey.net with local (Exim 4.69 (FreeBSD))
	(envelope-from <ceri@submonkey.net>)	id 1KgLT8-000Dru-Po; Thu,
 18 Sep 2008 16:30:58 +0100
Date: Thu, 18 Sep 2008 16:30:58 +0100
From: Ceri Davies <ceri@submonkey.net>
Subject: Re: PSARC 2008/591 PCI Device Detection on FreeBSD
In-reply-to: <48D26F85.8030306@sun.com>
Sender: Ceri Davies <ceri@submonkey.net>
To: "Garrett D'Amore" <gdamore@sun.com>
Cc: Frank Che <Frank.Che@sun.com>, PSARC-ext@sun.com, Li Ye <Ye.Li@sun.com>
Message-id: <20080918153058.GD47882@submonkey.net>
MIME-version: 1.0
Content-type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="oC1+HKm2/end4ao3"
Content-disposition: inline
X-PMX-Version: 5.4.1.325704
X-Brightmail-Tracker: AAAAAA==
X-PGP: finger ceri@FreeBSD.org
X-Antispam: No, score=0.0/5.0, scanned in 0.126sec at (localhost [127.0.0.1])
	by smf-spamd v1.3.1 - http://smfs.sf.net/
References: <48D21B30.1090100@sun.com> <20080918095206.GB47882@submonkey.net>
 <48D26F85.8030306@sun.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Status: RO
Content-Length: 2344


--oC1+HKm2/end4ao3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 18, 2008 at 08:11:01AM -0700, Garrett D'Amore wrote:
> Ceri Davies wrote:
> > On Thu, Sep 18, 2008 at 05:11:12PM +0800, Frank Che wrote:
> >  =20
> >> I'm sponsoring this case for Ye Li. This case is to make a minor updat=
e=20
> >> to the Amaranth project to support PCI device detection on FreeBSD. It
> >> requests a minor release binding to the Sun Device Detection Tool prod=
uct.
> >>
> >> I have marked it as "closed approved automatic" since the change is=20
> >> straightforward and the interface is clear.
> >>    =20
> >
> >
> >  =20
> >>     Interfaces Imported:
> >>
> >>     ------------------------------------------------------------------
> >>     | OS Type | Interface     | Purpose                              |
> >>     ------------------------------------------------------------------
> >>     | FreeBSD | /dev/pci      | Scan file /dev/pci to read PCI       |
> >>     |         | PCIOCREAD     | device data                          |
> >>     ------------------------------------------------------------------
> >>    =20
> >
> > FWIW, I think you'll need to use PCIOGETCONF as well.
> >  =20
>=20
> I realize that FreeBSD doesn't use the same interface stability levels,=
=20
> but are the PCI ioctls morally "public" (preferably documented in man=20
> page)?  (I.e. I want to make sure that we aren't using some kind of=20
> internal-use-only API that could change at the drop of the hat.  I don't=
=20
> think we are, but I'd like it to be explicit in the case materials.

They're documented in the pci(4) manpage, see
http://man.freebsd.org/pci/4, and absolutely intended for public
consumption.

It's been known (ok, quite common) for kernel API/ABI to break across
major releases, but I'm unaware of any planned work affecting this area.

Ceri
--=20
That must be wonderful!  I don't understand it at all.
                                                  -- Moliere

--oC1+HKm2/end4ao3
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (FreeBSD)

iD8DBQFI0nQyocfcwTS3JF8RAqQjAJ9Oww2NC+/GLvnLg2rSJcsZ4YBcZwCglaoc
kjXcwiP5qL5UsSi7YLCxpZ0=
=7c/E
-----END PGP SIGNATURE-----

--oC1+HKm2/end4ao3--

From gdamore@sun.com Thu Sep 18 08:37:56 2008
Received: from sunmail2sca.sfbay.sun.com (sunmail2sca.SFBay.Sun.COM [129.145.155.234])
	by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id m8IFbuOp013129
	for <psarc-ext@sac.sfbay.sun.com>; Thu, 18 Sep 2008 08:37:56 -0700 (PDT)
Received: from brm-avmta-1.central.sun.com (brm-avmta-1.Central.Sun.COM [129.147.4.11])
	by sunmail2sca.sfbay.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id m8IFblQQ003001
	for <@sunmail2sca.sfbay.sun.com:PSARC-ext@sun.com>; Thu, 18 Sep 2008 08:37:56 -0700 (PDT)
Received: from pmxchannel-daemon.brm-avmta-1.central.sun.com by
 brm-avmta-1.central.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 id <0K7E00001E35KN00@brm-avmta-1.central.sun.com> for PSARC-ext@sun.com
 (ORCPT PSARC-ext@sun.com); Thu, 18 Sep 2008 09:37:53 -0600 (MDT)
Received: from sca-es-mail-1.sun.com ([192.18.43.132])
 by brm-avmta-1.central.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 with ESMTP id <0K7E00LRZE34IZ20@brm-avmta-1.central.sun.com> for
 PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Thu,
 18 Sep 2008 09:37:52 -0600 (MDT)
Received: from fe-sfbay-10.sun.com ([192.18.43.129])
	by sca-es-mail-1.sun.com (8.13.7+Sun/8.12.9) with ESMTP id m8IFbqQB010224	for
 <PSARC-ext@sun.com>; Thu, 18 Sep 2008 08:37:52 -0700 (PDT)
Received: from conversion-daemon.fe-sfbay-10.sun.com by fe-sfbay-10.sun.com
 (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007))
 id <0K7E00C01DWQ7Q00@fe-sfbay-10.sun.com> (original mail from gdamore@sun.com)
 for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Thu,
 18 Sep 2008 08:37:52 -0700 (PDT)
Received: from [10.7.251.172] by fe-sfbay-10.sun.com
 (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007))
 with ESMTPSA id <0K7E008TLE2S6CG0@fe-sfbay-10.sun.com> for PSARC-ext@sun.com
 (ORCPT PSARC-ext@sun.com); Thu, 18 Sep 2008 08:37:41 -0700 (PDT)
Date: Thu, 18 Sep 2008 08:35:55 -0700
From: "Garrett D'Amore" <gdamore@sun.com>
Subject: Re: PSARC 2008/591 PCI Device Detection on FreeBSD
In-reply-to: <20080918153058.GD47882@submonkey.net>
Sender: Garrett.Damore@sun.com
To: Ceri Davies <ceri@submonkey.net>
Cc: Frank Che <Frank.Che@sun.com>, PSARC-ext@sun.com, Li Ye <Ye.Li@sun.com>
Message-id: <48D2755B.3000400@sun.com>
MIME-version: 1.0
Content-type: text/plain; format=flowed; charset=ISO-8859-1
Content-transfer-encoding: 7BIT
X-PMX-Version: 5.4.1.325704
References: <48D21B30.1090100@sun.com> <20080918095206.GB47882@submonkey.net>
 <48D26F85.8030306@sun.com> <20080918153058.GD47882@submonkey.net>
User-Agent: Thunderbird 2.0.0.14 (X11/20080616)
Status: RO
Content-Length: 1956

Ceri Davies wrote:
> On Thu, Sep 18, 2008 at 08:11:01AM -0700, Garrett D'Amore wrote:
>   
>> Ceri Davies wrote:
>>     
>>> On Thu, Sep 18, 2008 at 05:11:12PM +0800, Frank Che wrote:
>>>   
>>>       
>>>> I'm sponsoring this case for Ye Li. This case is to make a minor update 
>>>> to the Amaranth project to support PCI device detection on FreeBSD. It
>>>> requests a minor release binding to the Sun Device Detection Tool product.
>>>>
>>>> I have marked it as "closed approved automatic" since the change is 
>>>> straightforward and the interface is clear.
>>>>     
>>>>         
>>>   
>>>       
>>>>     Interfaces Imported:
>>>>
>>>>     ------------------------------------------------------------------
>>>>     | OS Type | Interface     | Purpose                              |
>>>>     ------------------------------------------------------------------
>>>>     | FreeBSD | /dev/pci      | Scan file /dev/pci to read PCI       |
>>>>     |         | PCIOCREAD     | device data                          |
>>>>     ------------------------------------------------------------------
>>>>     
>>>>         
>>> FWIW, I think you'll need to use PCIOGETCONF as well.
>>>   
>>>       
>> I realize that FreeBSD doesn't use the same interface stability levels, 
>> but are the PCI ioctls morally "public" (preferably documented in man 
>> page)?  (I.e. I want to make sure that we aren't using some kind of 
>> internal-use-only API that could change at the drop of the hat.  I don't 
>> think we are, but I'd like it to be explicit in the case materials.
>>     
>
> They're documented in the pci(4) manpage, see
> http://man.freebsd.org/pci/4, and absolutely intended for public
> consumption.
>
> It's been known (ok, quite common) for kernel API/ABI to break across
> major releases, but I'm unaware of any planned work affecting this area.
>
> Ceri
>   
Thank you (to Seb as well) for the clarification.  I'm satisfied. :-)

    -- Garrett

From Matthew.Jacob@sun.com Thu Sep 18 08:49:49 2008
Received: from sunmail2sca.sfbay.sun.com (sunmail2sca.SFBay.Sun.COM [129.145.155.234])
	by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id m8IFnno7013302
	for <psarc-ext@sac.sfbay.sun.com>; Thu, 18 Sep 2008 08:49:49 -0700 (PDT)
Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6])
	by sunmail2sca.sfbay.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id m8IFnmrZ008012
	for <@sunmail2sca.sfbay.sun.com:PSARC-ext@sun.com>; Thu, 18 Sep 2008 08:49:48 -0700 (PDT)
Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by
 nwk-avmta-2.sfbay.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 id <0K7E00015EN0Y400@nwk-avmta-2.sfbay.sun.com> for PSARC-ext@sun.com
 (ORCPT PSARC-ext@sun.com); Thu, 18 Sep 2008 08:49:48 -0700 (PDT)
Received: from sca-es-mail-1.sun.com ([192.18.43.132])
 by nwk-avmta-2.sfbay.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 with ESMTP id <0K7E00N9IEN01820@nwk-avmta-2.sfbay.sun.com> for
 PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Thu,
 18 Sep 2008 08:49:48 -0700 (PDT)
Received: from fe-sfbay-09.sun.com ([192.18.43.129])
	by sca-es-mail-1.sun.com (8.13.7+Sun/8.12.9) with ESMTP id m8IFnlVC011741	for
 <PSARC-ext@sun.com>; Thu, 18 Sep 2008 08:49:48 -0700 (PDT)
Received: from conversion-daemon.fe-sfbay-09.sun.com by fe-sfbay-09.sun.com
 (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007))
 id <0K7E00901E09OK00@fe-sfbay-09.sun.com>
 (original mail from Matthew.Jacob@Sun.COM)
 for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Thu,
 18 Sep 2008 08:49:47 -0700 (PDT)
Received: from [192.168.1.2] ([72.164.148.65])
 by fe-sfbay-09.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb
 28 2007)) with ESMTPSA id <0K7E005YSEMS87E0@fe-sfbay-09.sun.com> for
 PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Thu,
 18 Sep 2008 08:49:40 -0700 (PDT)
Date: Thu, 18 Sep 2008 08:48:29 -0700
From: Matthew Jacob <Matthew.Jacob@sun.com>
Subject: Re: PSARC 2008/591 PCI Device Detection on FreeBSD
In-reply-to: <48D2755B.3000400@sun.com>
Sender: Matthew.Jacob@sun.com
To: "Garrett D'Amore" <gdamore@sun.com>
Cc: Ceri Davies <ceri@submonkey.net>, Frank Che <Frank.Che@sun.com>,
        PSARC-ext@sun.com, Li Ye <Ye.Li@sun.com>
Message-id: <48D2784D.7040006@sun.com>
MIME-version: 1.0
Content-type: text/plain; format=flowed; charset=ISO-8859-1
Content-transfer-encoding: 7BIT
X-PMX-Version: 5.4.1.325704
References: <48D21B30.1090100@sun.com> <20080918095206.GB47882@submonkey.net>
 <48D26F85.8030306@sun.com> <20080918153058.GD47882@submonkey.net>
 <48D2755B.3000400@sun.com>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.16)
 Gecko/20080702 SeaMonkey/1.1.11
Status: RO
Content-Length: 1616

Garrett D'Amore wrote:
>
>>
>> They're documented in the pci(4) manpage, see
>> http://man.freebsd.org/pci/4, and absolutely intended for public
>> consumption.
>>
>> It's been known (ok, quite common) for kernel API/ABI to break across
>> major releases, but I'm unaware of any planned work affecting this area.
>>

A good clue whom to ask about this is looking at the latest CVS 
revisions for a related file (pciio.h).

You can note from this that FreeBSD is quite aware of interface 
stability, although they don't document it as much as Sun does and can 
have cleanup issues to deal with.

So, the people to talk to are probably Warner Losh (imp@freebsd.org) and 
John Baldwin (jhb@freebsd.org). The release engineer (Ken Smith) was 
consulted here, and Marius did the work. The "MFC after: 5 days" is 
shorthand for "Move from Current after 5 days", which mean that it went 
from the head development into the RELENG_7 (version 7 release branch) 
after 5 days settle time.

----------------------------
revision 1.8
date: 2007/10/24 20:51:44;  author: marius;  state: Exp;  lines: +1 -1
Add ABI backwards compatibility to the FreeBSD 4/5/6 versions of
the PCIOCGETCONF, PCIOCREAD and PCIOCWRITE IOCTLs, which was broken
with the introduction of PCI domain support.
As the size of struct pci_conf_io wasn't changed with that commit,
this unfortunately requires the ABI of PCIOCGETCONF to be broken
again in order to be able to provide backwards compatibility to
the old version of that IOCTL.

Requested by:   imp
Discussed with: re (kensmith)
Reviewed by:    PCI maintainers (imp, jhb)
MFC after:      5 days


From Frank.Che@Sun.COM Fri Sep 19 01:19:28 2008
Received: from sunmail2sca.sfbay.sun.com (sunmail2sca.SFBay.Sun.COM [129.145.155.234])
	by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id m8J8JS84011969
	for <psarc-ext@sac.sfbay.sun.com>; Fri, 19 Sep 2008 01:19:28 -0700 (PDT)
Received: from brm-avmta-1.central.sun.com (brm-avmta-1.Central.Sun.COM [129.147.4.11])
	by sunmail2sca.sfbay.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id m8J8JQTT007446
	for <@sunmail2sca.sfbay.sun.com:PSARC-ext@sun.com>; Fri, 19 Sep 2008 01:19:28 -0700 (PDT)
Received: from pmxchannel-daemon.brm-avmta-1.central.sun.com by
 brm-avmta-1.central.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 id <0K7F00601OGG6500@brm-avmta-1.central.sun.com> for PSARC-ext@sun.com
 (ORCPT PSARC-ext@sun.com); Fri, 19 Sep 2008 02:19:28 -0600 (MDT)
Received: from sineb-mail-2.sun.com ([192.18.19.7])
 by brm-avmta-1.central.sun.com
 (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005))
 with ESMTP id <0K7F005FSOGEPW00@brm-avmta-1.central.sun.com> for
 PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Fri,
 19 Sep 2008 02:19:27 -0600 (MDT)
Received: from fe-apac-06.sun.com
 (fe-apac-06.sun.com [192.18.19.177] (may be forged))
	by sineb-mail-2.sun.com (8.13.6+Sun/8.12.9) with ESMTP id m8J8JQQh016242	for
 <PSARC-ext@sun.com>; Fri, 19 Sep 2008 08:19:26 +0000 (GMT)
Received: from conversion-daemon.mail-apac.sun.com by mail-apac.sun.com
 (Sun Java System Messaging Server 6.2-6.01 (built Apr  3 2006))
 id <0K7F00G01OAIVZ00@mail-apac.sun.com> (original mail from Frank.Che@Sun.COM)
 for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Fri,
 19 Sep 2008 16:19:25 +0800 (SGT)
Received: from [129.158.218.60] by mail-apac.sun.com
 (Sun Java System Messaging Server 6.2-6.01 (built Apr  3 2006))
 with ESMTPSA id <0K7F000RUOGDW7IG@mail-apac.sun.com> for PSARC-ext@sun.com
 (ORCPT PSARC-ext@sun.com); Fri, 19 Sep 2008 16:19:25 +0800 (SGT)
Date: Fri, 19 Sep 2008 16:18:38 +0800
From: Frank Che <Frank.Che@Sun.COM>
Subject: Re: PSARC 2008/591 PCI Device Detection on FreeBSD
In-reply-to: <20080918095206.GB47882@submonkey.net>
Sender: Frank.Che@Sun.COM
To: Ceri Davies <ceri@submonkey.net>
Cc: PSARC-ext@Sun.COM, Li Ye <Ye.Li@Sun.COM>
Message-id: <48D3605E.4080008@sun.com>
MIME-version: 1.0
Content-type: text/plain; format=flowed; charset=ISO-8859-1
Content-transfer-encoding: 7BIT
X-PMX-Version: 5.4.1.325704
References: <48D21B30.1090100@sun.com> <20080918095206.GB47882@submonkey.net>
User-Agent: Thunderbird 2.0.0.4 (X11/20070622)
Status: RO
Content-Length: 1038

Ceri Davies wrote:
>>     Interfaces Imported:
>>
>>     ------------------------------------------------------------------
>>     | OS Type | Interface     | Purpose                              |
>>     ------------------------------------------------------------------
>>     | FreeBSD | /dev/pci      | Scan file /dev/pci to read PCI       |
>>     |         | PCIOCREAD     | device data                          |
>>     ------------------------------------------------------------------
>>     
>
> FWIW, I think you'll need to use PCIOGETCONF as well.
>
> Ceri
>   
Both interfaces are OK for this project to get the PCI device 
information that the product required. The PCIOGETCONF interface is even 
more easy to implement. The reason the project team selected the 
PCIOCREAD interface is that, the PCIOGETCONF interface was broken 
between recent major releases as described in the FreeBSD release 
document. To use one binary to cover all recent FreeBSD releases, the 
project team selected the PCIOCREAD interface.

Frank.


