ONNV C-Team Review Checklist Rev. 1.88, 2009-Oct-26 Project Name: VRRP Manager and I-team Lead: Manager: Sharon Liu I-team lead: Cathy Zhou I-team alias, if applicable: None Provide your current target integration date: 2009-NOV-12 PTL Entry #: 4915 1. Project Inception 1.1 List the key requirements for your project. The VRRP project is to implement the VRRP (Virtual Router Redundance Protocol) version 3 which is defined in draft-ietf-vrrp-unified-02, with the goal of providing High Availability on Solaris. The project is done when Solaris confirms to the VRRP protocol specified in the above ietf draft. 1.2 List the Software and Solaris PAC Big Rules that your project does not comply with and why. SPAC Policies: http://solaris.eng/SOE/Solaris-PAC/policies The project complies with all applicable policies. 1.3 Provide a pointer to your project test plan. See http://ontestreview.central.sun.com/wiki/index.php/Main_Page for a test plan template. http://ontestreview.central.sun.com/wiki/index.php/Vrrp_tp 1.4 [Y] Are you introducing NEW packages? SUNWvrrpr: Solaris VRRP protocol (Root) SUNWvrrpu: Solaris VRRP protocol (Usr) 1.5 [N] Are you targeting an update release? If yes to both 1.4 and 1.5, be aware that new packages are only released when the update is complete. Changes to existing packages will be made available as patches after the Update's fold-back completes. Please see the ON Update c-team for additional information: http://solaris.eng.sun.com/ON_UPDATES/ 2. Review 2.1 ARC approval status Please list *which* ARC(s) have given the approval. Note: Patch Binding is required in order to integrate into an update release, since update releases are delivered as a collection of patches. Date Opinion ARC Case # Case Title Approved Written Binding -------------- ------------------------ -------- ------- ------- PSARC/2008/693 VRRP 01/14/09 N patch PSARC/2009/388 VRRP update 08/12/09 N patch 2.2 List all ARC TCRs and TCAs and their resolution. TCRs: NONE TCAs: The active state of the VRRP router can be represented by the state of ithe SMF serivce. The VRRP project team discussed with the SMF team regarding "SMF solution for VRRP". Basically, if SMF instances were used to represent VRRP routers, the state of the service would still not be able to reflect the real state of a VRRP router. Enabling a VRRP instance would only enables a VRRP router to start participating the VRRP protocol, but the result of the VRRP router would still be uncertain (could be any of the three states: INIT, BACKUP, MASTER). Other services rely on the virtual addresses that a VRRP router protects would still not be able to determine whether those addresses are usable based on the state of the corresponding VRRP service. 2.3 List all participants in the design review. Participant Name Group Name/Technology Area ------------------------- -------------------------- Sowmini Varadhan Networking Sebastien Roy Networking Erik Nordmark Networking Kacheong Poon Networking James Carlson Networking (no longer with Sun) [Y] Has each design reviewer listed above explicitly stated that they were satisfied with the final design? 2.4 List all participants in the code review. Participant Name Group Name/Technology Area ------------------------- -------------------------- Girish Moodalbail Networking Peter Memishian Networking Erik Nordmark Networking Sebastien Roy Networking Sowmini Varadhan Networking Vasumathi Sundaram Networking Eric Cheng Networking [Y] Has each code reviewer listed above explicitly stated that they are satisfied that all of their concerns have been addressed? 2.5 [N] Are you introducing a new or updated nexus or device driver, interposing I/O stack module (i.e. TCP/IP, GLD, iSCSI or Leadville) or CPU or platform module? 1. Pointer to your approved FMA portfolio: http://fma.eng.sun.com/developer 2. [Y/N] Have you putback your events to the SMI Event Registry? http://events.central.sun.com/ List the ARC case number(s) associated with your FMA-support and clearly identify FMA ARC case(s) within Section 2.1 "ARC approval status". 3. Testing 3.1 Test Status Who is your ON Test Sponsor? Test Sponsor Intern: Hua Tang Test Sponsor: John Leser Provide the last date (or bi-weekly build) when your snapshot for testing was taken. Please use this format: [YYYY-AlphaMonth-DD] The ONPIT tests was based on snv_126+VRRP The boottime PerfPIT test was based on snv_126-nd+VRRP All other tests were was based on snv_127+VRRP [Y/N] Has your test sponsor completed a thorough review of your test results, and signed off on them? If not, provide the target completion date. Please use this format: [2009-NOV-13] Note: The bits which you tested should have been built from a workspace which consisted of some snapshot of the gate (or clone) plus your wad. 3.2 [Y] Pre-Integration Test (PIT) run required per test plan? Type of PIT run: [ONPIT] [Y] PIT run complete and analyzed w/all bugs filed? 3.3 [Y] Are there new automated test deliverables? If not, why? [ ] Existing PIT test suites provide code coverage at a functional-test level or higher. [ ] Some other reason (provide detailed explanation) If there are new automated test deliverables: [Y] Tests will be integrated into an existing Test Suite. Name of the Test Suite: Product/Category/Subcategory stc/net/gldv3 Target Date of the putback to the Test Suite: Please use this format: [2009-DEC-18] If your project is delivering a new Test Suite: [N] The "New Test Suite PIT Integration Checklist" has been submitted to ON PIT. http://onpit.ireland.sun.com/Home/docs/TSICheckList.html Provide the date when project tests will first execute in PIT. Please use this format: [2010-JAN-11] The checklist cann only be filed after the test suite is integrated. List Bugster info for Test Suite(s) to be integrated. CR ID Product/Category/Subcat RM IE ------- ----------------------- -- -- 6895051 stc/net/vrrp eric.kozlowski@sun.com xiang.zhou@sun.com 6892333 stc/net/gldv3 eric.kozlowski@sun.com xiang.zhou@sun.com [Y] The project team agrees to test all WOS builds post-integration until their acceptance tests are executing in PIT. Results will be archived in the project directory on tas.sfbay. Note: ONNV PM will keyword these CR(s) with onpit to track the test suite integration(s). 3.4 Results Archival Provide the pointer to your project test results. /net/tas.sfbay/export/cteam/project_results/snv/Projects/VRRP/Initial_Putback/ Note: Contact your ON test sponsor or review /ws/on-results/README for instructions on how to organize the project results archive. Results should be placed in the correct project directory under: /ws/on-results/snv or /net/tas.sfbay.sun.com/export/cteam/project_results/snv 3.5 Performance List the Performance metrics/benchmarks you ran per your approved test plan. boottime [N] Any deviation from your approved test plan? If yes, please explain. [N] Do you have a performance degradation? If yes, please explain. A list of Perf. Benchmarks can be found at: http://perfwww.ireland.sun.com/cgi-bin/tools/benchdescriptions.cgi Provide a pointer to test results. http://perfwww.ireland/regression/PITcompare/selftest-3995-VRRP-126-boottime-bfu-compare.html 4. Bugs 4.1 List all existing bug fixes you'll be integrating. CR ID Pri Synopsis ------- --- ---------------------------------------------- 6288572 3 RFE: VRRP implementation desired for Solaris Note: Include all project placeholder bug IDs. This information will be in your RTI and putback comments (use wx pbcom to generate putback comments). 4.2 List any bugs against this project that will remain open at putback. None CR ID Pri Synopsis ------- --- ---------------------------------------------- Note: P1 - P3's are required to be resolved before integration. 4.3 List the Bugster subcategories used to track bugs for this project during development. Typically, these subcategories exist under the "development" product in Bugster. For each subcategory, list the full name including product and category, along with the Responsible Manager and Initial Evaluator. Product/Category/Subcategory RM IE ---------------------------- -- -- development/network/vrrp Sharon.Liu@Sun.COM Cathy.Zhou@Sun.COM 4.4 List the Bugster subcategories that will be used to track bugs for this functionality after integration in Solaris. In most cases, these subcategories will exist under the "solaris" product in Bugster. For each subcategory, list the full name including product and category, along with the Responsible Manager and Initial Evaluator. Use the New column to note which subcategories are newly created. New Product/Category/Subcategory RM IE --- ---------------------------- -- -- y solaris/network/vrrp Sharon.Liu@Sun.COM Cathy.Zhou@Sun.COM [Y] All Bugster products listed in the table above have solaris_nevada and snv_xx release and build values added. Note: The "solaris" product already has the necessary release and build values; no action is needed by the project team. Verify your product by checking Bugster for available targeted release values. Contact Valerie Bubb or Scott Rotondo to add or remove subcategories from the "solaris" or "development" products. 4.5 Verify the following statements before integration: [Y] All open bugs have been moved from the development subcategories listed in 4.3 have been moved to subcategories listed in 4.4. [TBD] Development subcategories listed in 4.3 have been deactivated, except for those that are also listed in 4.4. 5. Miscellaneous 5.1 Dependencies List all projects/bug-fixes that you depend on. Clearview IP Tunneling (PSARC/2009/373) IP Datapath Refactoring (PSARC/2009/331) : No technical dependency, but the VRRP gate is parenting off their gate. List all projects/bug-fixes that depend on you. None List any dependencies you have on an existing functional area. None Do you depend on any other consolidation? None 5.2 Documentation work outstanding Man pages File a separate CR for each man page section affected. Manpage CR ID Section Writer Engineering Contact -------- ------- ------ ------------------- 6889232 1M Cathy Zhou terry.gibson@Sun.COM Books Book Name Writer Engineering Contact --------- ------ ------------------- Solaris System Administration: IP Services Vinutha.Sm@Sun.COM Cathy.Zhou@Sun.COM List any man page or book whose contents contain any material that was composed by someone outside Sun: man page or book content OpenSolaris or third-party ------------------------ -------------------------- None What's New ---------- You or your assigned book writer needs to complete the What's New doc template at: http://releaseme.sfbay.sun.com/new_features_input.html. If your project requires only man pages, you need to complete the template yourself. Otherwise your book writer can complete this for you. Who will submit the What's New for this project? S.M Vinutha 5.3 RPE (Sustaining) List the Group Name and Mgr. Name of the person who has agreed to do the post-FCS support: RPE Networking tech team, Satish Murugesan List the TOI date; an exact date is not required, but a we-promise-to-do-it-by-this-date sort of answer is: Will do it by the end of 2009. Complete the TPT Feature template at: http://solaris.eng/benet/S11/TPT/Templates/tpt-feature.txt Provide a pointer to your completed TPT Feature form: TBD 5.4 [N] Did you have any contractors/vendors working on this feature code? Contractor Name or Consulting Firm Name: Country worked in: Country paid in: Platforms worked on: Sparc, x86 or both: Provide a photocopy or softcopy of signed Exhibit E or assignment of IP rights to Miguel.Ulloa@sun.com. PLEASE NOTE: This form is for all contractors/vendors other than 3rd party driver work. The document/info needed for 3rd party driver vendors is included in question 7.1 below. 6. Packaging & Installation 6.1 Is this project submitting new packages? [Y] Yes [ ] No - If no, please skip to section 6.6 6.2 Package RTIs [Y] All required package RTIs have been submitted to pkgteam@eng and approved. [Y] Approved package RTI email attached to checklist submission. A package RTI must be submitted for each package that is newly created, removed, or changed in a significant way. Significant changes include addition or removal of one architecture, change of BASEDIR, requirement for booting, product cluster creation or modification, metacluster list change, and whether or not it belongs in the miniroot. More information can be found at http://pkgteam.sfbay.sun.com/ Package RTI info, http://wikihome.sfbay.sun.com/spe-re/Wiki.jsp?page=RTCs_RTIs FAQ pkg history files, http://wikihome.sfbay.sun.com/spe-re/Wiki.jsp?page=Pkghist_help Please list here all packages requiring RTIs, and a brief description why. Please be sure to summarize any cluster / metacluster information, as well as changes to product layout. Package Description ------- ----------- SUNWvrrpr Solaris VRRP protocol (Root). New package SUNWvrrpu Solaris VRRP protocol (Usr). New package 6.3 Package location If any packages are required for booting or for installation (belong on the miniroot/failsafe image and/or CD1), please list them here, along with a short justification. These changes require a package RTI (see 6.1). Package Reason ------- ------ None 6.4 List any packages that require package history entries. None ( because the VRRP project does not obsolete, rename or split packages nor move files from one package to another) [ ] All package history files have been submitted to gk@onnv.eng for delivery to RE. A package history entry (.ph file) must be submitted when a package is removed, renamed, split, or removed from a product cluster, or changes BASEDIR. Details at: http://solaris.eng.sun.com/benet/Packaging/pkg_history.txt 6.5 Package dependencies [Y] All package dependencies are satisfied by packages in the same (or smaller) metacluster. 6.6 Package installation scripts Please list all new and updated package installation scripts ({pre,post}{install,remove}, class action scripts, etc.), and a brief description of why they're there. N/A Package Files Description ------- ----- ----------- [] All files which are expected to be edited by the user are of type "e" and have appropriate classes associated with them. 6.7 Describe any installation or upgrade issues. None 6.8 Describe any changes to BFU. None 6.9 List any executables delivered to /opt or /var. None 6.10 List any new setuid or setgid executables, or any existing executables changed to be setuid/setgid. None 7. Source Code 7.1 Check ALL boxes that apply to the code you want to integrate. [Y] None of the following are applicable to this putback. Note: if you chose "None" above, then please cut the rest of the text in 7.1 out of the checklist. This is the ONLY text you may remove from the checklist. [ ] Some or all of this code came from outside Sun. Select all options below that apply. [ ] Open source or freeware code being introduced into Solaris for the first time and Legal Review is pending. Provide the name of the attorney conducting the Open Source/Freeware Review: [ ] Open source or freeware code being introduced into Solaris for the first time; Legal Review has been completed and an Open Source/Freeware Review ("OSR") approval has been generated. The OSR tool can be accessed at: http://opensourcereview.east.sun.com/ Provide the OSR number: [ ] Please check here to confirm that you have read the OSR Approval in its entirety, that your OSR code putback has been approved for integration into Solaris and can be open sourced, and that your putback complies with all restrictions (e.g., architectural rules, notices) set forth in the OSR approval. [ ] Third-party source that is not open source or freeware code being introduced into Solaris for the first time. This putback requires Legal approval. If approval has already been obtained, please provide either a copy of the agreement, or as much of the following information as possible: Name of the third party company (vendor): Date of the license agreement: format: [YYYY-AlphaMonth-DD] Name of the product attorney who negotiated the contract: The agreement's Legal File Index (LFI) number: [ ] Updates to previously-approved third-party source. Updates come from the same place as the original, and may be either open source/freeware code or third party proprietary. No changes in the licensing have occurred. This putback requires that a current, valid approval from Sun Legal be in place. For open source/freeware code: Provide the OSR# of existing approval *or* the URL of the open source or freeware code if original integration preceded OSR tool: For proprietary code: Provide the LFI# of the license agreement: Provide the name of the third party company: Provide the name of the code or technology: Provide the name of the attorney who negotiated the agreement: [ ] This code was written by an individual contributor to OpenSolaris. A completed, signed and dated Sun Contributor Agreement (SCA) must be on file for this code to be integrated. Provide the number of the SCA agreement: Provide the name of the Community Contributor: Provide the name of the sponsoring Sun engineer: [ ] This is new code that was written using confidential, third-party information provided under a Confidential (or Non-)Disclosure Agreement, or license agreement. This putback requires Legal approval. Please provide as much of the following information as possible: The name of company providing the confidential information: The nature of the information (specification, referenced code, etc.): Provide the LFI# of the license or confidential disclosure agreement (CDA/SLA/etc.): Provide name and part number of any other company's documents used and the associated level of confidentiality: [Has approval by the Solaris x86 Director, Andy Roach, been obtained for Projects/RFEs which contain source covered by Intel restricted legal documents? [ ] Yes [ ] No [ ] N/A Provide the name of the attorney who negotiated the license or CDA: [ ] This code includes the encumbered source tag. [ ] This code does not include the encumbered source tag. Please read the encumbered code heads up message at: http://onnv.sfbay.sun.com/links/flagdays/pages/20050118encumber.html [ ] I wrote this code by moving/copying at least some of it from code that currently exists within Sun. Please provide the pathname relative to the ON source tree, or a full pathname including NFS mount-points if from another consolidation or source repository. Provide a pointer where you copied the code from (i.e., provide the full pathname): Provide all non-Sun copyrights/notices found in that source: Provide an explanation if you did not propagate the copyrights, notices or encumbered source tag: Please read the encumbered code heads up message at: http://onnv.sfbay.sun.com/links/flagdays/pages/20050118encumber.html 7.2 [ ] Invention disclosures have been filed for all patentable material. (You can find the Invention Disclosure Tool at http://idt.central.sun.com) List any Patent IDs: N/A 7.3 Describe any new closed source introduced. None 7.4 List any new or additional cryptographic algorithms implemented. [ ] ITS approval granted and forwarded to onnv-cteam@sun.com. http://its.europe.sun.com/Software/Software_Exports/Third_Party_Software_Matrix/general/3rdparty_class_form.html None 7.5 [Y] Have messages from commands or libraries been added or modified? If so and if the message is GUI or web UI, you will need to fill out a Request for L10N Services. The form (G11N-RFW-Template.txt) can be found in: http://solaris.eng.sun.com/benet/S11/G11N/How-to-deliver-to-G11N [ ] Has the form been submitted? If not, provide a date by which it will be submitted. Format: [YYYY-AlphaMonth-DD] N/A CLI only Verify the following (including CLI messages): [Y] make _msg has been run to verify that messages are generated properly for localization [Y] The L10N script has been run on your SUNW0on pkg to test if your message output is I18N compliant. L10N script is at: http://onnv.sfbay.sun.com/g11n.html 7.6 Review the Accessibility Form (http://section508tool.sfbay) and check one of the following statements. [ ] Accessibility form has been completed. Provide the product name and assessment ID number. Product Name: Assessment ID #: [ ] Accessibility form has not been completed. Provide a date by which it will be completed and submitted to the Accessibility Program Office. Date format: YYYY-AlphaMonth-DD [X] This project introduces a new and/or modifies a command line interface and not a GUI or BUI. CLI questionnaire has been completed and submitted to Miguel.Ulloa@sun.com CLI Questionnaire: http://solaris.eng/onnv/Templates/A11Y.txt [ ] The project has no user interface of any kind-no GUI or command line interface, and the end user would never interact with the feature. Email has been sent to Michele Budris in the A11Y office [cc: onnv-cteam@sun.com] with the following info: Feature Name: Release Name: Nevada - ON Consolidation Request: Assessment Form Exception Approval Why: No user interface of any kind 7.7 List shared library interface changes or additions. Changes made to libdladm.so.1 added libvrrpadm.so.1 (no documented API) 7.8 List any new or modified messages emitted during boot. None 7.9 List any new or modified messages emitted by DEBUG kernel only. None 7.10 List any new or modified messages a system administrator would notice and may or may not need to take action on. If a VRRP router is misconfigured, the vrrpd daemon will log a message to syslog explaining the problem. 8. Integration 8.1 [Y] Does the new/modified code pass all tests done by hg nits? 8.2 SMI copyrights per /shared/ON/general_docs/golden_rules.txt? Verify each statement below and check its associated box. [X] No copyrights from other companies removed. [X] Year updated for all significant updates. [X] "All rights reserved" notice in place. [X] "Use is subject to license terms" in place. 8.3 [Y] Full build (nightly -0aADClmprfzt) complete on SPARC and x86 with no build noise or lint output. [Y] Are all newly created files referenced in usr/src/Makefile.lint? [Y] Are all recently modified files referenced in usr/src/Makefile.lint? [N] Are there changes to default LINTFLAGS? 8.4 List any compiler warnings introduced. None 8.5 [Y] Secure programming guidelines have been followed. See http://secprog.sfbay/ for more information. 8.6 Preliminary RTI Use http://webrti.sfbay.sun.com/. Include a putback -n output & a webrev pointer in the RTI. Save to "preliminary RTI". Send the RTI number to onnv-cteam@sun.com. Continue to save until the Cteam review has been completed by the tech lead and gatekeepers. Once all edits have been completed you'll be asked to submit your final RTI. 8.7 Include your draft Flag-day or Heads-up message. Heads-up: VRRP My recent integration of: PSARC/2008/693 VRRP PSARC/2009/388 VRRP Update introduces a new protocol - VRRPv3 (Virtual Router Redundancy Protocol verstion 3) into Solaris. Specifically, VRRP specifies an election protocol that dynamically assigns responsibility for a virtual router to one of the VRRP routers on a LAN, which provides high availability of the default gateway servicing hosts within that same LAN. For more information, please refer to vrrpadm(1M) manpage. For bug reporting, please use the category: solaris/network/vrrp Thanks