From gd78059@sac.sfbay.sun.com Wed Jan 21 08:50:48 2009 Received: from newsunmail1brm.central.sun.com (newsunmail1brm.Central.Sun.COM [129.147.62.245]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n0LGomSb011510 for ; Wed, 21 Jan 2009 08:50:48 -0800 (PST) Received: from nwk-avmta-1.SFBay.Sun.COM (nwk-avmta-1.SFBay.Sun.COM [129.146.11.74]) by newsunmail1brm.central.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id n0LGoldn010023; Wed, 21 Jan 2009 09:50:47 -0700 (MST) Received: from pmxchannel-daemon.nwk-avmta-1.sfbay.Sun.COM by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0KDT00303YSNQV00@nwk-avmta-1.sfbay.Sun.COM>; Wed, 21 Jan 2009 08:50:47 -0800 (PST) Received: from dm-sfbay-02.sfbay.sun.com ([129.146.11.31]) by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0KDT00HYOYSNLB80@nwk-avmta-1.sfbay.Sun.COM>; Wed, 21 Jan 2009 08:50:47 -0800 (PST) Received: from sac.sfbay.sun.com (new-sac.SFBay.Sun.COM [129.146.175.65]) by dm-sfbay-02.sfbay.sun.com (8.13.8+Sun/8.13.8/ENSMAIL,v2.2) with ESMTP id n0LGokIE015323; Wed, 21 Jan 2009 08:50:46 -0800 (PST) Received: from sac.sfbay.sun.com (localhost [127.0.0.1]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n0LGojtI011473; Wed, 21 Jan 2009 08:50:45 -0800 (PST) Received: (from gd78059@localhost) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8/Submit) id n0LGojkZ011461; Wed, 21 Jan 2009 08:50:45 -0800 (PST) Date: Wed, 21 Jan 2009 08:50:45 -0800 (PST) From: "Garrett D'Amore - sun microsystems" Subject: prefetch interfaces [PSARC/2009/039 Self Review] To: PSARC-ext@sun.com Cc: pdurrant@solarflare.com Message-id: <200901211650.n0LGojkZ011461@sac.sfbay.sun.com> Content-transfer-encoding: 7BIT X-PMX-Version: 5.4.1.325704 Status: RO Content-Length: 1920 Template Version: @(#)sac_nextcase %I% %G% SMI This information is Copyright 2009 Sun Microsystems 1. Introduction 1.1. Project/Component Working Name: prefetch interfaces 1.2. Name of Document Author/Supplier: Author: Paul Durrant 1.3 Date of This Document: 21 January, 2009 4. Technical Description I'm sponsoring this case for Paul Durrant. I believe it qualifies for self review. The interfaces proposed (prefetch_read_many and prefetch_read_once) are proposed for Consolidation Private commitment. This case seeks Patch binding, although at the moment we believe this will only be delivered into Nevada. If anyone thinks it deserves more discussion, please feel free to bump it up to a regular fast track. -- Garrett PROBLEM Many device drivers, particularly 10 gigabit network drivers, need to avoid CPU stalls to achieve good bandwidth. CPU stalls can be caused by many things including cache and TLB misses. Careful code and data structure layout can be used to mitigate TLB misses. Cache misses can also be mitigated by careful code and data layout, but also by giving hints to the CPU to prefetch certain data into cache many cycles before that data is required. ON currently lacks interfaces for device drivers to request prefetch in a platform agnostic way. PROPOSAL Add inlines for i386/amd64 and sparcv9 for the following types of prefetch: void prefetch_read_many(void *) This requests data be loaded into a cache for repeated reading. (This equates to a 't0' prefetch on x86 CPUs). void prefetch_read_once(void *) This requests data be loaded into a cache for one read only, so it can be flushed from the cache immediately after access. (This equates to a 'nta' prefetch on x86 CPUs). 6. Resources and Schedule 6.4. Steering Committee requested information 6.4.1. Consolidation C-team Name: ON 6.5. ARC review type: Automatic 6.6. ARC Exposure: open From Alan.Coopersmith@sun.com Wed Jan 21 09:27:20 2009 Received: from sunmail5.uk.sun.com (sunmail5.UK.Sun.COM [129.156.85.165]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n0LHRJ53020946 for ; Wed, 21 Jan 2009 09:27:20 -0800 (PST) Received: from nwk-avmta-1.SFBay.Sun.COM (nwk-avmta-1.SFBay.Sun.COM [129.146.11.74]) by sunmail5.uk.sun.com (8.13.8+Sun/8.13.8/ENSMAIL,v2.2) with ESMTP id n0LHRFxt004166 for <@sunmail2sca.sfbay.sun.com:PSARC-ext@sun.com>; Wed, 21 Jan 2009 17:27:18 GMT Received: from pmxchannel-daemon.nwk-avmta-1.sfbay.Sun.COM by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0KDU008010HHD000@nwk-avmta-1.sfbay.Sun.COM> for PSARC-ext@sun.com (ORCPT PSARC-ext@Sun.Com); Wed, 21 Jan 2009 09:27:17 -0800 (PST) Received: from sca-es-mail-2.sun.com ([192.18.43.133]) by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0KDU00HDF0HGLAE0@nwk-avmta-1.sfbay.Sun.COM> for PSARC-ext@sun.com (ORCPT PSARC-ext@Sun.Com); Wed, 21 Jan 2009 09:27:16 -0800 (PST) Received: from fe-sfbay-10.sun.com ([192.18.43.129]) by sca-es-mail-2.sun.com (8.13.7+Sun/8.12.9) with ESMTP id n0LHRGeF018946 for ; Wed, 21 Jan 2009 09:27:16 -0800 (PST) Received: from conversion-daemon.fe-sfbay-10.sun.com by fe-sfbay-10.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) id <0KDU00J01092VV00@fe-sfbay-10.sun.com> (original mail from Alan.Coopersmith@Sun.COM) for PSARC-ext@Sun.Com (ORCPT PSARC-ext@Sun.Com); Wed, 21 Jan 2009 09:27:16 -0800 (PST) Received: from [10.6.102.118] by fe-sfbay-10.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) with ESMTPSA id <0KDU002KF0H1IW00@fe-sfbay-10.sun.com>; Wed, 21 Jan 2009 09:27:02 -0800 (PST) Date: Wed, 21 Jan 2009 09:27:01 -0800 From: Alan Coopersmith Subject: Re: prefetch interfaces [PSARC/2009/039 Self Review] In-reply-to: <200901211650.n0LGojkZ011461@sac.sfbay.sun.com> Sender: Alan.Coopersmith@sun.com To: "Garrett D'Amore - sun microsystems" Cc: PSARC-ext@sun.com, pdurrant@solarflare.com Message-id: <49775AE5.3010201@sun.com> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 7BIT X-PMX-Version: 5.4.1.325704 X-Enigmail-Version: 0.95.1 References: <200901211650.n0LGojkZ011461@sac.sfbay.sun.com> User-Agent: Thunderbird 2.0.0.6 (X11/20071119) Status: RO Content-Length: 263 How do these interfaces compare with the sun_prefetch.h ones provided by Sun Studio? Is the difference just that these are compiler independent? -- -Alan Coopersmith- alan.coopersmith@sun.com Sun Microsystems, Inc. - X Window System Engineering From carlsonj@phorcys.east.sun.com Wed Jan 21 09:31:10 2009 Received: from sunmail3mpk.sfbay.sun.com (sunmail3mpk.SFBay.Sun.COM [129.146.11.52]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n0LHV9aS029349 for ; Wed, 21 Jan 2009 09:31:09 -0800 (PST) Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6]) by sunmail3mpk.sfbay.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id n0LHV6Re002014 for <@sunmail2sca.sfbay.sun.com:PSARC-ext@Sun.Com>; Wed, 21 Jan 2009 09:31:09 -0800 (PST) Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0KDU00K030NWA200@nwk-avmta-2.sfbay.sun.com> for PSARC-ext@Sun.Com (ORCPT PSARC-ext@Sun.Com); Wed, 21 Jan 2009 09:31:08 -0800 (PST) Received: from phorcys.east.sun.com ([129.148.174.143]) by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0KDU00D7D0NVJPD0@nwk-avmta-2.sfbay.sun.com> for PSARC-ext@Sun.Com (ORCPT PSARC-ext@Sun.Com); Wed, 21 Jan 2009 09:31:07 -0800 (PST) Received: from phorcys.east.sun.com (localhost [127.0.0.1]) by phorcys.east.sun.com (8.14.3+Sun/8.14.3) with ESMTP id n0LHNYMK026867; Wed, 21 Jan 2009 12:23:34 -0500 (EST) Received: (from carlsonj@localhost) by phorcys.east.sun.com (8.14.3+Sun/8.14.3/Submit) id n0LHNX9f026864; Wed, 21 Jan 2009 12:23:33 -0500 (EST) Date: Wed, 21 Jan 2009 12:23:33 -0500 From: James Carlson Subject: Re: prefetch interfaces [PSARC/2009/039 Self Review] In-reply-to: <200901211650.n0LGojkZ011461@sac.sfbay.sun.com> To: "Garrett D'Amore - sun microsystems" Cc: PSARC-ext@sun.com, pdurrant@solarflare.com Message-id: <18807.23061.888203.839588@gargle.gargle.HOWL> MIME-version: 1.0 X-Mailer: VM 7.01 under Emacs 21.3.1 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7BIT X-PMX-Version: 5.4.1.325704 References: <200901211650.n0LGojkZ011461@sac.sfbay.sun.com> Status: RO Content-Length: 1168 Garrett D'Amore - sun microsystems writes: > Add inlines for i386/amd64 and sparcv9 for the following types of prefetch: > > void prefetch_read_many(void *) > > This requests data be loaded into a cache for repeated reading. (This > equates to a 't0' prefetch on x86 CPUs). > > void prefetch_read_once(void *) > > This requests data be loaded into a cache for one read only, so it can > be flushed from the cache immediately after access. (This equates to a > 'nta' prefetch on x86 CPUs). Are there SPARC equivalents? Have you considered other CPUs? On PPC, there are four related instructions that I know about: dcbt - data cache block touch dcbtst - data cache block touch for store dcbz - data cache block set to zero dcbf - data cache block flush The first of those sounds like prefetch_read_many(). The others seem not to match up ... but *perhaps* they're rare enough (buried within bcopy and bzero) that nobody cares ... ? -- James Carlson, Solaris Networking Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677 From roland.mainz@nrubsig.org Wed Jan 21 10:06:15 2009 Received: from sunmail2sca.sfbay.sun.com (sunmail2sca.SFBay.Sun.COM [129.145.155.234]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n0LI6FR6004539 for ; Wed, 21 Jan 2009 10:06:15 -0800 (PST) Received: from brm-avmta-1.central.sun.com (brm-avmta-1.Central.Sun.COM [129.147.4.11]) by sunmail2sca.sfbay.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id n0LI6B3Z001554 for <@sunmail2sca.sfbay.sun.com:PSARC-ext@sun.com>; Wed, 21 Jan 2009 10:06:15 -0800 (PST) Received: from pmxchannel-daemon.brm-avmta-1.central.sun.com by brm-avmta-1.central.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0KDU00B1Z2AEJ300@brm-avmta-1.central.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 21 Jan 2009 11:06:14 -0700 (MST) Received: from sca-ea-mail-1.sun.com ([192.18.43.24]) by brm-avmta-1.central.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0KDU00NGQ2AB51A0@brm-avmta-1.central.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 21 Jan 2009 11:06:11 -0700 (MST) Received: from relay15i.sun.com (ip125.net129179-4.block1.us.syntegra.com [129.179.4.125]) by sca-ea-mail-1.sun.com (8.13.7+Sun/8.12.9) with ESMTP id n0LI2YU0010067 for ; Wed, 21 Jan 2009 18:06:10 +0000 (GMT) Received: from mmp11es.mmp.us.syntegra.com ([160.41.208.11] [160.41.208.11]) by relay15i.sun.com with ESMTP id BT-MMP-2837061 for PSARC-ext@sun.com; Wed, 21 Jan 2009 18:06:10 +0000 (Z) Received: from relay13i.sun.com (relay13i.sun.com [129.179.4.123]) by mmp11es.mmp.us.syntegra.com with ESMTP id BT-MMP-90464 for PSARC-ext@sun.com; Wed, 21 Jan 2009 18:06:10 +0000 (Z) Received: from mail-in-04.arcor-online.net ([151.189.21.44] [151.189.21.44]) by relay1i.sun.com with ESMTP id BT-MMP-31269667 for PSARC-ext@sun.com; Wed, 21 Jan 2009 18:06:10 +0000 (Z) Received: from mail-in-09-z2.arcor-online.net (mail-in-09-z2.arcor-online.net [151.189.8.21]) by mail-in-04.arcor-online.net (Postfix) with ESMTP id 6541E17FB25; Wed, 21 Jan 2009 19:06:08 +0100 (CET) Received: from mail-in-15.arcor-online.net (mail-in-15.arcor-online.net [151.189.21.55]) by mail-in-09-z2.arcor-online.net (Postfix) with ESMTP id 38FE028EE18; Wed, 21 Jan 2009 19:06:08 +0100 (CET) Received: from jupiterb48.nrubsig.org (dslb-088-068-090-167.pools.arcor-ip.net [88.68.90.167]) by mail-in-15.arcor-online.net (Postfix) with ESMTPS id A716735ACD9; Wed, 21 Jan 2009 19:06:07 +0100 (CET) Received: from nrubsig.org (localhost [127.0.0.1]) by jupiterb48.nrubsig.org (8.13.8+Sun/8.13.8) with ESMTP id n0LI64Qc008823; Wed, 21 Jan 2009 19:06:05 +0100 (CET) Date: Wed, 21 Jan 2009 19:06:03 +0100 From: Roland Mainz Subject: Re: prefetch interfaces [PSARC/2009/039 Self Review] Sender: gisburn@jupiterb48.nrubsig.org To: "Garrett D'Amore - sun microsystems" Cc: PSARC-ext@sun.com, pdurrant@solarflare.com Message-id: <4977640B.A74632D0@nrubsig.org> MIME-version: 1.0 X-Mailer: Mozilla 4.76 [en] (X11; U; SunOS 5.11 sun4u) Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7BIT X-Accept-Language: en X-PMX-Version: 5.4.1.325704 X-Brightmail-Tracker: AAAAAA== X-DKIM: Sendmail DKIM Filter v2.6.0 mail-in-15.arcor-online.net A716735ACD9 X-Virus-Scanned: ClamAV 0.94.2/8884/Wed Jan 21 14:15:32 2009 on mail-in-15.arcor-online.net X-Virus-Status: Clean X-Antispam: No, score=0.0/5.0, scanned in 0.065sec at (localhost [127.0.0.1]) by smf-spamd v1.3.1 - http://smfs.sf.net/ References: <200901211650.n0LGojkZ011461@sac.sfbay.sun.com> Status: RO Content-Length: 866 Garrett D'Amore - sun microsystems wrote: [snip] > PROPOSAL > > Add inlines for i386/amd64 and sparcv9 for the following types of prefetch: > > void prefetch_read_many(void *) > > This requests data be loaded into a cache for repeated reading. (This > equates to a 't0' prefetch on x86 CPUs). > > void prefetch_read_once(void *) > > This requests data be loaded into a cache for one read only, so it can > be flushed from the cache immediately after access. (This equates to a > 'nta' prefetch on x86 CPUs). Why do both interfaces do not have a |length| operand ? Some CPUs/architecturs allow to define a memory range (rounded up to the CPUs block size) to be pre-fetched... ---- Bye, Roland -- __ . . __ (o.\ \/ /.o) roland.mainz@nrubsig.org \__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer /O /==\ O\ TEL +49 641 3992797 (;O/ \/ \O;) From bart.smaalders@sun.com Wed Jan 21 11:18:41 2009 Received: from sunmail5.uk.sun.com (sunmail5.UK.Sun.COM [129.156.85.165]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n0LJIeLX002355 for ; Wed, 21 Jan 2009 11:18:41 -0800 (PST) Received: from nwk-avmta-1.SFBay.Sun.COM (nwk-avmta-1.SFBay.Sun.COM [129.146.11.74]) by sunmail5.uk.sun.com (8.13.8+Sun/8.13.8/ENSMAIL,v2.2) with ESMTP id n0LJHvRZ013198 for <@sunmail2sca.sfbay.sun.com:PSARC-ext@Sun.COM>; Wed, 21 Jan 2009 19:18:40 GMT Received: from pmxchannel-daemon.nwk-avmta-1.sfbay.Sun.COM by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0KDU00L055MLL100@nwk-avmta-1.sfbay.Sun.COM> for PSARC-ext@Sun.COM (ORCPT PSARC-ext@Sun.COM); Wed, 21 Jan 2009 11:18:22 -0800 (PST) Received: from zion.sfbay.sun.com ([129.146.17.75]) by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0KDU00I2Z5MLPV30@nwk-avmta-1.sfbay.Sun.COM> for PSARC-ext@Sun.COM (ORCPT PSARC-ext@Sun.COM); Wed, 21 Jan 2009 11:18:21 -0800 (PST) Received: from [129.146.228.109] (cyber.SFBay.Sun.COM [129.146.228.109]) by zion.sfbay.sun.com (8.14.2+Sun/8.14.2) with ESMTP id n0LJApNt014276; Wed, 21 Jan 2009 19:10:51 +0000 (GMT) Date: Wed, 21 Jan 2009 11:10:51 -0800 From: Bart Smaalders Subject: Re: prefetch interfaces [PSARC/2009/039 Self Review] In-reply-to: <200901211650.n0LGojkZ011461@sac.sfbay.sun.com> To: "Garrett D'Amore - sun microsystems" Cc: PSARC-ext@sun.com, pdurrant@solarflare.com Message-id: <4977733B.2070804@Sun.COM> Organization: Sun Microsystems MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7BIT X-PMX-Version: 5.4.1.325704 References: <200901211650.n0LGojkZ011461@sac.sfbay.sun.com> User-Agent: Thunderbird 2.0.0.18 (X11/20081203) Status: RO Content-Length: 346 Garrett D'Amore - sun microsystems wrote: > ON currently lacks interfaces for device > drivers to request prefetch in a platform agnostic way. What about prefetch64()? -= Bart -- Bart Smaalders Solaris Kernel Performance barts@cyber.eng.sun.com http://blogs.sun.com/barts "You will contribute more with mercurial than with thunderbird." From gdamore@sun.com Wed Jan 21 12:26:43 2009 Received: from sunmail3mpk.sfbay.sun.com (sunmail3mpk.SFBay.Sun.COM [129.146.11.52]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n0LKQhe6023615 for ; Wed, 21 Jan 2009 12:26:43 -0800 (PST) Received: from brm-avmta-1.central.sun.com (brm-avmta-1.Central.Sun.COM [129.147.4.11]) by sunmail3mpk.sfbay.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id n0LKQf2j012721 for <@sunmail2sca.sfbay.sun.com:PSARC-ext@sun.com>; Wed, 21 Jan 2009 12:26:43 -0800 (PST) Received: from pmxchannel-daemon.brm-avmta-1.central.sun.com by brm-avmta-1.central.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0KDU002018SIBX00@brm-avmta-1.central.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@Sun.COM); Wed, 21 Jan 2009 13:26:42 -0700 (MST) Received: from sca-es-mail-2.sun.com ([192.18.43.133]) by brm-avmta-1.central.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0KDU00GMZ8SHS270@brm-avmta-1.central.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@Sun.COM); Wed, 21 Jan 2009 13:26:42 -0700 (MST) Received: from fe-sfbay-09.sun.com ([192.18.43.129]) by sca-es-mail-2.sun.com (8.13.7+Sun/8.12.9) with ESMTP id n0LKQfI5014548 for ; Wed, 21 Jan 2009 12:26:41 -0800 (PST) Received: from conversion-daemon.fe-sfbay-09.sun.com by fe-sfbay-09.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) id <0KDU008018KRB600@fe-sfbay-09.sun.com> (original mail from gdamore@sun.com) for PSARC-ext@Sun.COM (ORCPT PSARC-ext@Sun.COM); Wed, 21 Jan 2009 12:26:41 -0800 (PST) Received: from [10.7.251.172] by fe-sfbay-09.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) with ESMTPSA id <0KDU00BHK8SHBZ80@fe-sfbay-09.sun.com>; Wed, 21 Jan 2009 12:26:41 -0800 (PST) Date: Wed, 21 Jan 2009 12:16:41 -0800 From: "Garrett D'Amore" Subject: Re: prefetch interfaces [PSARC/2009/039 Self Review] In-reply-to: <4977733B.2070804@Sun.COM> Sender: Garrett.Damore@sun.com To: Bart Smaalders Cc: "Garrett D'Amore - sun microsystems" , PSARC-ext@sun.com, pdurrant@solarflare.com Message-id: <497782A9.3050008@sun.com> MIME-version: 1.0 Content-type: text/plain; format=flowed; charset=ISO-8859-1 Content-transfer-encoding: 7BIT X-PMX-Version: 5.4.1.325704 References: <200901211650.n0LGojkZ011461@sac.sfbay.sun.com> <4977733B.2070804@Sun.COM> User-Agent: Thunderbird 2.0.0.14 (X11/20080616) Status: RO Content-Length: 454 Bart Smaalders wrote: > Garrett D'Amore - sun microsystems wrote: >> ON currently lacks interfaces for device >> drivers to request prefetch in a platform agnostic way. > > > What about prefetch64()? > > -= Bart > In light of the excellent questions asked (many of which I don't personally have answers for, but need to get feedback from Paul on), I'm promoting the case to a fast track, with a timeout set for one week from today. -- Garrett From pdurrant@solarflare.com Thu Jan 22 01:35:29 2009 Received: from sunmail4.singapore.sun.com (sunmail4.Singapore.Sun.COM [129.158.71.19]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n0M9ZShV012868 for ; Thu, 22 Jan 2009 01:35:29 -0800 (PST) Received: from nwk-avmta-1.SFBay.Sun.COM (nwk-avmta-1.SFBay.Sun.COM [129.146.11.74]) by sunmail4.singapore.sun.com (8.13.4+Sun/8.13.3/ENSMAIL,v2.2) with ESMTP id n0M9ZKdP028607; Thu, 22 Jan 2009 17:35:25 +0800 (SGT) Received: from pmxchannel-daemon.nwk-avmta-1.sfbay.Sun.COM by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0KDV00M0J9AZAY00@nwk-avmta-1.sfbay.Sun.COM>; Thu, 22 Jan 2009 01:35:23 -0800 (PST) Received: from brmea-mail-2.sun.com ([192.18.98.43]) by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0KDV00JTR9AYU320@nwk-avmta-1.sfbay.Sun.COM>; Thu, 22 Jan 2009 01:35:22 -0800 (PST) Received: from relay23.sun.com (relay23.sun.com [192.12.251.54] (may be forged)) by brmea-mail-2.sun.com (8.13.6+Sun/8.12.9) with ESMTP id n0M9ZMcs021333; Thu, 22 Jan 2009 09:35:22 +0000 (GMT) Received: from mms24es.mms.us.syntegra.com ([150.143.232.70] [150.143.232.70]) by relay23i.sun.com with ESMTP id BT-MMP-3413574; Thu, 22 Jan 2009 09:35:22 +0000 (Z) Received: from relay21.sun.com (relay21.sun.com [192.12.251.24]) by mms24es.mms.us.syntegra.com with ESMTP id BT-MMP-1076870; Thu, 22 Jan 2009 09:35:22 +0000 (Z) Received: from exchange.solarflare.com ([216.237.3.220] [216.237.3.220]) by relay21i.sun.com with ESMTP id BT-MMP-17186598; Thu, 22 Jan 2009 09:35:22 +0000 (Z) Received: from [10.17.20.48] ([10.17.20.48]) by exchange.solarflare.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.3959); Thu, 22 Jan 2009 01:35:21 -0800 Date: Thu, 22 Jan 2009 09:35:18 +0000 From: Paul Durrant Subject: Re: prefetch interfaces [PSARC/2009/039 Self Review] In-reply-to: <18807.23061.888203.839588@gargle.gargle.HOWL> To: James Carlson Cc: "Garrett D'Amore - sun microsystems" , PSARC-ext@sun.com Message-id: <49783DD6.7000604@solarflare.com> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7BIT X-PMX-Version: 5.4.1.325704 X-Brightmail-Tracker: AAAAAA== X-Antispam: No, score=0.0/5.0, scanned in 0.046sec at (localhost [127.0.0.1]) by smf-spamd v1.3.1 - http://smfs.sf.net/ References: <200901211650.n0LGojkZ011461@sac.sfbay.sun.com> <18807.23061.888203.839588@gargle.gargle.HOWL> User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) X-OriginalArrivalTime: 22 Jan 2009 09:35:21.0587 (UTC) FILETIME=[BECC2430:01C97C74] Status: RO Content-Length: 909 James Carlson wrote: > > Are there SPARC equivalents? Have you considered other CPUs? > Yes and, in fact, the names of the inlines correspond more to the SPARC nomenclature. I have implementations for both SPARC and x86. > On PPC, there are four related instructions that I know about: > > dcbt - data cache block touch > dcbtst - data cache block touch for store > dcbz - data cache block set to zero > dcbf - data cache block flush > > The first of those sounds like prefetch_read_many(). The others seem > not to match up ... but *perhaps* they're rare enough (buried within > bcopy and bzero) that nobody cares ... ? > I think the semantics of the inlines are general enough that they should apply to most architectures that support pre-fetching. Paul -- ============================== Paul Durrant Senior Staff Engineer Solarflare Communications Inc. ============================== From pdurrant@solarflare.com Thu Jan 22 01:38:02 2009 Received: from sunmail4.singapore.sun.com (sunmail4.Singapore.Sun.COM [129.158.71.19]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n0M9c0Ml012889 for ; Thu, 22 Jan 2009 01:38:01 -0800 (PST) Received: from nwk-avmta-1.SFBay.Sun.COM (nwk-avmta-1.SFBay.Sun.COM [129.146.11.74]) by sunmail4.singapore.sun.com (8.13.4+Sun/8.13.3/ENSMAIL,v2.2) with ESMTP id n0M9blQx029510 for <@sunmail2sca.sfbay.sun.com:PSARC-ext@sun.com>; Thu, 22 Jan 2009 17:38:00 +0800 (SGT) Received: from pmxchannel-daemon.nwk-avmta-1.sfbay.Sun.COM by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0KDV00M039F7MN00@nwk-avmta-1.sfbay.Sun.COM> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Thu, 22 Jan 2009 01:37:55 -0800 (PST) Received: from brmea-mail-4.sun.com ([192.18.98.36]) by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0KDV00J4S9F7U740@nwk-avmta-1.sfbay.Sun.COM> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Thu, 22 Jan 2009 01:37:55 -0800 (PST) Received: from relay21.sun.com (relay21.sun.com [192.12.251.24] (may be forged)) by brmea-mail-4.sun.com (8.13.6+Sun/8.12.9) with ESMTP id n0M9aFCJ028738 for ; Thu, 22 Jan 2009 09:37:54 +0000 (GMT) Received: from mms25es.mms.us.syntegra.com ([150.143.232.90] [150.143.232.90]) by relay21i.sun.com with ESMTP id BT-MMP-3413752 for PSARC-ext@sun.com; Thu, 22 Jan 2009 09:37:54 +0000 (Z) Received: from relay21.sun.com (relay21.sun.com [192.12.251.24]) by mms25es.mms.us.syntegra.com with ESMTP id BT-MMP-1070432 for PSARC-ext@sun.com; Thu, 22 Jan 2009 09:37:54 +0000 (Z) Received: from exchange.solarflare.com ([216.237.3.220] [216.237.3.220]) by relay21i.sun.com with ESMTP id BT-MMP-17188639 for PSARC-ext@sun.com; Thu, 22 Jan 2009 09:37:54 +0000 (Z) Received: from [10.17.20.48] ([10.17.20.48]) by exchange.solarflare.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.3959); Thu, 22 Jan 2009 01:37:51 -0800 Date: Thu, 22 Jan 2009 09:37:48 +0000 From: Paul Durrant Subject: Re: prefetch interfaces [PSARC/2009/039 Self Review] In-reply-to: <4977640B.A74632D0@nrubsig.org> To: Roland Mainz Cc: "Garrett D'Amore - sun microsystems" , PSARC-ext@sun.com Message-id: <49783E6C.4080903@solarflare.com> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7BIT X-PMX-Version: 5.4.1.325704 X-Brightmail-Tracker: AAAAAA== X-Antispam: No, score=0.0/5.0, scanned in 0.048sec at (localhost [127.0.0.1]) by smf-spamd v1.3.1 - http://smfs.sf.net/ References: <200901211650.n0LGojkZ011461@sac.sfbay.sun.com> <4977640B.A74632D0@nrubsig.org> User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) X-OriginalArrivalTime: 22 Jan 2009 09:37:51.0278 (UTC) FILETIME=[18052CE0:01C97C75] Status: RO Content-Length: 798 Roland Mainz wrote: > > Why do both interfaces do not have a |length| operand ? Some > CPUs/architecturs allow to define a memory range (rounded up to the CPUs > block size) to be pre-fetched... > Roland, The intention is to keep things simple. In case it was not apparent from my submission, the intention of the inlines is to pre-fetch single cache lines. Also, neither SPARC nor x86 have single prefetch instructions to fetch multiple cache lines so a length argument would be extraneous at this point. Remember that these interface are intended to be undocumented and unstable so any future changes that aid performance would be welcome. Paul -- ============================== Paul Durrant Senior Staff Engineer Solarflare Communications Inc. ============================== From pdurrant@solarflare.com Thu Jan 22 01:48:23 2009 Received: from sunmail4.singapore.sun.com (sunmail4.Singapore.Sun.COM [129.158.71.19]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n0M9mMGv013075 for ; Thu, 22 Jan 2009 01:48:23 -0800 (PST) Received: from nwk-avmta-1.SFBay.Sun.COM (nwk-avmta-1.SFBay.Sun.COM [129.146.11.74]) by sunmail4.singapore.sun.com (8.13.4+Sun/8.13.3/ENSMAIL,v2.2) with ESMTP id n0M9mI9w005706; Thu, 22 Jan 2009 17:48:19 +0800 (SGT) Received: from pmxchannel-daemon.nwk-avmta-1.sfbay.Sun.COM by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0KDV000019WHSN00@nwk-avmta-1.sfbay.Sun.COM>; Thu, 22 Jan 2009 01:48:17 -0800 (PST) Received: from brmea-mail-2.sun.com ([192.18.98.43]) by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0KDV00J4K9WGU550@nwk-avmta-1.sfbay.Sun.COM>; Thu, 22 Jan 2009 01:48:17 -0800 (PST) Received: from relay24.sun.com (relay24.sun.com [192.12.251.74] (may be forged)) by brmea-mail-2.sun.com (8.13.6+Sun/8.12.9) with ESMTP id n0M9jggm024546; Thu, 22 Jan 2009 09:48:16 +0000 (GMT) Received: from mms25es.mms.us.syntegra.com ([150.143.232.90] [150.143.232.90]) by relay24i.sun.com with ESMTP id BT-MMP-3414068; Thu, 22 Jan 2009 09:47:23 +0000 (Z) Received: from relay23.sun.com (relay23.sun.com [192.12.251.54]) by mms25es.mms.us.syntegra.com with ESMTP id BT-MMP-1085191; Thu, 22 Jan 2009 09:47:22 +0000 (Z) Received: from exchange.solarflare.com ([216.237.3.220] [216.237.3.220]) by relay23i.sun.com with ESMTP id BT-MMP-17211505; Thu, 22 Jan 2009 09:47:22 +0000 (Z) Received: from [10.17.20.48] ([10.17.20.48]) by exchange.solarflare.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.3959); Thu, 22 Jan 2009 01:47:22 -0800 Date: Thu, 22 Jan 2009 09:47:19 +0000 From: Paul Durrant Subject: Re: prefetch interfaces [PSARC/2009/039 Self Review] In-reply-to: <4977733B.2070804@Sun.COM> To: Bart Smaalders Cc: "Garrett D'Amore - sun microsystems" , PSARC-ext@sun.com Message-id: <497840A7.1020407@solarflare.com> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7BIT X-PMX-Version: 5.4.1.325704 X-Brightmail-Tracker: AAAAAA== X-Antispam: No, score=0.0/5.0, scanned in 0.046sec at (localhost [127.0.0.1]) by smf-spamd v1.3.1 - http://smfs.sf.net/ References: <200901211650.n0LGojkZ011461@sac.sfbay.sun.com> <4977733B.2070804@Sun.COM> User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) X-OriginalArrivalTime: 22 Jan 2009 09:47:22.0387 (UTC) FILETIME=[6C6D7E30:01C97C76] Status: RO Content-Length: 614 Bart Smaalders wrote: > > What about prefetch64()? > Hmm. That was integrated a long time after I did my implementations (that's how long I've been waiting to integrate!). It looks like it has the right semantics for x86 but the sparc implementation seems to be n_writes; I'm not sure what that will do. I'd be willing to drop this case and go with that interface though if the sparc prefetch does what I need (i.e. pull data into cache for multiple-read access). Paul -- ============================== Paul Durrant Senior Staff Engineer Solarflare Communications Inc. ============================== From pdurrant@solarflare.com Thu Jan 22 01:56:42 2009 Received: from sunmail5.uk.sun.com (sunmail5.UK.Sun.COM [129.156.85.165]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n0M9ufHO013394 for ; Thu, 22 Jan 2009 01:56:42 -0800 (PST) Received: from nwk-avmta-1.SFBay.Sun.COM (nwk-avmta-1.SFBay.Sun.COM [129.146.11.74]) by sunmail5.uk.sun.com (8.13.8+Sun/8.13.8/ENSMAIL,v2.2) with ESMTP id n0M9ucFC013522; Thu, 22 Jan 2009 09:56:39 GMT Received: from pmxchannel-daemon.nwk-avmta-1.sfbay.Sun.COM by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0KDV00107AAEXS00@nwk-avmta-1.sfbay.Sun.COM>; Thu, 22 Jan 2009 01:56:38 -0800 (PST) Received: from sca-ea-mail-3.sun.com ([192.18.43.21]) by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0KDV00JYNAAEU350@nwk-avmta-1.sfbay.Sun.COM>; Thu, 22 Jan 2009 01:56:38 -0800 (PST) Received: from relay14i.sun.com (ip124.net129179-4.block1.us.syntegra.com [129.179.4.124]) by sca-ea-mail-3.sun.com (8.13.6+Sun/8.12.9) with ESMTP id n0M9itEa028109; Thu, 22 Jan 2009 09:56:37 +0000 (GMT) Received: from mmp12es.mmp.us.syntegra.com ([160.41.208.12] [160.41.208.12]) by relay14i.sun.com with ESMTP id BT-MMP-2998861; Thu, 22 Jan 2009 09:56:37 +0000 (Z) Received: from relay11i.sun.com (relay11i.sun.com [129.179.4.121]) by mmp12es.mmp.us.syntegra.com with ESMTP id BT-MMP-804745; Thu, 22 Jan 2009 09:56:37 +0000 (Z) Received: from exchange.solarflare.com ([216.237.3.220] [216.237.3.220]) by relay1ib.sun.com with ESMTP id BT-MMP-23851925; Thu, 22 Jan 2009 09:56:37 +0000 (Z) Received: from [10.17.20.48] ([10.17.20.48]) by exchange.solarflare.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.3959); Thu, 22 Jan 2009 01:56:36 -0800 Date: Thu, 22 Jan 2009 09:56:33 +0000 From: Paul Durrant Subject: Re: prefetch interfaces [PSARC/2009/039 Self Review] In-reply-to: <497840A7.1020407@solarflare.com> To: Bart Smaalders Cc: "Garrett D'Amore - sun microsystems" , PSARC-ext@sun.com Message-id: <497842D1.30902@solarflare.com> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7BIT X-PMX-Version: 5.4.1.325704 X-Brightmail-Tracker: AAAAAA== X-Antispam: No, score=-0.2/5.0, scanned in 0.054sec at (localhost [127.0.0.1]) by smf-spamd v1.3.1 - http://smfs.sf.net/ References: <200901211650.n0LGojkZ011461@sac.sfbay.sun.com> <4977733B.2070804@Sun.COM> <497840A7.1020407@solarflare.com> User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) X-OriginalArrivalTime: 22 Jan 2009 09:56:36.0745 (UTC) FILETIME=[B6D9CF90:01C97C77] Status: RO Content-Length: 1175 Paul Durrant wrote: > > Hmm. That was integrated a long time after I did my implementations > (that's how long I've been waiting to integrate!). It looks like it has > the right semantics for x86 but the sparc implementation seems to be > n_writes; I'm not sure what that will do. > I'd be willing to drop this case and go with that interface though if > the sparc prefetch does what I need (i.e. pull data into cache for > multiple-read access). > I found my sparcv9 manual! Prefetching for n_writes apparently implies exclusivity of the cache line in the CPU issuing the prefetch so would cause unnecessary cache line flushing in my use-case. How about I add prefetch_wrote_once() and prefetch_write_many() (the once and many mapping to nta amd t0 for x86, as with read) to the set and then change the consumers of prefetch64() (of which there only appears to be one) to use prefetch_write_many()? That way things continue to work as-is and we cover the full set of prefetched on the current set of supported CPUs. Paul -- ============================== Paul Durrant Senior Staff Engineer Solarflare Communications Inc. ============================== From pdurrant@solarflare.com Thu Jan 22 01:57:35 2009 Received: from sunmail5.uk.sun.com (sunmail5.UK.Sun.COM [129.156.85.165]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n0M9vY1M013413 for ; Thu, 22 Jan 2009 01:57:35 -0800 (PST) Received: from nwk-avmta-1.SFBay.Sun.COM (nwk-avmta-1.SFBay.Sun.COM [129.146.11.74]) by sunmail5.uk.sun.com (8.13.8+Sun/8.13.8/ENSMAIL,v2.2) with ESMTP id n0M9vKB7013939; Thu, 22 Jan 2009 09:57:32 GMT Received: from pmxchannel-daemon.nwk-avmta-1.sfbay.Sun.COM by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0KDV0010LABUZW00@nwk-avmta-1.sfbay.Sun.COM>; Thu, 22 Jan 2009 01:57:30 -0800 (PST) Received: from brmea-mail-4.sun.com ([192.18.98.36]) by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0KDV00J2MABTU360@nwk-avmta-1.sfbay.Sun.COM>; Thu, 22 Jan 2009 01:57:30 -0800 (PST) Received: from relay12i.sun.com (ip122.net129179-4.block1.us.syntegra.com [129.179.4.122]) by brmea-mail-4.sun.com (8.13.6+Sun/8.12.9) with ESMTP id n0M9sg2K004569; Thu, 22 Jan 2009 09:57:29 +0000 (GMT) Received: from mmp13es.mmp.us.syntegra.com ([160.41.208.13] [160.41.208.13]) by relay12i.sun.com with ESMTP id BT-MMP-926292; Thu, 22 Jan 2009 09:57:29 +0000 (Z) Received: from relay15i.sun.com (relay15i.sun.com [129.179.4.125]) by mmp13es.mmp.us.syntegra.com with ESMTP id BT-MMP-44394; Thu, 22 Jan 2009 09:57:29 +0000 (Z) Received: from exchange.solarflare.com ([216.237.3.220] [216.237.3.220]) by relay1i.sun.com with ESMTP id BT-MMP-30162522; Thu, 22 Jan 2009 09:57:29 +0000 (Z) Received: from [10.17.20.48] ([10.17.20.48]) by exchange.solarflare.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.3959); Thu, 22 Jan 2009 01:57:28 -0800 Date: Thu, 22 Jan 2009 09:57:26 +0000 From: Paul Durrant Subject: Re: prefetch interfaces [PSARC/2009/039 Self Review] In-reply-to: <49775AE5.3010201@sun.com> To: Alan Coopersmith Cc: "Garrett D'Amore - sun microsystems" , PSARC-ext@sun.com Message-id: <49784306.7060605@solarflare.com> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8; format=flowed Content-transfer-encoding: 7BIT X-PMX-Version: 5.4.1.325704 X-Brightmail-Tracker: AAAAAA== X-Antispam: No, score=0.0/5.0, scanned in 0.043sec at (localhost [127.0.0.1]) by smf-spamd v1.3.1 - http://smfs.sf.net/ References: <200901211650.n0LGojkZ011461@sac.sfbay.sun.com> <49775AE5.3010201@sun.com> User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) X-OriginalArrivalTime: 22 Jan 2009 09:57:29.0074 (UTC) FILETIME=[D60A9520:01C97C77] Status: RO Content-Length: 448 Alan Coopersmith wrote: > How do these interfaces compare with the sun_prefetch.h ones provided > by Sun Studio? Is the difference just that these are compiler > independent? > Yes, you hit the nail on the head. These are not dependent on the compiler; they are implemented for gcc as well as studio. Paul -- ============================== Paul Durrant Senior Staff Engineer Solarflare Communications Inc. ============================== From gdamore@sun.com Tue Mar 17 14:23:02 2009 Received: from sunmail4.singapore.sun.com (sunmail4.Singapore.Sun.COM [129.158.71.19]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n2HLN2KY023210 for ; Tue, 17 Mar 2009 14:23:02 -0700 (PDT) Received: from nwk-avmta-1.SFBay.Sun.COM (nwk-avmta-1.SFBay.Sun.COM [129.146.11.74]) by sunmail4.singapore.sun.com (8.13.4+Sun/8.13.3/ENSMAIL,v2.2) with ESMTP id n2HLMt0W003819 for <@sunmail2sca.sfbay.sun.com:PSARC-ext@sun.com>; Wed, 18 Mar 2009 05:23:01 +0800 (SGT) Received: from pmxchannel-daemon.nwk-avmta-1.sfbay.Sun.COM by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0KGO0034I62BE200@nwk-avmta-1.sfbay.Sun.COM> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Tue, 17 Mar 2009 14:22:59 -0700 (PDT) Received: from sca-es-mail-1.sun.com ([192.18.43.132]) by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0KGO00AVJ62A0FD0@nwk-avmta-1.sfbay.Sun.COM> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Tue, 17 Mar 2009 14:22:58 -0700 (PDT) Received: from fe-sfbay-09.sun.com ([192.18.43.129]) by sca-es-mail-1.sun.com (8.13.7+Sun/8.12.9) with ESMTP id n2HLMwF7024510 for ; Tue, 17 Mar 2009 14:22:58 -0700 (PDT) Received: from conversion-daemon.fe-sfbay-09.sun.com by fe-sfbay-09.sun.com (Sun Java(tm) System Messaging Server 7.0-5.01 64bit (built Feb 19 2009)) id <0KGO00F005UVUM00@fe-sfbay-09.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Tue, 17 Mar 2009 14:22:58 -0700 (PDT) Received: from [192.168.251.11] ([unknown] [76.93.15.33]) by fe-sfbay-09.sun.com (Sun Java(tm) System Messaging Server 7.0-5.01 64bit (built Feb 19 2009)) with ESMTPSA id <0KGO00EFE627RJ20@fe-sfbay-09.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Tue, 17 Mar 2009 14:22:56 -0700 (PDT) Date: Tue, 17 Mar 2009 14:22:55 -0700 From: "Garrett D'Amore" Subject: PSARC 2009/039 prefetch interfaces Sender: Garrett.Damore@sun.com To: PSARC-ext Message-id: <49C014AF.6040109@sun.com> MIME-version: 1.0 Content-type: text/plain; format=flowed; charset=ISO-8859-1 Content-transfer-encoding: 7BIT X-PMX-Version: 5.4.1.325704 User-Agent: Thunderbird 2.0.0.18 (X11/20081201) Status: RO Content-Length: 474 I have to apologize to Paul here, but I neglected to update the IAM file to indicate that this is a fast track, so I don't think the "litany" was ever run on this case. I'm updating the IAM file now, and I'm pushing the timeout on this to next Wednesday. However, I believe that all the material concerns were addressed in the case history by Paul already, and I don't see why this case can't be approved tomorrow. Can I get a +1 from a member? :-) -- Garrett From carlsonj@phorcys.east.sun.com Tue Mar 17 14:41:26 2009 Received: from sunmail5.uk.sun.com (sunmail5.UK.Sun.COM [129.156.85.165]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n2HLfPEo023808 for ; Tue, 17 Mar 2009 14:41:25 -0700 (PDT) Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6]) by sunmail5.uk.sun.com (8.13.8+Sun/8.13.8/ENSMAIL,v2.2) with ESMTP id n2HLfMrN001767; Tue, 17 Mar 2009 21:41:23 GMT Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0KGO00C076WY0000@nwk-avmta-2.sfbay.sun.com>; Tue, 17 Mar 2009 14:41:22 -0700 (PDT) Received: from phorcys.east.sun.com ([129.148.174.143]) by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0KGO007316WXRJB0@nwk-avmta-2.sfbay.sun.com>; Tue, 17 Mar 2009 14:41:21 -0700 (PDT) Received: from phorcys.east.sun.com (localhost [127.0.0.1]) by phorcys.east.sun.com (8.14.3+Sun/8.14.3) with ESMTP id n2HLfDf0015701; Tue, 17 Mar 2009 17:41:13 -0400 (EDT) Received: (from carlsonj@localhost) by phorcys.east.sun.com (8.14.3+Sun/8.14.3/Submit) id n2HLfDpk015698; Tue, 17 Mar 2009 17:41:13 -0400 (EDT) Date: Tue, 17 Mar 2009 17:41:13 -0400 From: James Carlson Subject: Re: PSARC 2009/039 prefetch interfaces In-reply-to: <49C014AF.6040109@sun.com> To: "Garrett D'Amore" Cc: PSARC-ext Message-id: <18880.6393.556664.951029@gargle.gargle.HOWL> MIME-version: 1.0 X-Mailer: VM 7.01 under Emacs 21.3.1 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7BIT X-PMX-Version: 5.4.1.325704 References: <49C014AF.6040109@sun.com> Status: RO Content-Length: 1132 Garrett D'Amore writes: > I have to apologize to Paul here, but I neglected to update the IAM file > to indicate that this is a fast track, so I don't think the "litany" was > ever run on this case. I'm updating the IAM file now, and I'm pushing > the timeout on this to next Wednesday. > > However, I believe that all the material concerns were addressed in the > case history by Paul already, and I don't see why this case can't be > approved tomorrow. Can I get a +1 from a member? :-) Can we have a summary of the proposal? I *think* we currently have Consolidation Private stability (within ON) and Patch/Micro release binding for: void prefetch_read_once(void *) void prefetch_read_many(void *) void prefetch_wrote_once(void *) void prefetch_write_many(void *) (With the odd write/wrote distinction and with the arguments not const'd the way I would ordinarily have expected.) Is this it? -- James Carlson, Solaris Networking Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677 From pdurrant@solarflare.com Wed Mar 18 02:02:37 2009 Received: from newsunmail1brm.central.sun.com (newsunmail1brm.Central.Sun.COM [129.147.62.245]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n2I92b1J023507 for ; Wed, 18 Mar 2009 02:02:37 -0700 (PDT) Received: from brm-avmta-1.central.sun.com (brm-avmta-1.Central.Sun.COM [129.147.4.11]) by newsunmail1brm.central.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id n2I92Zij062937; Wed, 18 Mar 2009 03:02:35 -0600 (MDT) Received: from pmxchannel-daemon.brm-avmta-1.central.sun.com by brm-avmta-1.central.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0KGP00A032GBPY00@brm-avmta-1.central.sun.com>; Wed, 18 Mar 2009 03:02:35 -0600 (MDT) Received: from sca-ea-mail-2.sun.com ([192.18.43.25]) by brm-avmta-1.central.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0KGP006QM2GBM520@brm-avmta-1.central.sun.com>; Wed, 18 Mar 2009 03:02:35 -0600 (MDT) Received: from relay41i.sun.com ([192.5.209.70]) by sca-ea-mail-2.sun.com (8.13.7+Sun/8.12.9) with ESMTP id n2I8qZ86028182; Wed, 18 Mar 2009 09:02:34 +0000 (GMT) Received: from mms49es.mms.us.syntegra.com ([160.41.221.232] [160.41.221.232]) by relay41i.sun.com with ESMTP id BT-MMP-2361000; Wed, 18 Mar 2009 09:02:30 +0000 (Z) Received: from relay45i.sun.com (relay45i.sun.com [192.5.209.94]) by mms49es.mms.us.syntegra.com with ESMTP id BT-MMP-33081121; Wed, 18 Mar 2009 09:02:30 +0000 (Z) Received: from exchange.solarflare.com ([216.237.3.220] [216.237.3.220]) by relay4i.sun.com with ESMTP id BT-MMP-31210139; Wed, 18 Mar 2009 09:02:30 +0000 (Z) Received: from [192.168.1.2] ([195.137.14.130]) by exchange.solarflare.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.3959); Wed, 18 Mar 2009 02:02:29 -0700 Date: Wed, 18 Mar 2009 09:02:26 +0000 From: Paul Durrant Subject: Re: PSARC 2009/039 prefetch interfaces In-reply-to: <18880.6393.556664.951029@gargle.gargle.HOWL> To: James Carlson Cc: "Garrett D'Amore" , PSARC-ext Message-id: <49C0B8A2.2060807@solarflare.com> Organization: SolarFlare Communications Inc. MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7BIT X-Accept-Language: en-us, en X-PMX-Version: 5.4.1.325704 X-Brightmail-Tracker: AAAAAA== X-Antispam: No, score=0.0/5.0, scanned in 0.040sec at (localhost [127.0.0.1]) by smf-spamd v1.3.1 - http://smfs.sf.net/ References: <49C014AF.6040109@sun.com> <18880.6393.556664.951029@gargle.gargle.HOWL> User-Agent: Mozilla Thunderbird 1.0.2 (Macintosh/20050317) X-OriginalArrivalTime: 18 Mar 2009 09:02:29.0928 (UTC) FILETIME=[44511A80:01C9A7A8] Status: RO Content-Length: 512 James Carlson wrote: > > void prefetch_read_once(void *) > void prefetch_read_many(void *) > void prefetch_wrote_once(void *) > void prefetch_write_many(void *) > > (With the odd write/wrote distinction and with the arguments not > const'd the way I would ordinarily have expected.) > > Is this it? > It should be prefetch_write_once(void *) and I don't believe const is appropriate here since the pointers are most likely to be to data that would ordinarily change (DMA buffers in my use case). Paul From carlsonj@phorcys.east.sun.com Wed Mar 18 05:20:50 2009 Received: from newsunmail1brm.central.sun.com (newsunmail1brm.Central.Sun.COM [129.147.62.245]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n2ICKoks019877 for ; Wed, 18 Mar 2009 05:20:50 -0700 (PDT) Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6]) by newsunmail1brm.central.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id n2ICKmf4060448; Wed, 18 Mar 2009 06:20:49 -0600 (MDT) Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0KGP00J0DBMN8000@nwk-avmta-2.sfbay.sun.com>; Wed, 18 Mar 2009 05:20:47 -0700 (PDT) Received: from phorcys.east.sun.com ([129.148.174.143]) by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0KGP00EQFBMLRO30@nwk-avmta-2.sfbay.sun.com>; Wed, 18 Mar 2009 05:20:45 -0700 (PDT) Received: from phorcys.east.sun.com (localhost [127.0.0.1]) by phorcys.east.sun.com (8.14.3+Sun/8.14.3) with ESMTP id n2ICD8g0007142; Wed, 18 Mar 2009 08:13:08 -0400 (EDT) Received: (from carlsonj@localhost) by phorcys.east.sun.com (8.14.3+Sun/8.14.3/Submit) id n2ICD8Gn007139; Wed, 18 Mar 2009 08:13:08 -0400 (EDT) Date: Wed, 18 Mar 2009 08:13:08 -0400 From: James Carlson Subject: Re: PSARC 2009/039 prefetch interfaces In-reply-to: <49C0B8A2.2060807@solarflare.com> To: Paul Durrant Cc: "Garrett D'Amore" , PSARC-ext Message-id: <18880.58708.21924.537943@gargle.gargle.HOWL> MIME-version: 1.0 X-Mailer: VM 7.01 under Emacs 21.3.1 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7BIT X-PMX-Version: 5.4.1.325704 References: <49C014AF.6040109@sun.com> <18880.6393.556664.951029@gargle.gargle.HOWL> <49C0B8A2.2060807@solarflare.com> Status: RO Content-Length: 1784 Paul Durrant writes: > James Carlson wrote: > > > > void prefetch_read_once(void *) > > void prefetch_read_many(void *) > > void prefetch_wrote_once(void *) > > void prefetch_write_many(void *) > > > > (With the odd write/wrote distinction and with the arguments not > > const'd the way I would ordinarily have expected.) > > > > Is this it? > > > > It should be prefetch_write_once(void *) That's better. > and I don't believe const is > appropriate here since the pointers are most likely to be to data that > would ordinarily change (DMA buffers in my use case). The function itself doesn't actually cause that to happen, though; the hardware does. Even if you didn't mess with the prefetch, these buffer content changes would *still* appear. The compiler needn't assume that the buffer changes as a specific synchronous effect of that function. Instead, _your_ code needs to be aware of the fact that there's an unseen hand that's twiddling the bits, which is the definition of the 'volatile' keyword. You need 'volatile' on your pointers to generate correct code, but I don't think these functions need writability to operate. In fact, as a very narrow use-case, consider a read-only device. Your pointer would be something like "const volatile uchar_t *", to indicate that your code can't write to it (const) and that references can't be optimized because it changes in ways not obvious in the code (volatile). Anyway, I think that's probably a nit for the prefetch_read_* functions. After fixing "wrote" to "write," I'll give it a +1. -- James Carlson, Solaris Networking Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677 From gdamore@sun.com Wed Mar 18 19:40:57 2009 Received: from sunmail5.uk.sun.com (sunmail5.UK.Sun.COM [129.156.85.165]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n2J2euIe026396 for ; Wed, 18 Mar 2009 19:40:57 -0700 (PDT) Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6]) by sunmail5.uk.sun.com (8.13.8+Sun/8.13.8/ENSMAIL,v2.2) with ESMTP id n2J2eoJR007401 for <@sunmail2sca.sfbay.sun.com:PSARC-ext@sun.com>; Thu, 19 Mar 2009 02:40:56 GMT Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0KGQ00J07FG7OB00@nwk-avmta-2.sfbay.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 18 Mar 2009 19:40:55 -0700 (PDT) Received: from sca-es-mail-2.sun.com ([192.18.43.133]) by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0KGQ006RGFG7T4C0@nwk-avmta-2.sfbay.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 18 Mar 2009 19:40:55 -0700 (PDT) Received: from fe-sfbay-09.sun.com ([192.18.43.129]) by sca-es-mail-2.sun.com (8.13.7+Sun/8.12.9) with ESMTP id n2J2etpC028352 for ; Wed, 18 Mar 2009 19:40:55 -0700 (PDT) Received: from conversion-daemon.fe-sfbay-09.sun.com by fe-sfbay-09.sun.com (Sun Java(tm) System Messaging Server 7.0-5.01 64bit (built Feb 19 2009)) id <0KGQ00G00FEMOR00@fe-sfbay-09.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 18 Mar 2009 19:40:54 -0700 (PDT) Received: from [192.168.251.11] ([unknown] [76.93.15.33]) by fe-sfbay-09.sun.com (Sun Java(tm) System Messaging Server 7.0-5.01 64bit (built Feb 19 2009)) with ESMTPSA id <0KGQ00BHCFG4ZB10@fe-sfbay-09.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 18 Mar 2009 19:40:53 -0700 (PDT) Date: Wed, 18 Mar 2009 19:40:52 -0700 From: "Garrett D'Amore" Subject: PSARC 2009/039 prefetch interfaces Sender: Garrett.Damore@sun.com To: PSARC-ext Message-id: <49C1B0B4.3060604@sun.com> MIME-version: 1.0 Content-type: text/plain; format=flowed; charset=ISO-8859-1 Content-transfer-encoding: 7BIT X-PMX-Version: 5.4.1.325704 User-Agent: Thunderbird 2.0.0.18 (X11/20081201) Status: RO Content-Length: 39 This case was approved at PSARC today.