From sacadmin Wed Sep 16 08:19:22 2009 Received: from sac.sfbay.sun.com (localhost [127.0.0.1]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n8GFJMeB026234; Wed, 16 Sep 2009 08:19:22 -0700 (PDT) Received: (from ab196087@localhost) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8/Submit) id n8GFJMMT026230; Wed, 16 Sep 2009 08:19:22 -0700 (PDT) Date: Wed, 16 Sep 2009 08:19:22 -0700 (PDT) From: Ali Bahrami Message-Id: <200909161519.n8GFJMMT026230@sac.sfbay.sun.com> To: PSARC-record@sac.sfbay.sun.com Subject: ld -z wrap option [PSARC/2009/493 Self Review] Status: RO Content-Length: 554 Template Version: @(#)sac_nextcase 1.68 02/23/09 SMI This information is Copyright 2009 Sun Microsystems 1. Introduction 1.1. Project/Component Working Name: ld -z wrap option 1.2. Name of Document Author/Supplier: Author: Ali Bahrami 1.3 Date of This Document: 16 September, 2009 4. Technical Description See the case directory for more detail 6. Resources and Schedule 6.4. Steering Committee requested information 6.4.1. Consolidation C-team Name: on 6.5. ARC review type: Automatic 6.6. ARC Exposure: open From Ali.Bahrami@sun.com Wed Sep 16 08:23:55 2009 Received: from sunmail3mpk.sfbay.sun.com (sunmail3mpk.SFBay.Sun.COM [129.146.11.52]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n8GFNsAm026370 for ; Wed, 16 Sep 2009 08:23:54 -0700 (PDT) Received: from nwk-avmta-1.SFBay.Sun.COM (nwk-avmta-1.SFBay.Sun.COM [129.146.11.74]) by sunmail3mpk.sfbay.sun.com (8.13.8+Sun/8.13.8/ENSMAIL,v2.4) with ESMTP id n8GFNrbq017801 for <@sunmail2sca.sfbay.sun.com:psarc-ext@sun.com>; Wed, 16 Sep 2009 08:23:54 -0700 (PDT) Received: from pmxchannel-daemon.nwk-avmta-1.sfbay.Sun.COM by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0KQ200K1JLFTJ000@nwk-avmta-1.sfbay.Sun.COM> for psarc-ext@sun.com (ORCPT psarc-ext@sun.com); Wed, 16 Sep 2009 08:23:53 -0700 (PDT) Received: from brmea-mail-1.sun.com ([192.18.98.31]) by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0KQ200IB6LFRP630@nwk-avmta-1.sfbay.Sun.COM> for psarc-ext@sun.com (ORCPT psarc-ext@sun.com); Wed, 16 Sep 2009 08:23:51 -0700 (PDT) Received: from fe-amer-09.sun.com ([192.18.109.79]) by brmea-mail-1.sun.com (8.13.6+Sun/8.12.9) with ESMTP id n8GFNpAg003138 for ; Wed, 16 Sep 2009 15:23:51 +0000 (GMT) Received: from conversion-daemon.mail-amer.sun.com by mail-amer.sun.com (Sun Java(tm) System Messaging Server 7u2-7.04 64bit (built Jul 2 2009)) id <0KQ200K00I1M0K00@mail-amer.sun.com> for psarc-ext@sun.com (ORCPT psarc-ext@sun.com); Wed, 16 Sep 2009 09:23:51 -0600 (MDT) Received: from [172.20.25.67] ([unknown] [172.20.25.67]) by mail-amer.sun.com (Sun Java(tm) System Messaging Server 7u2-7.04 64bit (built Jul 2 2009)) with ESMTPSA id <0KQ200JPZLFJQMC0@mail-amer.sun.com> for psarc-ext@sun.com (ORCPT psarc-ext@sun.com); Wed, 16 Sep 2009 09:23:43 -0600 (MDT) Date: Wed, 16 Sep 2009 09:22:03 -0600 From: Ali Bahrami Subject: PSARC 2009/493 ld -z wrap option Sender: Ali.Bahrami@sun.com To: PSARC-ext@sun.com Message-id: <4AB1029B.7090903@Sun.COM> MIME-version: 1.0 Content-type: text/plain; CHARSET=US-ASCII; format=flowed Content-transfer-encoding: 7BIT X-PMX-Version: 5.4.1.325704 User-Agent: Thunderbird 2.0.0.22 (X11/20090816) Status: RO Content-Length: 3778 I am sponsoring the following self-reviewed case for myself. It adds a new option (-z wrap=symbol) to the Solaris link-editor (ld) along with two synonyms: -wrap=symbol and --wrap=symbol. I believe it qualifies for self review: - This is a GNU familiarity case --- the GNU ld used by Linux accepts the -wrap/--wrap options and it is used by software of importance to Solaris (Xorg). - We have established precedent for providing GNU ld options to ease building of open source software on our platform. One example is: PSARC 2008/583 add gld options to ld(1) - There are no backward compatibility issues with the proposed syntax, and the form of the syntax does not break new ground. The wrap option tells the link-editor to rename function references in a systematic way that allows the user to link "wrapper" functions against already compiled code. The user of this feature supplies the wrapper functions. This feature will be integrated as: 6850768 ld option to autogenerate wrappers/interposers similar to GNU ld --wrap Documentation for the original GNU ld feature can be found at: http://sourceware.org/binutils/docs-2.19/ld/Options.html#index-g_t_002d_002dwrap-249 Diffs for the changes to the proposed new ld(1) manpage are shown below. ----- Release Binding: Patch/Micro New ld options: -z wrap Committed -wrap Committed --wrap Committed ----- *** ld.orig Mon Aug 24 14:38:24 2009 --- ld.new Tue Sep 15 13:28:59 2009 *************** *** 30,36 **** [-z preinitarray=function] [-z redlocsym] [-z relaxreloc] [-z rescan-now] [-z recan] [-z rescan-start ... -z rescan-end]] [-z target=sparc|x86] [-z text | textwarn | textoff] ! [-z verbose] filename... DESCRIPTION --- 30,36 ---- [-z preinitarray=function] [-z redlocsym] [-z relaxreloc] [-z rescan-now] [-z recan] [-z rescan-start ... -z rescan-end]] [-z target=sparc|x86] [-z text | textwarn | textoff] ! [-z verbose] [-z wrap=symbol] filename... DESCRIPTION *************** *** 1114,1119 **** --- 1114,1152 ---- are deemed too noisy to be generated by default. + -z wrap=symbol + -wrap=symbol + --wrap=symbol + + Rename undefined references to symbol in order to allow wrapper + code to be linked into the output object without having to modify + source code. When -z wrap is specified, all undefined references + to symbol are modified to reference __wrap_symbol, and all + references to __real_symbol are modified to reference symbol. The + user is expected to provide an object containing the __wrap_symbol + function. This wrapper function can call __real_symbol in order to + reference the actual function being wrapped. + + The following is an example of a wrapper for the malloc() function: + + void * + __wrap_malloc (size_t c) + { + printf ("malloc called with %zu\n", c); + return __real_malloc (c); + } + + If you link other code with this file using -z wrap=malloc to + compile all the objects, then all calls to malloc will call the + function __wrap_malloc instead. The call to __real_malloc in + __wrap_malloc will call the real malloc function. + + The real and wrapped functions should be maintained in separate + source files. Otherwise, the compiler or assembler may resolve + the call instead of leaving that operation for the link-editor + to carry out, and prevent the wrap from occurring. + + ENVIRONMENT VARIABLES LD_ALTEXEC From gdamore@sun.com Wed Sep 16 08:35:17 2009 Received: from sunmail5.uk.sun.com (sunmail5.UK.Sun.COM [129.156.85.165]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n8GFZGiv026626 for ; Wed, 16 Sep 2009 08:35:16 -0700 (PDT) Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6]) by sunmail5.uk.sun.com (8.13.8+Sun/8.13.8/ENSMAIL,v2.2) with ESMTP id n8GFZD6l015043 for <@sunmail2sca.sfbay.sun.com:PSARC-ext@sun.com>; Wed, 16 Sep 2009 16:35:15 +0100 (BST) Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0KQ200323LYQ9600@nwk-avmta-2.sfbay.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 16 Sep 2009 08:35:14 -0700 (PDT) Received: from sca-es-mail-2.sun.com ([192.18.43.133]) by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0KQ20012PLYQZ130@nwk-avmta-2.sfbay.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 16 Sep 2009 08:35:14 -0700 (PDT) Received: from fe-sfbay-10.sun.com ([192.18.43.129]) by sca-es-mail-2.sun.com (8.13.7+Sun/8.12.9) with ESMTP id n8GFZEDJ017246 for ; Wed, 16 Sep 2009 08:35:14 -0700 (PDT) Received: from conversion-daemon.fe-sfbay-10.sun.com by fe-sfbay-10.sun.com (Sun Java(tm) System Messaging Server 7u2-7.04 64bit (built Jul 2 2009)) id <0KQ200M00LCPTJ00@fe-sfbay-10.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 16 Sep 2009 08:35:14 -0700 (PDT) Received: from [192.168.251.11] ([unknown] [76.93.15.33]) by fe-sfbay-10.sun.com (Sun Java(tm) System Messaging Server 7u2-7.04 64bit (built Jul 2 2009)) with ESMTPSA id <0KQ20076XLYPDC30@fe-sfbay-10.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 16 Sep 2009 08:35:13 -0700 (PDT) Date: Wed, 16 Sep 2009 08:35:13 -0700 From: "Garrett D'Amore" Subject: Re: PSARC 2009/493 ld -z wrap option In-reply-to: <4AB1029B.7090903@Sun.COM> Sender: Garrett.Damore@sun.com To: Ali Bahrami Cc: PSARC-ext@sun.com Message-id: <4AB105B1.3070200@sun.com> MIME-version: 1.0 Content-type: text/plain; CHARSET=US-ASCII; format=flowed Content-transfer-encoding: 7BIT X-PMX-Version: 5.4.1.325704 References: <4AB1029B.7090903@Sun.COM> User-Agent: Thunderbird 2.0.0.18 (X11/20081201) Status: RO Content-Length: 4771 This looks like a potentially handy feature, and the architecture seems fairly straight-forward. However, I'm not sure it qualifies for self-review. (Although the bar for self review seems to be moving somewhat...) If only because it introduces new interfaces and behavior for consumers. I'd suggest that this maybe should be a fast-track instead of self review, unless there is some particular rush to get this case through? Please consider promoting it to a fast track. In any case, I'll happily give it a +1. Btw, you failed to specify a release binding. Is this patch or minor (or something else)? (It looks like this could be Patch binding fairly easily...) - Garrett Ali Bahrami wrote: > I am sponsoring the following self-reviewed case for myself. > > It adds a new option (-z wrap=symbol) to the Solaris link-editor (ld) > along with two synonyms: -wrap=symbol and --wrap=symbol. > > I believe it qualifies for self review: > > - This is a GNU familiarity case --- the GNU ld used by Linux accepts > the -wrap/--wrap options and it is used by software of > importance to > Solaris (Xorg). > > - We have established precedent for providing GNU ld options to ease > building of open source software on our platform. One example is: > > PSARC 2008/583 add gld options to ld(1) > > - There are no backward compatibility issues with the proposed > syntax, > and the form of the syntax does not break new ground. > > The wrap option tells the link-editor to rename function references > in a systematic way that allows the user to link "wrapper" functions > against already compiled code. The user of this feature supplies the > wrapper functions. This feature will be integrated as: > > 6850768 ld option to autogenerate wrappers/interposers similar to > GNU ld --wrap > > Documentation for the original GNU ld feature can be found at: > > > http://sourceware.org/binutils/docs-2.19/ld/Options.html#index-g_t_002d_002dwrap-249 > > > Diffs for the changes to the proposed new ld(1) manpage are shown below. > > ----- > > Release Binding: Patch/Micro > > New ld options: > -z wrap Committed > -wrap Committed > --wrap Committed > > ----- > > *** ld.orig Mon Aug 24 14:38:24 2009 > --- ld.new Tue Sep 15 13:28:59 2009 > *************** > *** 30,36 **** > [-z preinitarray=function] [-z redlocsym] [-z relaxreloc] > [-z rescan-now] [-z recan] [-z rescan-start ... -z rescan-end]] > [-z target=sparc|x86] [-z text | textwarn | textoff] > ! [-z verbose] filename... > > > DESCRIPTION > --- 30,36 ---- > [-z preinitarray=function] [-z redlocsym] [-z relaxreloc] > [-z rescan-now] [-z recan] [-z rescan-start ... -z rescan-end]] > [-z target=sparc|x86] [-z text | textwarn | textoff] > ! [-z verbose] [-z wrap=symbol] filename... > > > DESCRIPTION > *************** > *** 1114,1119 **** > --- 1114,1152 ---- > are deemed too noisy to be generated by default. > > > + -z wrap=symbol > + -wrap=symbol > + --wrap=symbol > + > + Rename undefined references to symbol in order to allow > wrapper > + code to be linked into the output object without having to > modify > + source code. When -z wrap is specified, all undefined > references > + to symbol are modified to reference __wrap_symbol, and all > + references to __real_symbol are modified to reference > symbol. The > + user is expected to provide an object containing the > __wrap_symbol > + function. This wrapper function can call __real_symbol in > order to > + reference the actual function being wrapped. > + > + The following is an example of a wrapper for the malloc() > function: > + > + void * > + __wrap_malloc (size_t c) > + { > + printf ("malloc called with %zu\n", c); > + return __real_malloc (c); > + } > + > + If you link other code with this file using -z wrap=malloc to > + compile all the objects, then all calls to malloc will call > the > + function __wrap_malloc instead. The call to __real_malloc in > + __wrap_malloc will call the real malloc function. > + > + The real and wrapped functions should be maintained in > separate > + source files. Otherwise, the compiler or assembler may resolve > + the call instead of leaving that operation for the link-editor > + to carry out, and prevent the wrap from occurring. > + > + > ENVIRONMENT VARIABLES > LD_ALTEXEC > From Darren.Moffat@sun.com Wed Sep 16 08:43:30 2009 Received: from sunmail5.uk.sun.com (sunmail5.UK.Sun.COM [129.156.85.165]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n8GFhS7p026748 for ; Wed, 16 Sep 2009 08:43:28 -0700 (PDT) Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6]) by sunmail5.uk.sun.com (8.13.8+Sun/8.13.8/ENSMAIL,v2.2) with ESMTP id n8GFhHPg020362 for <@sunmail2sca.sfbay.sun.com:PSARC-ext@sun.com>; Wed, 16 Sep 2009 16:43:27 +0100 (BST) Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0KQ200307MCEPL00@nwk-avmta-2.sfbay.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 16 Sep 2009 08:43:26 -0700 (PDT) Received: from gmp-eb-inf-1.sun.com ([192.18.6.21]) by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0KQ2001C6MCCZ140@nwk-avmta-2.sfbay.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 16 Sep 2009 08:43:25 -0700 (PDT) Received: from fe-emea-09.sun.com (gmp-eb-lb-1-fe1.eu.sun.com [192.18.6.7] (may be forged)) by gmp-eb-inf-1.sun.com (8.13.7+Sun/8.12.9) with ESMTP id n8GFhNKQ002417 for ; Wed, 16 Sep 2009 15:43:23 +0000 (GMT) Received: from conversion-daemon.fe-emea-09.sun.com by fe-emea-09.sun.com (Sun Java(tm) System Messaging Server 7u2-7.04 64bit (built Jul 2 2009)) id <0KQ200E00MBVF300@fe-emea-09.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 16 Sep 2009 16:43:23 +0100 (BST) Received: from [192.168.1.105] (cpc2-rdng20-2-0-cust917.15-3.cable.virginmedia.com [86.28.167.150]) by fe-emea-09.sun.com (Sun Java(tm) System Messaging Server 7u2-7.04 64bit (built Jul 2 2009)) with ESMTPSA id <0KQ2009JLMCAE580@fe-emea-09.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 16 Sep 2009 16:43:23 +0100 (BST) Date: Wed, 16 Sep 2009 16:43:22 +0100 From: Darren J Moffat Subject: Re: PSARC 2009/493 ld -z wrap option In-reply-to: <4AB105B1.3070200@sun.com> Sender: Darren.Moffat@sun.com To: "Garrett D'Amore" Cc: Ali Bahrami , PSARC-ext@sun.com Message-id: <4AB1079A.1090707@Sun.COM> MIME-version: 1.0 Content-type: text/plain; CHARSET=US-ASCII; format=flowed Content-transfer-encoding: 7BIT X-PMX-Version: 5.4.1.325704 References: <4AB1029B.7090903@Sun.COM> <4AB105B1.3070200@sun.com> User-Agent: Thunderbird 2.0.0.22 (X11/20090818) Status: RO Content-Length: 848 Garrett D'Amore wrote: > This looks like a potentially handy feature, and the architecture seems > fairly straight-forward. However, I'm not sure it qualifies for > self-review. (Although the bar for self review seems to be moving > somewhat...) If only because it introduces new interfaces and behavior > for consumers. > > I'd suggest that this maybe should be a fast-track instead of self > review, unless there is some particular rush to get this case through? > Please consider promoting it to a fast track. In any case, I'll happily > give it a +1. Given this is being included explicitly for compatibility with GNU ld there is nothing ARC can change anyway. It is only a +1 or rederail and vote no type of case. So I really don't see the point in adding pointless extra process for a case like this. -- Darren J Moffat From Ali.Bahrami@Sun.COM Wed Sep 16 08:48:05 2009 Received: from newsunmail1brm.central.sun.com (newsunmail1brm.Central.Sun.COM [129.147.62.245]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n8GFm5kr026780 for ; Wed, 16 Sep 2009 08:48:05 -0700 (PDT) Received: from nwk-avmta-2.sfbay.sun.com (nwk-avmta-2.SFBay.Sun.COM [129.145.155.6]) by newsunmail1brm.central.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.2) with ESMTP id n8GFlvF8056709 for <@sunmail2sca.sfbay.sun.com:PSARC-ext@sun.com>; Wed, 16 Sep 2009 09:48:04 -0600 (MDT) Received: from pmxchannel-daemon.nwk-avmta-2.sfbay.sun.com by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0KQ20031JMK3YS00@nwk-avmta-2.sfbay.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 16 Sep 2009 08:48:03 -0700 (PDT) Received: from brmea-mail-1.sun.com ([192.18.98.31]) by nwk-avmta-2.sfbay.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0KQ2001YHMK2Z230@nwk-avmta-2.sfbay.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 16 Sep 2009 08:48:03 -0700 (PDT) Received: from fe-amer-09.sun.com ([192.18.109.79]) by brmea-mail-1.sun.com (8.13.6+Sun/8.12.9) with ESMTP id n8GFm2eZ017042 for ; Wed, 16 Sep 2009 15:48:02 +0000 (GMT) Received: from conversion-daemon.mail-amer.sun.com by mail-amer.sun.com (Sun Java(tm) System Messaging Server 7u2-7.04 64bit (built Jul 2 2009)) id <0KQ200000LNG1U00@mail-amer.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 16 Sep 2009 09:48:02 -0600 (MDT) Received: from [172.20.25.67] ([unknown] [172.20.25.67]) by mail-amer.sun.com (Sun Java(tm) System Messaging Server 7u2-7.04 64bit (built Jul 2 2009)) with ESMTPSA id <0KQ2005VEMK2MB90@mail-amer.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 16 Sep 2009 09:48:02 -0600 (MDT) Date: Wed, 16 Sep 2009 09:46:22 -0600 From: Ali Bahrami Subject: Re: PSARC 2009/493 ld -z wrap option In-reply-to: <4AB105B1.3070200@sun.com> Sender: Ali.Bahrami@Sun.COM To: "Garrett D'Amore" Cc: PSARC-ext@Sun.COM Message-id: <4AB1084E.402@Sun.COM> MIME-version: 1.0 Content-type: text/plain; CHARSET=US-ASCII; format=flowed Content-transfer-encoding: 7BIT X-PMX-Version: 5.4.1.325704 References: <4AB1029B.7090903@Sun.COM> <4AB105B1.3070200@sun.com> User-Agent: Thunderbird 2.0.0.22 (X11/20090816) Status: RO Content-Length: 1334 Garrett D'Amore wrote: > This looks like a potentially handy feature, and the architecture seems > fairly straight-forward. However, I'm not sure it qualifies for > self-review. (Although the bar for self review seems to be moving > somewhat...) If only because it introduces new interfaces and behavior > for consumers. > > I'd suggest that this maybe should be a fast-track instead of self > review, unless there is some particular rush to get this case through? > Please consider promoting it to a fast track. In any case, I'll happily > give it a +1. > > Btw, you failed to specify a release binding. Is this patch or minor > (or something else)? (It looks like this could be Patch binding fairly > easily...) > > - Garrett I'm not opposed to making it a fast track. However, I'd like to ask you to reconsider. It's a trivial option being implemented purely for Linux compatibility. Software we care about (Xorg) uses it, which is the sole reason for introducing it. It seems well below the line to me... I did specify the release binding, in the middle: >> ----- >> >> Release Binding: Patch/Micro >> >> New ld options: >> -z wrap Committed >> -wrap Committed >> --wrap Committed >> >> ----- Thanks... - Ali From gdamore@sun.com Wed Sep 16 08:50:50 2009 Received: from sunmail5.uk.sun.com (sunmail5.UK.Sun.COM [129.156.85.165]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n8GFonfj026822 for ; Wed, 16 Sep 2009 08:50:49 -0700 (PDT) Received: from nwk-avmta-1.SFBay.Sun.COM (nwk-avmta-1.SFBay.Sun.COM [129.146.11.74]) by sunmail5.uk.sun.com (8.13.8+Sun/8.13.8/ENSMAIL,v2.2) with ESMTP id n8GFocQ4026061 for <@sunmail2sca.sfbay.sun.com:PSARC-ext@sun.com>; Wed, 16 Sep 2009 16:50:48 +0100 (BST) Received: from pmxchannel-daemon.nwk-avmta-1.sfbay.Sun.COM by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0KQ200013MOKIP00@nwk-avmta-1.sfbay.Sun.COM> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 16 Sep 2009 08:50:44 -0700 (PDT) Received: from sca-es-mail-1.sun.com ([192.18.43.132]) by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0KQ200IY7MOKP690@nwk-avmta-1.sfbay.Sun.COM> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 16 Sep 2009 08:50:44 -0700 (PDT) Received: from fe-sfbay-09.sun.com ([192.18.43.129]) by sca-es-mail-1.sun.com (8.13.7+Sun/8.12.9) with ESMTP id n8GFoiwe022303 for ; Wed, 16 Sep 2009 08:50:44 -0700 (PDT) Received: from conversion-daemon.fe-sfbay-09.sun.com by fe-sfbay-09.sun.com (Sun Java(tm) System Messaging Server 7u2-7.04 64bit (built Jul 2 2009)) id <0KQ200100MADEG00@fe-sfbay-09.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 16 Sep 2009 08:50:44 -0700 (PDT) Received: from [192.168.251.11] ([unknown] [76.93.15.33]) by fe-sfbay-09.sun.com (Sun Java(tm) System Messaging Server 7u2-7.04 64bit (built Jul 2 2009)) with ESMTPSA id <0KQ200APFMOJNA80@fe-sfbay-09.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 16 Sep 2009 08:50:44 -0700 (PDT) Date: Wed, 16 Sep 2009 08:50:43 -0700 From: "Garrett D'Amore" Subject: Re: PSARC 2009/493 ld -z wrap option In-reply-to: <4AB1079A.1090707@Sun.COM> Sender: Garrett.Damore@sun.com To: Darren J Moffat Cc: Ali Bahrami , PSARC-ext@sun.com Message-id: <4AB10953.4020102@sun.com> MIME-version: 1.0 Content-type: text/plain; CHARSET=US-ASCII; format=flowed Content-transfer-encoding: 7BIT X-PMX-Version: 5.4.1.325704 References: <4AB1029B.7090903@Sun.COM> <4AB105B1.3070200@sun.com> <4AB1079A.1090707@Sun.COM> User-Agent: Thunderbird 2.0.0.18 (X11/20081201) Status: RO Content-Length: 1468 Darren J Moffat wrote: > Garrett D'Amore wrote: >> This looks like a potentially handy feature, and the architecture >> seems fairly straight-forward. However, I'm not sure it qualifies >> for self-review. (Although the bar for self review seems to be >> moving somewhat...) If only because it introduces new interfaces and >> behavior for consumers. >> >> I'd suggest that this maybe should be a fast-track instead of self >> review, unless there is some particular rush to get this case >> through? Please consider promoting it to a fast track. In any case, >> I'll happily give it a +1. > > Given this is being included explicitly for compatibility with GNU ld > there is nothing ARC can change anyway. It is only a +1 or rederail > and vote no type of case. So I really don't see the point in adding > pointless extra process for a case like this. Actually, as a fast track, it doesn't really add any process *as long as someone reviews it*. Obviously both of us have reviewed it, so that burden doesn't add anything to this caes. It *does* incur a little extra delay to wait for a fast track timeout. I don't think that is too onerous. Note that I'm *not* suggesting that this should be a full case. :-) IMO familiarity doesn't automatically make it self-review. Otherwise we might as well just abdicate all architecture and allow anything from GNU/Linux to come in. That doesn't seem to have been the precedent. - Garrett From gdamore@sun.com Wed Sep 16 08:55:59 2009 Received: from sunmail2sca.sfbay.sun.com (sunmail2sca.SFBay.Sun.COM [129.145.155.234]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n8GFtwa1027230 for ; Wed, 16 Sep 2009 08:55:58 -0700 (PDT) Received: from nwk-avmta-1.SFBay.Sun.COM (nwk-avmta-1.SFBay.Sun.COM [129.146.11.74]) by sunmail2sca.sfbay.sun.com (8.13.8+Sun/8.13.8/ENSMAIL,v2.4) with ESMTP id n8GFtrvp026912 for <@sunmail2sca.sfbay.sun.com:PSARC-ext@sun.com>; Wed, 16 Sep 2009 08:55:58 -0700 (PDT) Received: from pmxchannel-daemon.nwk-avmta-1.sfbay.Sun.COM by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0KQ20011JMX55500@nwk-avmta-1.sfbay.Sun.COM> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 16 Sep 2009 08:55:53 -0700 (PDT) Received: from sca-es-mail-1.sun.com ([192.18.43.132]) by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0KQ200IBHMX2P6A0@nwk-avmta-1.sfbay.Sun.COM> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 16 Sep 2009 08:55:50 -0700 (PDT) Received: from fe-sfbay-10.sun.com ([192.18.43.129]) by sca-es-mail-1.sun.com (8.13.7+Sun/8.12.9) with ESMTP id n8GFtoXF022938 for ; Wed, 16 Sep 2009 08:55:50 -0700 (PDT) Received: from conversion-daemon.fe-sfbay-10.sun.com by fe-sfbay-10.sun.com (Sun Java(tm) System Messaging Server 7u2-7.04 64bit (built Jul 2 2009)) id <0KQ200500ME2EE00@fe-sfbay-10.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 16 Sep 2009 08:55:50 -0700 (PDT) Received: from [192.168.251.11] ([unknown] [76.93.15.33]) by fe-sfbay-10.sun.com (Sun Java(tm) System Messaging Server 7u2-7.04 64bit (built Jul 2 2009)) with ESMTPSA id <0KQ2007A5MX1DCC0@fe-sfbay-10.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 16 Sep 2009 08:55:50 -0700 (PDT) Date: Wed, 16 Sep 2009 08:55:49 -0700 From: "Garrett D'Amore" Subject: Re: PSARC 2009/493 ld -z wrap option In-reply-to: <4AB1084E.402@Sun.COM> Sender: Garrett.Damore@sun.com To: Ali Bahrami Cc: PSARC-ext@sun.com Message-id: <4AB10A85.5090605@sun.com> MIME-version: 1.0 Content-type: text/plain; CHARSET=US-ASCII; format=flowed Content-transfer-encoding: 7BIT X-PMX-Version: 5.4.1.325704 References: <4AB1029B.7090903@Sun.COM> <4AB105B1.3070200@sun.com> <4AB1084E.402@Sun.COM> User-Agent: Thunderbird 2.0.0.18 (X11/20081201) Status: RO Content-Length: 2064 Ali Bahrami wrote: > Garrett D'Amore wrote: >> This looks like a potentially handy feature, and the architecture >> seems fairly straight-forward. However, I'm not sure it qualifies >> for self-review. (Although the bar for self review seems to be >> moving somewhat...) If only because it introduces new interfaces and >> behavior for consumers. >> >> I'd suggest that this maybe should be a fast-track instead of self >> review, unless there is some particular rush to get this case >> through? Please consider promoting it to a fast track. In any case, >> I'll happily give it a +1. >> >> Btw, you failed to specify a release binding. Is this patch or minor >> (or something else)? (It looks like this could be Patch binding >> fairly easily...) >> >> - Garrett > > I'm not opposed to making it a fast track. However, I'd like to ask > you to > reconsider. It's a trivial option being implemented purely for Linux > compatibility. Software we care about (Xorg) uses it, which is the sole > reason for introducing it. It seems well below the line to me... I guess I see the line differently than you do. To me the line is set for things that: a) introduce or modify no non-Private interfaces or b) backed by well established precedent (e.g. drivers for new hardware that follow established architecture for devices of the given type) Admittedly, this case probably is pretty close to the line on "b". Really, apart from the incursion of a little extra delay (probably one week in this case), there is nothing else needed at this point if your case is turned into a fast track, except in the unlikely event that someone takes exception with the case. > > I did specify the release binding, in the middle: > > >> ----- > >> > >> Release Binding: Patch/Micro Ah I must have missed that. - Garrett > >> > >> New ld options: > >> -z wrap Committed > >> -wrap Committed > >> --wrap Committed > >> > >> ----- > > Thanks... > > - Ali From Rod.Evans@sun.com Wed Sep 16 09:08:55 2009 Received: from sunmail5.uk.sun.com (sunmail5.UK.Sun.COM [129.156.85.165]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n8GG8s5G028101 for ; Wed, 16 Sep 2009 09:08:54 -0700 (PDT) Received: from nwk-avmta-1.SFBay.Sun.COM (nwk-avmta-1.SFBay.Sun.COM [129.146.11.74]) by sunmail5.uk.sun.com (8.13.8+Sun/8.13.8/ENSMAIL,v2.2) with ESMTP id n8GG8hHj007891; Wed, 16 Sep 2009 17:08:51 +0100 (BST) Received: from pmxchannel-daemon.nwk-avmta-1.sfbay.Sun.COM by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0KQ200301NIOAY00@nwk-avmta-1.sfbay.Sun.COM>; Wed, 16 Sep 2009 09:08:48 -0700 (PDT) Received: from jurassic-x4600.sfbay.sun.com ([129.146.17.59]) by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0KQ200IELNIOP8B0@nwk-avmta-1.sfbay.Sun.COM>; Wed, 16 Sep 2009 09:08:48 -0700 (PDT) Received: from [129.146.228.120] (chaz.SFBay.Sun.COM [129.146.228.120]) by jurassic-x4600.sfbay.sun.com (8.14.3+Sun/8.14.3) with ESMTP id n8GG8mLZ211203; Wed, 16 Sep 2009 09:08:48 -0700 (PDT) Date: Wed, 16 Sep 2009 09:11:46 -0700 From: Rod Evans Subject: Re: PSARC 2009/493 ld -z wrap option In-reply-to: <4AB10A85.5090605@sun.com> To: "Garrett D'Amore" Cc: Ali Bahrami , PSARC-ext@sun.com Reply-to: Rod.Evans@sun.com Message-id: <4AB10E42.2050007@sun.com> Organization: Sun Microsystems Inc. MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7BIT X-PMX-Version: 5.4.1.325704 References: <4AB1029B.7090903@Sun.COM> <4AB105B1.3070200@sun.com> <4AB1084E.402@Sun.COM> <4AB10A85.5090605@sun.com> User-Agent: Thunderbird 2.0.0.22 (X11/20090818) Status: RO Content-Length: 814 Garrett D'Amore wrote: > Really, apart from the incursion of a little extra delay (probably one > week in this case), there is nothing else needed at this point if your > case is turned into a fast track, except in the unlikely event that > someone takes exception with the case. I still don't see the point. We don't decide upon submitting a fast-track, or a self-review case based on the time we wish to wait for the process to complete, we always wait a day or two after submitting a self-review to ensure we give folks time to comment. We make the distinction based upon whether we feel there's any architectural issues that might concern or be of interest to the ARC. In this case, as with most linker cases, we don't think there are. Thus, we're going to use the lightest weight process. -- Rod. From Alan.Coopersmith@sun.com Wed Sep 16 09:11:50 2009 Received: from sunmail5.uk.sun.com (sunmail5.UK.Sun.COM [129.156.85.165]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n8GGBnUe028481 for ; Wed, 16 Sep 2009 09:11:49 -0700 (PDT) Received: from nwk-avmta-1.SFBay.Sun.COM (nwk-avmta-1.SFBay.Sun.COM [129.146.11.74]) by sunmail5.uk.sun.com (8.13.8+Sun/8.13.8/ENSMAIL,v2.2) with ESMTP id n8GGBfT2010115 for <@sunmail2sca.sfbay.sun.com:PSARC-ext@sun.com>; Wed, 16 Sep 2009 17:11:48 +0100 (BST) Received: from pmxchannel-daemon.nwk-avmta-1.sfbay.Sun.COM by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0KQ200301NNKQG00@nwk-avmta-1.sfbay.Sun.COM> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 16 Sep 2009 09:11:44 -0700 (PDT) Received: from sca-es-mail-2.sun.com ([192.18.43.133]) by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0KQ200IY5NNKP8B0@nwk-avmta-1.sfbay.Sun.COM> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 16 Sep 2009 09:11:44 -0700 (PDT) Received: from fe-sfbay-09.sun.com ([192.18.43.129]) by sca-es-mail-2.sun.com (8.13.7+Sun/8.12.9) with ESMTP id n8GGBijL021359 for ; Wed, 16 Sep 2009 09:11:44 -0700 (PDT) Received: from conversion-daemon.fe-sfbay-09.sun.com by fe-sfbay-09.sun.com (Sun Java(tm) System Messaging Server 7u2-7.04 64bit (built Jul 2 2009)) id <0KQ200E00NGUSY00@fe-sfbay-09.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 16 Sep 2009 09:11:44 -0700 (PDT) Received: from [129.145.155.53] ([unknown] [129.145.155.53]) by fe-sfbay-09.sun.com (Sun Java(tm) System Messaging Server 7u2-7.04 64bit (built Jul 2 2009)) with ESMTPSA id <0KQ200DMNNNJXP20@fe-sfbay-09.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 16 Sep 2009 09:11:44 -0700 (PDT) Date: Wed, 16 Sep 2009 09:11:43 -0700 From: Alan Coopersmith Subject: Re: PSARC 2009/493 ld -z wrap option In-reply-to: <4AB10A85.5090605@sun.com> Sender: Alan.Coopersmith@sun.com To: "Garrett D'Amore" Cc: Ali Bahrami , PSARC-ext@sun.com Message-id: <4AB10E3F.3060801@sun.com> MIME-version: 1.0 Content-type: text/plain; CHARSET=US-ASCII Content-transfer-encoding: 7BIT X-PMX-Version: 5.4.1.325704 X-Enigmail-Version: 0.95.1 References: <4AB1029B.7090903@Sun.COM> <4AB105B1.3070200@sun.com> <4AB1084E.402@Sun.COM> <4AB10A85.5090605@sun.com> User-Agent: Thunderbird 2.0.0.21 (X11/20090323) Status: RO Content-Length: 384 Garrett D'Amore wrote: > b) backed by well established precedent (e.g. drivers for new > hardware that follow established architecture for devices of the given > type) There's at least 10 years of precedent of introducing new public ld flags in self-review cases. -- -Alan Coopersmith- alan.coopersmith@sun.com Sun Microsystems, Inc. - X Window System Engineering From gdamore@sun.com Wed Sep 16 09:39:36 2009 Received: from sunmail2sca.sfbay.sun.com (sunmail2sca.SFBay.Sun.COM [129.145.155.234]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id n8GGdZA7003440 for ; Wed, 16 Sep 2009 09:39:35 -0700 (PDT) Received: from brm-avmta-1.central.sun.com (brm-avmta-1.Central.Sun.COM [129.147.4.11]) by sunmail2sca.sfbay.sun.com (8.13.8+Sun/8.13.8/ENSMAIL,v2.4) with ESMTP id n8GGdZAK015612 for <@sunmail2sca.sfbay.sun.com:PSARC-ext@sun.com>; Wed, 16 Sep 2009 09:39:35 -0700 (PDT) Received: from pmxchannel-daemon.brm-avmta-1.central.sun.com by brm-avmta-1.central.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0KQ200703OXZKR00@brm-avmta-1.central.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 16 Sep 2009 10:39:35 -0600 (MDT) Received: from sca-es-mail-2.sun.com ([192.18.43.133]) by brm-avmta-1.central.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0KQ200HPROXYT2E0@brm-avmta-1.central.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 16 Sep 2009 10:39:34 -0600 (MDT) Received: from fe-sfbay-10.sun.com ([192.18.43.129]) by sca-es-mail-2.sun.com (8.13.7+Sun/8.12.9) with ESMTP id n8GGdYv3024533 for ; Wed, 16 Sep 2009 09:39:34 -0700 (PDT) Received: from conversion-daemon.fe-sfbay-10.sun.com by fe-sfbay-10.sun.com (Sun Java(tm) System Messaging Server 7u2-7.04 64bit (built Jul 2 2009)) id <0KQ200J00OIFK900@fe-sfbay-10.sun.com> for PSARC-ext@sun.com (ORCPT PSARC-ext@sun.com); Wed, 16 Sep 2009 09:39:34 -0700 (PDT) Received: from [192.168.251.11] ([unknown] [76.93.15.33]) by fe-sfbay-10.sun.com (Sun Java(tm) System Messaging Server 7u2-7.04 64bit (built Jul 2 2009)) with ESMTPSA id <0KQ2007XKOXYJ8F0@fe-sfbay-10.sun.com>; Wed, 16 Sep 2009 09:39:34 -0700 (PDT) Date: Wed, 16 Sep 2009 09:39:33 -0700 From: "Garrett D'Amore" Subject: Re: PSARC 2009/493 ld -z wrap option In-reply-to: <4AB10E42.2050007@sun.com> Sender: Garrett.Damore@sun.com To: Rod.Evans@sun.com Cc: Ali Bahrami , PSARC-ext@sun.com Message-id: <4AB114C5.8070300@sun.com> MIME-version: 1.0 Content-type: text/plain; CHARSET=US-ASCII; format=flowed Content-transfer-encoding: 7BIT X-PMX-Version: 5.4.1.325704 References: <4AB1029B.7090903@Sun.COM> <4AB105B1.3070200@sun.com> <4AB1084E.402@Sun.COM> <4AB10A85.5090605@sun.com> <4AB10E42.2050007@sun.com> User-Agent: Thunderbird 2.0.0.18 (X11/20081201) Status: RO Content-Length: 1063 Rod Evans wrote: > Garrett D'Amore wrote: > >> Really, apart from the incursion of a little extra delay (probably >> one week in this case), there is nothing else needed at this point if >> your case is turned into a fast track, except in the unlikely event >> that someone takes exception with the case. > > I still don't see the point. > > We don't decide upon submitting a fast-track, or a self-review case > based on the time we wish to wait for the process to complete, we > always wait a day or two after submitting a self-review to ensure > we give folks time to comment. > > We make the distinction based upon whether we feel there's any > architectural issues that might concern or be of interest to the > ARC. In this case, as with most linker cases, we don't think there > are. Thus, we're going to use the lightest weight process. > Alright, I yield. I thought that there might be something here of architectural interest. I guess nobody else thinks so, and I'm happy with the case as specified, so let it go as self-review. - Garrett