From Govinda.Tatti@oracle.com Thu May 13 15:18:58 2010 Received: from newsunmail1brm.central.sun.com (newsunmail1brm.Central.Sun.COM [129.147.62.245]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id o4DMIwM2004469 for ; Thu, 13 May 2010 15:18:58 -0700 (PDT) Received: from nwk-avmta-1.SFBay.Sun.COM (nwk-avmta-1.SFBay.Sun.COM [129.146.11.74]) by newsunmail1brm.central.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.4) with ESMTP id o4DMIvTv051271; Thu, 13 May 2010 16:18:57 -0600 (MDT) Received: from pmxchannel-daemon.nwk-avmta-1.sfbay.Sun.COM by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0L2D00L01PZLEN00@nwk-avmta-1.sfbay.Sun.COM>; Thu, 13 May 2010 15:18:57 -0700 (PDT) Received: from brmea-mail-4.sun.com ([192.18.98.36]) by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0L2D00BLAPZK51B0@nwk-avmta-1.sfbay.Sun.COM>; Thu, 13 May 2010 15:18:57 -0700 (PDT) Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by brmea-mail-4.sun.com (8.13.6+Sun/8.12.9) with ESMTP id o4DMIuAg021536; Thu, 13 May 2010 22:18:56 +0000 (GMT) Received: from acsmt355.oracle.com (acsmt355.oracle.com [141.146.40.155]) by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o4DLvrH3014850; Thu, 13 May 2010 22:18:55 +0000 (GMT) Received: from abhmt021.oracle.com by acsmt353.oracle.com with ESMTP id 239834971273789050; Thu, 13 May 2010 15:17:30 -0700 Received: from [129.146.96.124] (/129.146.96.124) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 13 May 2010 15:17:30 -0700 Date: Thu, 13 May 2010 15:19:05 -0700 From: Govinda Tatti Subject: Renaming interrupt affinity interfaces [PSARC/2010/172 FastTrack timeout 05/20/10] To: PSARC-ext@sun.com Cc: ddi-intr-iteam@sun.com, rao.shoaib@sun.com, nicolas.droux@sun.com, rajagopal.kunhappan@sun.com Message-id: <4BEC7AD9.5050703@Oracle.COM> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7BIT X-PMX-Version: 5.4.1.325704 X-Source-IP: acsmt355.oracle.com [141.146.40.155] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090207.4BEC7AD0.0079:SCFMA4539814,ss=1,fgs=0 User-Agent: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.9.1.9) Gecko/20100318 Lightning/1.0b1 Thunderbird/3.0.4 Status: RO Content-Length: 3092 I'm sponsoring the following fasttrack for Evan Yan. The timer is set to expire on 05/20/2010. - Govinda Template Version: @(#)sac_nextcase 1.70 03/30/10 SMI This information is Copyright (c) 2010, Oracle and/or its affiliates. All rights reserved. 1. Introduction 1.1. Project/Component Working Name: Renaming interrupt affinity interfaces 1.2. Name of Document Author/Supplier: Author: Evan Yan 1.3 Date of This Document: 13 May, 2010 4. Technical Description 4.1. Project Summary: This proposal is to rename the interrupt affinity interfaces introduced by PSARC/2009/340, and move them into some internal or platform specific files. Currently, the ddi_intr_get/set_target() interfaces are project private ones, and are restricted just to Crossbow framework. These interfaces will continue to be restricted in long-term just to IO frameworks such as Crossbow, NUMA etc and there is no plan to extend them to any DDI complaint drivers. This changes are expected to be backported to S10 after the changes of PSARC/2009/340 are backported, so micro/patch binding is requested. 4.2. Project Description: Rename the ddi_intr_get/set_affinity() interfaces to the following interfaces. /* * Get/Set interrupt affinity functions */ int get_intr_affinity(ddi_intr_handle_t h, processorid_t *pid_p); int set_intr_affinity(ddi_intr_handle_t h, processorid_t pid); And move the interface declarations and implementations from ddi_intr.[ch] to ddi_intr_impl.[ch]. The following type definition in ddi_intr.h will be removed. typedef processorid_t ddi_intr_target_t; Accordingly, the definition of the member ih_target of ddi_intr_handle_impl_t will be modified from ddi_intr_target_t ih_target; to processorid_t ih_target; The flag DDI_INTR_FLAG_RETARGETABLE will also be removed, and ddi_intr_get_cap() will not return this flag any more. The renamed interface set_intr_affinity() will still be limited to MSI-X interrupts. It will return DDI_EINVAL directly for INTx and MSI interrupts. The ddi_intr_set_affinity() interface are currently used by crossbow in mac_datapath_setup.c, which will also be updated to call the renamed interfaces instead. 4.3. Bug/RFE Number(s): 6948283 Renaming of existing ddi interrupt re-target interfaces 4.4. Interfaces: Interface Stability Comments ----------------------------+---------------+-------------------------- ddi_intr_target_t Project Removed Private DDI_INTR_FLAG_RETARGETABLE Project Removed Private get_intr_affinity Project Renamed from Private ddi_intr_get_affinity set_intr_affinity Project Renamed from Private ddi_intr_set_affinity 4.5. Reference: PSARC/2009/340 Interrupt affinity interfaces and PCITool enhancements 6. Resources and Schedule 6.4. Steering Committee requested information 6.4.1. Consolidation C-team Name: ON 6.5. ARC review type: FastTrack 6.6. ARC Exposure: open From garrett.damore@oracle.com Thu May 13 15:31:22 2010 Received: from newsunmail1brm.central.sun.com (newsunmail1brm.Central.Sun.COM [129.147.62.245]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id o4DMVMlN004734 for ; Thu, 13 May 2010 15:31:22 -0700 (PDT) Received: from brm-avmta-1.central.sun.com (brm-avmta-1.Central.Sun.COM [129.147.4.11]) by newsunmail1brm.central.sun.com (8.13.7+Sun/8.13.7/ENSMAIL,v2.4) with ESMTP id o4DMVLfe056508; Thu, 13 May 2010 16:31:21 -0600 (MDT) Received: from pmxchannel-daemon.brm-avmta-1.central.sun.com by brm-avmta-1.central.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0L2D00B01QK9ZE00@brm-avmta-1.central.sun.com>; Thu, 13 May 2010 16:31:21 -0600 (MDT) Received: from sca-ea-mail-4.sun.com ([192.18.43.22]) by brm-avmta-1.central.sun.com (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0L2D006ENQK8FO20@brm-avmta-1.central.sun.com>; Thu, 13 May 2010 16:31:20 -0600 (MDT) Received: from rcsinet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by sca-ea-mail-4.sun.com (8.13.6+Sun/8.12.9) with ESMTP id o4DMVJp9027255; Thu, 13 May 2010 22:31:20 +0000 (GMT) Received: from acsmt353.oracle.com (acsmt353.oracle.com [141.146.40.153]) by rcsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o4DLSaFd026338; Thu, 13 May 2010 22:31:18 +0000 (GMT) Received: from abhmt021.oracle.com by acsmt355.oracle.com with ESMTP id 263484501273789867; Thu, 13 May 2010 15:31:07 -0700 Received: from [10.7.251.172] (/10.7.251.172) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 13 May 2010 15:31:06 -0700 Date: Thu, 13 May 2010 15:31:05 -0700 From: "Garrett D'Amore" Subject: Re: Renaming interrupt affinity interfaces [PSARC/2010/172 FastTrack timeout 05/20/10] In-reply-to: <4BEC7AD9.5050703@Oracle.COM> To: Govinda Tatti Cc: PSARC-ext@sun.com, ddi-intr-iteam@sun.com, rao.shoaib@sun.com, nicolas.droux@sun.com, rajagopal.kunhappan@sun.com Message-id: <4BEC7DA9.8080405@oracle.com> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7BIT X-PMX-Version: 5.4.1.325704 X-Source-IP: acsmt353.oracle.com [141.146.40.153] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090208.4BEC7DB7.00ED:SCFMA4539814,ss=1,fgs=0 References: <4BEC7AD9.5050703@Oracle.COM> User-Agent: Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:1.9.1.8) Gecko/20100412 Lightning/1.0b1 Thunderbird/3.0.3 Status: RO Content-Length: 3640 +1. I always felt the interfaces were not really appropriate for generic drivers to use. - Garrett On 05/13/10 03:19 PM, Govinda Tatti wrote: > I'm sponsoring the following fasttrack for Evan Yan. The timer is > set to expire on 05/20/2010. > > - Govinda > > Template Version: @(#)sac_nextcase 1.70 03/30/10 SMI > This information is Copyright (c) 2010, Oracle and/or its affiliates. > All rights reserved. > 1. Introduction > 1.1. Project/Component Working Name: > Renaming interrupt affinity interfaces > 1.2. Name of Document Author/Supplier: > Author: Evan Yan > 1.3 Date of This Document: > 13 May, 2010 > 4. Technical Description > 4. Technical Description: > 4.1. Project Summary: > > This proposal is to rename the interrupt affinity interfaces > introduced by PSARC/2009/340, and move them into some internal > or platform specific files. > > Currently, the ddi_intr_get/set_target() interfaces are project > private ones, and are restricted just to Crossbow framework. > These interfaces will continue to be restricted in long-term just > to IO frameworks such as Crossbow, NUMA etc and there is no plan > to extend them to any DDI complaint drivers. > > This changes are expected to be backported to S10 after the > changes of PSARC/2009/340 are backported, so micro/patch > binding is requested. > > 4.2. Project Description: > > Rename the ddi_intr_get/set_affinity() interfaces to the > following interfaces. > > /* > * Get/Set interrupt affinity functions > */ > int get_intr_affinity(ddi_intr_handle_t h, processorid_t *pid_p); > int set_intr_affinity(ddi_intr_handle_t h, processorid_t pid); > > And move the interface declarations and implementations from > ddi_intr.[ch] to ddi_intr_impl.[ch]. > > The following type definition in ddi_intr.h will be removed. > > typedef processorid_t ddi_intr_target_t; > > Accordingly, the definition of the member ih_target of > ddi_intr_handle_impl_t will be modified from > > ddi_intr_target_t ih_target; > > to > > processorid_t ih_target; > > The flag DDI_INTR_FLAG_RETARGETABLE will also be removed, and > ddi_intr_get_cap() will not return this flag any more. > > The renamed interface set_intr_affinity() will still be limited > to MSI-X interrupts. It will return DDI_EINVAL directly for INTx > and MSI interrupts. > > The ddi_intr_set_affinity() interface are currently used by > crossbow in mac_datapath_setup.c, which will also be updated > to call the renamed interfaces instead. > > 4.3. Bug/RFE Number(s): > 6948283 Renaming of existing ddi interrupt re-target interfaces > > 4.4. Interfaces: > > Interface Stability Comments > > ----------------------------+---------------+-------------------------- > ddi_intr_target_t Project Removed > Private > DDI_INTR_FLAG_RETARGETABLE Project Removed > Private > get_intr_affinity Project Renamed from > Private ddi_intr_get_affinity > set_intr_affinity Project Renamed from > Private ddi_intr_set_affinity > > 4.5. Reference: > PSARC/2009/340 Interrupt affinity interfaces and PCITool > enhancements > > 6. Resources and Schedule > 6.4. Steering Committee requested information > 6.4.1. Consolidation C-team Name: > ON > 6.5. ARC review type: FastTrack > 6.6. ARC Exposure: open > From Govinda.Tatti@Oracle.COM Thu May 20 09:47:30 2010 Received: from sunmail3mpk.sfbay.sun.com (sunmail3mpk.SFBay.Sun.COM [129.146.11.52]) by sac.sfbay.sun.com (8.13.8+Sun/8.13.8) with ESMTP id o4KGlU9D023716 for ; Thu, 20 May 2010 09:47:30 -0700 (PDT) Received: from nwk-avmta-1.SFBay.Sun.COM (nwk-avmta-1.SFBay.Sun.COM [129.146.11.74]) by sunmail3mpk.sfbay.sun.com (8.13.8+Sun/8.13.8/ENSMAIL,v2.4) with ESMTP id o4KGlQX6009295; Thu, 20 May 2010 09:47:26 -0700 (PDT) Received: from pmxchannel-daemon.nwk-avmta-1.sfbay.Sun.COM by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) id <0L2Q0042M9B2X500@nwk-avmta-1.sfbay.Sun.COM>; Thu, 20 May 2010 09:47:26 -0700 (PDT) Received: from sca-ea-mail-3.sun.com ([192.18.43.21]) by nwk-avmta-1.sfbay.Sun.COM (Sun Java System Messaging Server 6.2-3.04 (built Jul 15 2005)) with ESMTP id <0L2Q00LIN9AZA820@nwk-avmta-1.sfbay.Sun.COM>; Thu, 20 May 2010 09:47:23 -0700 (PDT) Received: from rcsinet13.oracle.com (rcsinet13.oracle.com [148.87.113.125]) by sca-ea-mail-3.sun.com (8.13.6+Sun/8.12.9) with ESMTP id o4KGlNTP023423; Thu, 20 May 2010 16:47:23 +0000 (GMT) Received: from acsmt354.oracle.com (acsmt354.oracle.com [141.146.40.154]) by rcsinet13.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o4KGlKrH022505; Thu, 20 May 2010 16:47:20 +0000 (GMT) Received: from abhmt021.oracle.com by acsmt354.oracle.com with ESMTP id 285201651274373948; Thu, 20 May 2010 09:45:48 -0700 Received: from [129.146.96.124] (/129.146.96.124) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 20 May 2010 09:45:47 -0700 Date: Thu, 20 May 2010 09:45:45 -0700 From: Govinda Tatti Subject: PSARC 2010/172 Renaming interrupt affinity interfaces To: PSARC-ext@sun.com Cc: ddi-intr-iteam@sun.com, rao.shoaib@sun.com, nicolas.droux@sun.com, rajagopal.kunhappan@sun.com Message-id: <4BF56739.3060905@Oracle.COM> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7BIT X-PMX-Version: 5.4.1.325704 X-Source-IP: acsmt354.oracle.com [141.146.40.154] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090209.4BF5679A.014A:SCFMA4539814,ss=1,fgs=0 User-Agent: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.9.1.9) Gecko/20100318 Lightning/1.0b1 Thunderbird/3.0.4 Status: RO Content-Length: 68 This case was approved in yesterday's PSARC meeting. - Govinda